0031325: Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Description

Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Steps To Reproduce

1. Create a layaway and save it without any payment
2. Create a layaway and save it without any payment
3. Open Menu
4. Select "pay open tickets"
5. In the popup select the layaways created in steps 1 and 2
6. press done and layaways will be ready to be paid
7. press f5 or reload
8. When the Web POS is loading an error is shown

OB.Dal: a success callback threw an exception; "function (){if(callback){callback();}}";
TypeError: Cannot read property 'isNegative' of undefined
    at Object.enyo.kind.checkValidCashOverpayment (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1461:17 [^])
    at Object.enyo.kind.checkValidPayments (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1462:575 [^])
    at Object.enyo.kind.buttonStatusChanged (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1433:6 [^])

The only way to reload the app is clearing the cache

Tags

No tags attached.

Attached Files

issue31323.diff [^] (849 bytes) 2015-11-02 16:44 [Show Content] [Hide Content]

diff -r b17dfd0a4fef web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Mon Nov 02 11:06:08 2015 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Mon Nov 02 16:44:21 2015 +0100
@@ -79,7 +79,10 @@
       } else if (!_.isNull(pending) && pending) {
         this.setTotalPending(pending, payment.mulrate, payment.symbol, payment.currencySymbolAtTheRight, inSender, inEvent);
       }
-      this.checkValidPayments(paymentstatus, payment);
+      if (paymentstatus) {
+        debugger;
+        this.checkValidPayments(paymentstatus, payment);  
+      }
       if (!_.isNull(this.receipt) && this.receipt.get('isLayaway') && this.receipt.get('orderType') !== 3) {
         this.$.layawayaction.updateVisibility(true);
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0031323

closed

guilleaer

Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Notes
(0082550) hgbot (developer) 2015-12-02 18:43	Repository: retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal Changeset: 698f1830f625a27a6ce37ea86c819300a5c0d3b8 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Wed Dec 02 17:59:19 2015 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/698f1830f625a27a6ce37ea86c819300a5c0d3b8 [^] Fixed issue 31325: Don't check payments if there is not information about payments --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js ---

Issue History
Date Modified	Username	Field	Change
2015-11-02 16:16	guilleaer	Type	defect => backport
2015-11-02 16:16	guilleaer	Target Version	=> RR15Q3.3
2015-11-02 16:44	guilleaer	File Added: issue31323.diff
2015-12-02 14:30	Orekaria	Assigned To	Retail => guilleaer
2015-12-02 18:43	hgbot	Checkin
2015-12-02 18:43	hgbot	Note Added: 0082550
2015-12-02 18:43	hgbot	Status	scheduled => resolved
2015-12-02 18:43	hgbot	Resolution	open => fixed
2015-12-02 18:43	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/698f1830f625a27a6ce37ea86c819300a5c0d3b8 [^]
2015-12-03 18:02	guilleaer	Review Assigned To	=> Orekaria
2015-12-04 12:41	marvintm	Review Assigned To	Orekaria => marvintm
2015-12-04 12:41	marvintm	Status	resolved => closed
2015-12-04 12:41	marvintm	Fixed in Version	=> RR15Q3.3