Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0031299

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2015-10-29 14:22

2015-11-02 11:11

Reporter

guilleaer

View Status

public

Assigned To

guilleaer

Priority

normal

Resolution

fixed

Fixed in Version

RR15Q3.2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR16Q1

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0031299: Using terminal authentication logs are stored without device information

Description

If someone enable terminal authentication and then the cache is removed, in the first login the deviceid used by logging mechanism is not loaded because it is not in the application cache.

It cause that the log messages are stored without device information

Steps To Reproduce

1. Enable terminal authentication
2. remove cache
3. go to login page
4. link device
5. Do login
6. In the console you will see that this value is null
OB.MobileApp.model.get('logConfiguration').deviceIdentifier;
This value is the one used to set the device id in the log messages.
7. Generate log -> it will appear without device id

Proposed Solution

When the device is linked set the value for this field if it is null

Tags

No tags attached.

fix31299.diff [^] (841 bytes) 2015-10-29 14:23 [Show Content] [Hide Content]

diff -r f60d182dd086 web/org.openbravo.retail.posterminal/js/login/model/login-model.js
--- a/web/org.openbravo.retail.posterminal/js/login/model/login-model.js	Fri Sep 25 05:33:55 2015 +0000
+++ b/web/org.openbravo.retail.posterminal/js/login/model/login-model.js	Thu Oct 29 14:23:03 2015 +0100
@@ -960,6 +960,9 @@
         } else {
           OB.appCaption = inResponse.appCaption;
           me.setTerminalName(inResponse.terminalName);
+          if (me.get('logConfiguration') && me.get('logConfiguration').deviceIdentifier === null) {
+            me.get('logConfiguration').deviceIdentifier = inResponse.terminalName;
+          }
           window.localStorage.setItem('terminalName', inResponse.terminalName);
           window.localStorage.setItem('terminalKeyIdentifier', inResponse.terminalKeyIdentifier);
           callback();

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0031301	RR15Q4	closed	guilleaer	Using terminal authentication logs are stores without device information
depends on	backport	0031302	RR15Q3.2	closed	guilleaer	Using terminal authentication logs are stores without device information

Notes
(0081397) hgbot (developer) 2015-10-30 09:15	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 01fb3abfb72c5d236fe113e52093c91920dda134 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Fri Oct 30 09:14:32 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/01fb3abfb72c5d236fe113e52093c91920dda134 [^] fixed issue 31299: device id is set fine when terminal authentication is enabled --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js ---

Issue History
Date Modified	Username	Field	Change
2015-10-29 14:22	guilleaer	New Issue
2015-10-29 14:22	guilleaer	Assigned To	=> guilleaer
2015-10-29 14:22	guilleaer	OBNetwork customer	=> No
2015-10-29 14:22	guilleaer	Triggers an Emergency Pack	=> No
2015-10-29 14:23	guilleaer	File Added: fix31299.diff
2015-10-29 15:33	guilleaer	Status	new => scheduled
2015-10-29 18:02	guilleaer	Summary	Using terminal authentication logs are stores without device information => Using terminal authentication logs are stored without device information
2015-10-30 09:15	hgbot	Checkin
2015-10-30 09:15	hgbot	Note Added: 0081397
2015-10-30 09:15	hgbot	Status	scheduled => resolved
2015-10-30 09:15	hgbot	Resolution	open => fixed
2015-10-30 09:15	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/01fb3abfb72c5d236fe113e52093c91920dda134 [^]
2015-10-30 11:14	guilleaer	Review Assigned To	=> migueldejuana
2015-11-02 11:11	marvintm	Review Assigned To	migueldejuana => marvintm
2015-11-02 11:11	marvintm	Status	resolved => closed
2015-11-02 11:11	marvintm	Fixed in Version	=> RR15Q3.2

Copyright © 2000 - 2009 MantisBT Group