|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|defect||[Openbravo ERP] A. Platform||minor||have not tried||2015-10-22 11:38||2015-11-23 21:16|
|Priority||immediate||Resolution||fixed||Fixed in Version||3.0PR16Q1|
|Status||closed||Fix in branch||Fixed in SCM revision||2611ac34f778|
|OS Version||Database version||Ant version|
|Product Version||SCM revision|
|Review Assigned To||AugustoMauch|
|Regression level||Production - Confirmed Stable|
|Regression introduced in release||3.0PR15Q1|
|Regression introduced by commit||http://code.openbravo.com/erp/devel/pi/rev/84865a340443fbc6aa5c36d777c8c57df2f6525b [^]|
|Triggers an Emergency Pack||No|
0031214: Strange behaviour when refreshing a grid after filtering a product characteristic column
|Description||If the user filters a tab using a product characteristic column and then adds any other filter, the next time the grid is reloaded it be very slow.|
|Steps To Reproduce||== Prepare the data ==|
As F&B Admin:
- Open the Product Characteristic window. Create one variant characteristic.
- In its Value subtab, create a record.
- Open the Product window. Create a new variant product.
- Add in its Characteristics subtab the characteristic you created in the previous step.
- Execute the Create Variants record and refresh the grid. Check that a new product has been created
== Actual Test ==
- In the product window, use the product characteristic filter to show only the records that have the characteristic you defined. This will work properly
- Click the refresh toolbar button. This will work properly
- Add any other filter (for instance, Active=Yes) and refresh the grid again. The tab will show the Loading Data message, but it will not actually load the data.
Note that if the filters are added in the reverse order (first any other than the product characteristic filter, then the product characteristic filter), it works fine.
|Tags||No tags attached.|
edited on: 2015-10-22 12:10
When adding filter having product characteristics filtered this js error can be seen in console:
Uncaught TypeError: _3.condition is not a functionisc_DataSource_evaluateCriterion @ ISC_Combined.js:11189isc_c_Class_invokeSuper @
ISC_Combined.js:245isc_c_Class_Super @ ISC_Combined.js:237isc.OBRestDataSource.addProperties.evaluateCriterion @ 89bf017c1690600804468d571109daf.js:197_31
This error was also present in previous releases (<=PR14Q4)
The problem is in OBViewGrid.filterData method, when it tries to do Super.('filterData'...) in this situation invokes for some reason filterData method in VLayout (which doesn't exist) data is not actually refreshed and callback is never invoked.
This problem was present in <=PR14Q4, but OBViewGrid.filterData was invoked 3 times, the 1st one as it is now but the subsequent ones invoked filterData properly in OBGrid hidding this initial problem.
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 22 15:26:37 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2611ac34f778e07a9bbc92d6f699018a9f0ee8a6 [^]
fixed bug 31214: adding extra filter after product characteristics fails
When product characteristics was filtered returning less than 100 records, and
on top of that criteria a new one in another field was added, it was not possible
to refresh the grid anymore.
adaptive filtering was tried to be evaluated for 'exists' search operator. This
operator didn't implement condition funtion which was invoked causing the exception.
This exception left the grid in an inconsistent estate which made not posible to
To fix it, 'condition' function has been implemented for 'exists' search operator,
as this operator can't be evaluted in client side, we can ensure all fields in
grid fulfill any criteria defined by it, so the implementation can return always
|Added test case in TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9880 [^]|
|Code reviewed and verified in pi@3a698bde90ad|
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.
Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
|2015-10-22 11:38||AugustoMauch||New Issue|
|2015-10-22 11:38||AugustoMauch||Assigned To||=> platform|
|2015-10-22 11:38||AugustoMauch||Modules||=> Core|
|2015-10-22 11:38||AugustoMauch||Triggers an Emergency Pack||=> No|
|2015-10-22 11:38||AugustoMauch||Regression introduced in release||=> 3.0PR15Q1|
|2015-10-22 12:07||alostale||Note Added: 0081200|
|2015-10-22 12:10||alostale||Note Edited: 0081200||View Revisions|
|2015-10-22 14:23||alostale||Relationship added||caused by 0025811|
|2015-10-22 14:28||alostale||Note Added: 0081212|
|2015-10-22 15:18||alostale||Status||new => scheduled|
|2015-10-22 15:18||alostale||Assigned To||platform => alostale|
|2015-10-22 15:27||alostale||Review Assigned To||=> AugustoMauch|
|2015-10-22 15:28||alostale||Regression level||=> Production - Confirmed Stable|
|2015-10-22 15:28||alostale||Regression date||=> 2014-11-14|
|2015-10-22 15:28||alostale||Regression introduced by commit||=> http://code.openbravo.com/erp/devel/pi/rev/84865a340443fbc6aa5c36d777c8c57df2f6525b [^]|
|2015-10-22 15:29||hgbot||Note Added: 0081223|
|2015-10-22 15:29||hgbot||Status||scheduled => resolved|
|2015-10-22 15:29||hgbot||Resolution||open => fixed|
|2015-10-22 15:29||hgbot||Fixed in SCM revision||=> http://code.openbravo.com/erp/devel/pi/rev/2611ac34f778e07a9bbc92d6f699018a9f0ee8a6 [^]|
|2015-10-22 16:29||alostale||Note Added: 0081226|
|2015-10-27 09:52||AugustoMauch||Note Added: 0081334|
|2015-10-27 09:52||AugustoMauch||Status||resolved => closed|
|2015-10-27 09:52||AugustoMauch||Fixed in Version||=> 3.0PR16Q1|
|2015-11-23 21:16||hudsonbot||Note Added: 0082148|
|Copyright © 2000 - 2009 MantisBT Group|