Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031106
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POStrivialalways2015-10-08 16:482015-11-08 22:22
ReporterSandrahuguetView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revisiond32194c674c9
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031106: [Price criteria] Products out of the limit will not be filtered by price criteria in remote model

DescriptionProducts out of the limit will not be filtered by price criteria in remote model
Steps To Reproduce-In the back office, in preference window enable "Enable Remote for Product" preference
-Log in in WebPOS
-Type in product filter text: "Adhesive body warmers"
-Notice than the price of this product is 3.60
-Clean the results
-Click on Price criteria button and filter by: "Equals 3.60", notice that the product will not appear in the list.

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0031257RR16Q2 closedSandrahuguet Prevent sql injection in SimpleQueryBuilder 

-  Notes
(0080951)
hgbot (developer)
2015-10-13 10:38

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 02a66121f70ceb0cda1bf1baa816cce067a591a8
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Oct 08 17:13:29 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/02a66121f70ceb0cda1bf1baa816cce067a591a8 [^]

related to issue 31106 added new operators to SimpleQueryBuilder

---
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
---
(0081095)
hgbot (developer)
2015-10-19 16:42

Repository: erp/pmods/org.openbravo.retail.pricecriteria
Changeset: 0085e15988df7cb564076a81233b760881cb2128
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Oct 19 16:28:05 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/0085e15988df7cb564076a81233b760881cb2128 [^]

Fixed bug 31106 Products out of the limit will not be filtered by price in remote

---
M web/org.openbravo.retail.pricecriteria/js/hookPriceCriteria.js
A src/org/openbravo/retail/pricecriteria/PriceChHQLCriteria.java
A src/org/openbravo/retail/pricecriteria/PriceChValueHQLCriteria.java
---
(0081096)
hgbot (developer)
2015-10-19 16:48

Repository: tools/automation/pi-mobile
Changeset: bb53ade384ec15723475c1248d28b354c794801a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Oct 19 16:48:12 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bb53ade384ec15723475c1248d28b354c794801a [^]

related to issue 31106 Added selenium test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/pricecriteria/Issue31106_CheckPriceCriteria.java
---
(0081342)
mtaal (manager)
2015-10-27 11:47

Hi,
I think some code changes can be done:
the for loop can/should be placed inside the following if I think
https://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/0085e15988df7cb564076a81233b760881cb2128#l3.53 [^]

The code in the hqlCriteriaCharacteristicsValue and the hqlCriteriaCharacteristics is the same, so can be shared.

The packFilter variable is not declared but not used in the hqlCriteriaCharacteristics or hqlCriteriaCharacteristicsValue function.
(0081356)
hgbot (developer)
2015-10-27 17:21

Repository: erp/pmods/org.openbravo.retail.pricecriteria
Changeset: d32194c674c94e0af3379567004ce1e030b9eab7
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Oct 27 17:21:05 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/d32194c674c94e0af3379567004ce1e030b9eab7 [^]

fixed bug 31106 applied code review and filter by pricelistversion

---
M src/org/openbravo/retail/pricecriteria/PriceChHQLCriteria.java
M src/org/openbravo/retail/pricecriteria/PriceChValueHQLCriteria.java
M web/org.openbravo.retail.pricecriteria/js/hookPriceCriteria.js
---
(0081365)
hgbot (developer)
2015-10-28 09:28

Repository: tools/automation/pi-mobile
Changeset: 5dfa88e1bd2d1ee0ea4b80e7b849c08d867d1362
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 27 22:31:51 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5dfa88e1bd2d1ee0ea4b80e7b849c08d867d1362 [^]

Related to issue 31106: [Price criteria] Products out of the limit will not be filtered by price criteria in remote model
Add test to high volume test suite

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/suites/ExtModsHighVolSuite.java
---
(0081411)
hgbot (developer)
2015-10-30 14:21

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b2ddbdfbcfc75a753881628f1f9bd46638d851c8
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Oct 30 14:21:01 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b2ddbdfbcfc75a753881628f1f9bd46638d851c8 [^]

related to issue 31106

---
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
---
(0081595)
mtaal (manager)
2015-11-08 22:22

Reviewed and tested

- Issue History
Date Modified Username Field Change
2015-10-08 16:48 Sandrahuguet New Issue
2015-10-08 16:48 Sandrahuguet Assigned To => Sandrahuguet
2015-10-08 16:48 Sandrahuguet Triggers an Emergency Pack => No
2015-10-13 10:38 hgbot Checkin
2015-10-13 10:38 hgbot Note Added: 0080951
2015-10-19 16:42 hgbot Checkin
2015-10-19 16:42 hgbot Note Added: 0081095
2015-10-19 16:42 hgbot Status new => resolved
2015-10-19 16:42 hgbot Resolution open => fixed
2015-10-19 16:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/0085e15988df7cb564076a81233b760881cb2128 [^]
2015-10-19 16:43 Sandrahuguet Assigned To Sandrahuguet => mtaal
2015-10-19 16:48 hgbot Checkin
2015-10-19 16:48 hgbot Note Added: 0081096
2015-10-19 16:49 Sandrahuguet Review Assigned To => mtaal
2015-10-19 16:49 Sandrahuguet Assigned To mtaal => Sandrahuguet
2015-10-27 08:45 mtaal Relationship added related to 0031257
2015-10-27 11:47 mtaal Note Added: 0081342
2015-10-27 11:47 mtaal Status resolved => new
2015-10-27 11:47 mtaal Resolution fixed => open
2015-10-27 17:21 hgbot Checkin
2015-10-27 17:21 hgbot Note Added: 0081356
2015-10-27 17:21 hgbot Status new => resolved
2015-10-27 17:21 hgbot Resolution open => fixed
2015-10-27 17:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/0085e15988df7cb564076a81233b760881cb2128 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.pricecriteria/rev/d32194c674c94e0af3379567004ce1e030b9eab7 [^]
2015-10-28 09:28 hgbot Checkin
2015-10-28 09:28 hgbot Note Added: 0081365
2015-10-30 14:21 hgbot Checkin
2015-10-30 14:21 hgbot Note Added: 0081411
2015-11-08 22:22 mtaal Note Added: 0081595
2015-11-08 22:22 mtaal Status resolved => closed
2015-11-08 22:22 mtaal Fixed in Version => RR16Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker