Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030913
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2015-09-24 09:372015-10-19 12:01
ReporteraaroncaleroView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revisiondb6dcd6f962b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030913: Values shown on EDIT tab (price, discount, total) are not correct

DescriptionWhen the Pricelist used in WebPOS is configured as "not including taxes", the values that are shown on the EDIT tab are wrong.
The Price values shows the product's list price (which is nowhere else used).
The Discount shows either the discount applied to the product (manual or automatic), or the difference between the unit price and the price set manually.
The Total value doesn't subtract the discount of the line.
(see attached screenshot)
Steps To ReproduceLogin on the ERP and configure the price list used in web pos as not including prices.
Go to the Product Window and edit a product's prices so the unit and list price are different.
Login in webpos and create a ticket.
Add the product previously modified.
Click on the line or on the EDIT button to open the EDIT tab.
Verify the values that are shown.
Proposed SolutionSee diff attached
TagsNo tags attached.
Attached Filespng file icon wrong_edit_values.png [^] (189,400 bytes) 2015-09-24 09:37


diff file icon issue30913.diff [^] (4,162 bytes) 2015-10-06 13:45 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0080773)
adrianromero (manager)
2015-10-01 10:29

Attached patch fixes the issue
(0080781)
hgbot (developer)
2015-10-01 12:56

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b70def10baf657a615021299c25522008096eb17
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Sep 30 22:04:07 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b70def10baf657a615021299c25522008096eb17 [^]

Fixed issue 30913: Values shown on EDIT tab (discount, total) are incorrect

The problem was in the old flow of discounts. With the changes made in the new
discounts flow, the old flow don't go through the finishPromotion funtion.

Now, the values are correct applied.

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0080784)
marvintm (manager)
2015-10-01 13:27

The associated commit is not related to this issue. This issue still needs to be fixed.
(0080907)
hgbot (developer)
2015-10-08 23:53

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: db6dcd6f962b34089bfed13f56752a78f01ec84d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Oct 08 15:48:49 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/db6dcd6f962b34089bfed13f56752a78f01ec84d [^]

Fixes issue 0030913: Values shown on EDIT tab (price, discount, total) are not correct
* Price is now line price, discount is the sum of promotion discounts and total is total line minus promotion discounts.
* Added new detail Price std with the product prices before any price change

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0080909)
hgbot (developer)
2015-10-08 23:54

Repository: tools/automation/pi-mobile
Changeset: ad90207fe58512fa52a56f9b0b65e4d21eaf9796
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Oct 08 15:51:53 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ad90207fe58512fa52a56f9b0b65e4d21eaf9796 [^]

related to issue 0030913: Add test to verify that edit tab behavior is correct. Including taxes and not including taxes has been tested

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/VerifyEditTabInformation_IncludingTaxes.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/VerifyEditTabInformation_NotIncludingTaxes.java
---
(0081069)
hgbot (developer)
2015-10-19 11:46

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4ee53ee34276955393a319a3504f0b099ac6c3a8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 19 11:45:24 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4ee53ee34276955393a319a3504f0b099ac6c3a8 [^]

related to issue 30913: Fix price std position

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---

- Issue History
Date Modified Username Field Change
2015-09-24 09:37 aaroncalero New Issue
2015-09-24 09:37 aaroncalero Assigned To => Retail
2015-09-24 09:37 aaroncalero File Added: wrong_edit_values.png
2015-09-24 09:37 aaroncalero Resolution time => 1443650400
2015-09-24 09:37 aaroncalero Triggers an Emergency Pack => No
2015-10-01 10:29 adrianromero Note Added: 0080773
2015-10-01 12:33 adrianromero File Added: issue30913.diff
2015-10-01 12:33 adrianromero Proposed Solution updated
2015-10-01 12:39 adrianromero Assigned To Retail => adrianromero
2015-10-01 12:56 hgbot Checkin
2015-10-01 12:56 hgbot Note Added: 0080781
2015-10-01 12:56 hgbot Status new => resolved
2015-10-01 12:56 hgbot Resolution open => fixed
2015-10-01 12:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b70def10baf657a615021299c25522008096eb17 [^]
2015-10-01 13:07 marvintm Target Version => RR15Q4
2015-10-01 13:27 marvintm Note Added: 0080784
2015-10-01 13:27 marvintm Status resolved => new
2015-10-01 13:27 marvintm Resolution fixed => open
2015-10-01 13:28 marvintm Target Version RR15Q4 =>
2015-10-02 10:30 adrianromero File Deleted: issue30913.diff
2015-10-02 10:30 adrianromero Proposed Solution updated
2015-10-02 11:39 Orekaria Status new => scheduled
2015-10-02 11:56 adrianromero File Added: issue30913.diff
2015-10-02 11:56 adrianromero Proposed Solution updated
2015-10-06 12:53 adrianromero File Deleted: issue30913.diff
2015-10-06 12:53 adrianromero File Added: issue30913.diff
2015-10-06 13:45 adrianromero File Deleted: issue30913.diff
2015-10-06 13:45 adrianromero File Added: issue30913.diff
2015-10-07 10:59 avicente Issue Monitored: avicente
2015-10-07 12:11 agete Issue Monitored: agete
2015-10-07 13:35 Orekaria Assigned To adrianromero => Retail
2015-10-07 13:35 Orekaria Status scheduled => acknowledged
2015-10-08 09:48 Orekaria Issue Monitored: adrianromero
2015-10-08 11:44 guilleaer Assigned To Retail => guilleaer
2015-10-08 23:53 hgbot Checkin
2015-10-08 23:53 hgbot Note Added: 0080907
2015-10-08 23:53 hgbot Status acknowledged => resolved
2015-10-08 23:53 hgbot Resolution open => fixed
2015-10-08 23:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b70def10baf657a615021299c25522008096eb17 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/db6dcd6f962b34089bfed13f56752a78f01ec84d [^]
2015-10-08 23:54 hgbot Checkin
2015-10-08 23:54 hgbot Note Added: 0080909
2015-10-09 00:11 Orekaria Review Assigned To => marvintm
2015-10-19 11:46 hgbot Checkin
2015-10-19 11:46 hgbot Note Added: 0081069
2015-10-19 12:01 marvintm Status resolved => closed
2015-10-19 12:01 marvintm Fixed in Version => RR16Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker