0030864: Boolean filters cannot be used with remote criterias

Description

It is not possible to send a boolean filter to a server side query using Remote Criterias

Steps To Reproduce

Verify on the SimpleQueryBuilder.java file (in Mobile Core) that all filters are built with quotes (so they are treated like string filters).
Boolean filters don'w use quotes in hql.

Proposed Solution

Attached proposed solution

Tags

No tags attached.

Attached Files

mobilecore.diff [^] (713 bytes) 2015-09-18 08:58 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java b/src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
--- a/src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
+++ b/src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
@@ -296,6 +296,8 @@
           if (objFilter.getString("operator").equals("equals")) {
             if (objFilter.has("isId") && objFilter.getBoolean("isId")) {
               operatorValue = "='" + value + "'";
+            } else if (objFilter.has("boolean") && objFilter.getBoolean("boolean")) {
+              operatorValue = "=" + value;
             } else {
               operatorValue = "=upper('" + value + "')";
             }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0081099) hgbot (developer) 2015-10-19 18:57	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 83f39c7d21d00ee7ed562faf2767fea9465135ea Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Mon Oct 19 12:38:02 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/83f39c7d21d00ee7ed562faf2767fea9465135ea [^] Fixes issue 0030864: Boolean filters cannot be used with remote criterias * Adding the logic for boolean filters --- M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java ---

(0081526) dmitry_mezentsev (viewer) 2015-11-05 16:44	Not closed for 17 days!!! Please find someone to close the issue ASAP.

(0081619) migueldejuana (viewer) 2015-11-09 13:28	Tested and reviewed in 33b1c383618d

Issue History
Date Modified	Username	Field	Change
2015-09-18 08:58	aaroncalero	New Issue
2015-09-18 08:58	aaroncalero	Assigned To	=> aaroncalero
2015-09-18 08:58	aaroncalero	File Added: mobilecore.diff
2015-09-18 08:58	aaroncalero	OBNetwork customer	=> No
2015-09-18 08:58	aaroncalero	Triggers an Emergency Pack	=> No
2015-10-19 18:57	hgbot	Checkin
2015-10-19 18:57	hgbot	Note Added: 0081099
2015-10-19 18:57	hgbot	Status	new => resolved
2015-10-19 18:57	hgbot	Resolution	open => fixed
2015-10-19 18:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/83f39c7d21d00ee7ed562faf2767fea9465135ea [^]
2015-11-05 16:44	dmitry_mezentsev	Note Added: 0081526
2015-11-06 08:32	aaroncalero	Review Assigned To	=> migueldejuana
2015-11-09 13:28	migueldejuana	Note Added: 0081619
2015-11-09 13:28	migueldejuana	Status	resolved => closed