Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0030778 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2015-09-07 11:16 | 2015-09-29 13:33 | |||
Reporter | jorge-garcia | View Status | public | |||||
Assigned To | jorge-garcia | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR15Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 9c0f979ec5e0 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | adrianromero | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | Automated tests | |||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4c6043023025 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0030778: Cash UP Partial crashes | |||||||
Description | Cash UP Partial crashes trying to access the report When selecting the Partial Cash Up menu option, an exception error message is shown and the window does not show any other information. This can be seen in current live environments for PI and STABLE branches, while last published release (RR15Q3) works fine. | |||||||
Steps To Reproduce | 1) Login in the Web POS 2) Go to the Partial CashUP Menu 3) See that a javascript error occurs | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() | |||||||
![]() |
||||||||||||||||||||||
|
![]() |
|
(0080639) hgbot (developer) 2015-09-25 12:47 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 9c0f979ec5e016e06fedcd7113f0c4f6abd0b6b4 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Sep 22 08:43:20 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9c0f979ec5e016e06fedcd7113f0c4f6abd0b6b4 [^] Fixed issue 30778: Cash UP Partial crashes The problem was that the cashup partial tries to start from the step 5 (step CashKeep) instead of the step 6 (step PostPrint&Close). Some functionality has changed and the cashup partial doesn't show the real info in the report and in the ticket. --- M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js --- |
(0080673) adrianromero (viewer) 2015-09-28 18:04 |
This fix overwrites a long function in class CashupPartial called *getCountCashSummary()* This function is the same as the overwritten function on class Cashup with just few changes as it can be seen in the attached file cashup_vs_cashuppartial.diff. this function can be easily refactored reducing the number of lines and complexity of the fix significantly the following way: Instead of overwriting *getCountCashSummary()*, create few functions to represent the differences in class Cashup and overwrite in class CashupPartial these functions. For example a new function *getTotalQtyToKeep()* can be created invoked from *getCountCashSummary()* the following way: In class Cashup: getTotalQtyToKeep: function () { return _.reduce(this.get('paymentList').models, function (total, model) { if (model.get('qtyToKeep')) { var cQtyToKeep = OB.UTIL.currency.toDefaultCurrency(model.get('paymentMethod').currency, model.get('qtyToKeep')); return OB.DEC.add(total, cQtyToKeep); } else { return total; } }, 0); }, In class CashupPartial getTotalQtyToKeep: function () { return OB.DEC.Zero; }, |
(0080702) marvintm (viewer) 2015-09-29 13:33 |
The refactor of the function makes all the sense, but we are very close to the freeze of the current release, so we will leave the current version for now, and we will do the refactor for 16Q1. A related issue has been reported for the refactor: https://issues.openbravo.com/view.php?id=30960 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2015-09-07 11:16 | jorge-garcia | New Issue | |
2015-09-07 11:16 | jorge-garcia | Assigned To | => jorge-garcia |
2015-09-07 11:16 | jorge-garcia | OBNetwork customer | => No |
2015-09-07 11:16 | jorge-garcia | Triggers an Emergency Pack | => No |
2015-09-09 13:56 | jorge-garcia | Relationship added | blocks 0030802 |
2015-09-17 19:04 | Orekaria | Relationship added | has duplicate 0030862 |
2015-09-17 19:06 | Orekaria | File Added: Partial+Cash+Up.png | |
2015-09-17 19:09 | Orekaria | Description Updated | View Revisions |
2015-09-18 15:16 | Orekaria | Regression level | => Automated tests |
2015-09-21 11:58 | Orekaria | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4c6043023025 [^] |
2015-09-25 12:47 | hgbot | Checkin | |
2015-09-25 12:47 | hgbot | Note Added: 0080639 | |
2015-09-25 12:47 | hgbot | Status | new => resolved |
2015-09-25 12:47 | hgbot | Resolution | open => fixed |
2015-09-25 12:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9c0f979ec5e016e06fedcd7113f0c4f6abd0b6b4 [^] |
2015-09-25 13:56 | Orekaria | Review Assigned To | => adrianromero |
2015-09-28 18:04 | adrianromero | Note Added: 0080673 | |
2015-09-28 18:04 | adrianromero | Status | resolved => new |
2015-09-28 18:04 | adrianromero | Resolution | fixed => open |
2015-09-28 18:04 | adrianromero | File Added: cashup_vs_cashuppartial.diff | |
2015-09-29 13:31 | marvintm | Status | new => scheduled |
2015-09-29 13:33 | marvintm | Note Added: 0080702 | |
2015-09-29 13:33 | marvintm | Status | scheduled => resolved |
2015-09-29 13:33 | marvintm | Fixed in Version | => RR15Q4 |
2015-09-29 13:33 | marvintm | Resolution | open => fixed |
2015-09-29 13:33 | marvintm | Status | resolved => closed |
2015-09-29 16:04 | adrianromero | Relationship added | related to 0030960 |
Copyright © 2000 - 2009 MantisBT Group |