Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030740 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 05. Production management | minor | have not tried | 2015-09-02 12:56 | 2016-06-28 16:06 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sanjota | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f8552f6b006e | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030740: pl-function ma_copy_version does not work with non (only-numeric' document numbers) | |||||||
| Description | That function has a datatype bug. It contains the following variable declaration: v_DocumentNo NUMERIC; Assigned like this: SELECT * INTO v_DocumentNo FROM Ad_Sequence_Doc('DocumentNo_MA_ProcessPlan_Version', v_Client_ID, 'Y') ; used for insert into MA_Processplan_Version.documentno Both teh ad_sequence_doc + the documentno field are varchar's are document number definition can and do contain prefixes & suffixes. So that variable declaration in the pl function is looks just wrong. Found using plpgsql_check tool | |||||||
| Steps To Reproduce | Read sourcecode of that pl function or run plpgsql_check tool | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0087154) Sanjota (developer) 2016-06-10 14:11 |
Test Plan: *Changed the datatype of v_documentNo from Numeric to var char(30). * So pl-Function ma_copy_version() will accept NoN also. |
|
(0087976) hgbot (developer) 2016-06-27 12:38 |
Repository: erp/devel/pi Changeset: f8552f6b006ede6e412370d4a5e268f938b60724 Author: Sanjota <sanjota.nelagi <at> promantia.com> Date: Fri Jun 10 17:30:18 2016 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/f8552f6b006ede6e412370d4a5e268f938b60724 [^] Fixes issue 30740: pl-function ma_copy_version does not work with non Changed the datatype of v_documentNo from Numeric to var char(30). Since the function fails incase of insert MA_Processplan_Version statemment --- M src-db/database/model/functions/MA_COPY_VERSION.xml --- |
|
(0087977) hgbot (developer) 2016-06-27 12:38 |
Repository: erp/devel/pi Changeset: f138f3edc459ceef5d595f30625e21b950f9f405 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Mon Jun 27 12:27:02 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f138f3edc459ceef5d595f30625e21b950f9f405 [^] Related to issue 30740: Code review improvements --- M src-db/database/model/functions/MA_COPY_VERSION.xml --- |
|
(0087980) aferraz (manager) 2016-06-27 12:44 |
Code review OK |
|
(0088055) hudsonbot (developer) 2016-06-28 16:06 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/865878a5d292 [^] Maturity status: Test |
|
(0088056) hudsonbot (developer) 2016-06-28 16:06 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/865878a5d292 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-02 12:56 | shuehner | New Issue | |
| 2015-09-02 12:56 | shuehner | Assigned To | => Triage Finance |
| 2015-09-02 12:56 | shuehner | Modules | => Core |
| 2015-09-02 12:56 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-06 18:36 | aferraz | Assigned To | Triage Finance => Sanjota |
| 2016-06-10 14:11 | Sanjota | Note Added: 0087154 | |
| 2016-06-27 12:38 | hgbot | Checkin | |
| 2016-06-27 12:38 | hgbot | Note Added: 0087976 | |
| 2016-06-27 12:38 | hgbot | Status | new => resolved |
| 2016-06-27 12:38 | hgbot | Resolution | open => fixed |
| 2016-06-27 12:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f8552f6b006ede6e412370d4a5e268f938b60724 [^] |
| 2016-06-27 12:38 | hgbot | Checkin | |
| 2016-06-27 12:38 | hgbot | Note Added: 0087977 | |
| 2016-06-27 12:44 | aferraz | Review Assigned To | => aferraz |
| 2016-06-27 12:44 | aferraz | Note Added: 0087980 | |
| 2016-06-27 12:44 | aferraz | Status | resolved => closed |
| 2016-06-27 12:44 | aferraz | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-28 16:06 | hudsonbot | Checkin | |
| 2016-06-28 16:06 | hudsonbot | Note Added: 0088055 | |
| 2016-06-28 16:06 | hudsonbot | Checkin | |
| 2016-06-28 16:06 | hudsonbot | Note Added: 0088056 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |