Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030260 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | major | always | 2015-06-26 13:56 | 2019-01-09 15:11 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | cde83b6e025c | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | vmromanos | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030260: It is not possible to Reactivate a GL Journal with any line defined as "open items" | |||||||
| Description | It is not possible to Reactivate a GL Journal with any line defined as "open items" | |||||||
| Steps To Reproduce | 1. Register GL Journal for F&B US East Coast organization 2. Add Header 3. Add line setting any account and debit amount=100 4. Add line setting any different account and credit amount=100. Check "Open items" section and define Financial Account, Payment Method, GL Item and DAte 5. Process header 6. Try to Reactivate journal and following error will be raised "Error: There is a related Payment for the Journal Line/s with No.: 20". This is OK 7. Navigate to related payment from journal line and run "Reactivate" or "Reactivate and delete lines" 8. Come back to GL Journal and try to Reactivate it again. Same error is received but you should be able to reactivate journal document | |||||||
| Proposed Solution | When "Reactivate" or "Reactivate and delete lines" process is run for a payment in/out created from a gl journal, link between payment and journal should be deleted | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0078709) vmromanos (manager) 2015-07-07 15:42 |
Proposed solution: 1. Always allow to reactivate a GL Journal, even in the case it contains lines linked to a payment. Only in that scenario show a warning message informing the user about that situation. The message could be the following: "There is a related process Payment for the Journal Line/s with No.: %s. If you want to modify the Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date of any of these lines, you must first reactivate and delete its related payments." 2. Add an onDelete="setnull" constraint to the GL_JOURNALLINE.FIN_PAYMENT_ID column. 3. Add an error and avoid the user to modify the Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date when the line is associated to a fin_payment_id (you can use a callout or an EventEntityObserver). Error message: "If you want to modify the Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date of this line, you must first reactivate and delete its related payment." |
|
(0078747) AtulOpenbravo (developer) 2015-07-10 08:04 |
Test Plan 1. Register GL Journal for F&B US East Coast organization. 2. Add Header. 3. Add line setting any account and debit amount=100. 4. Add line setting any different account and credit amount=100. Check "Open items" section and define Financial Account, Payment Method, GL Item and payment date. 5. Process header. 6. Try to Reactivate journal. Check that journal entry is reactivated with following warning message "Warning: There is a related Payment for the Journal Line/s with No.: 20. If you want to modify the Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date of any of these lines, you must first reactivate and delete its related payments." 7. Go to line 20 and try to edit Credit amount or Debit Amount or Open Item flag. 8. Error message will be shown as "If you want to modify the Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date of any of these lines, you must first reactivate and delete its related payments." 9. Go to related payments. Using Reactivate and delete lines delete the lines and also the payment. 10. Navigate back to previous Journal Line No 2. Check that related payment in the line is blank. User can edit Credit/Debit/Financial Account/Payment Method/GL Item/Payment Date of the line. |
|
(0078748) AtulOpenbravo (developer) 2015-07-10 08:08 |
Alternate Test Plan Complete and reactivate a simple journal entry 1. Register GL Journal for F&B US East Coast organization. 2. Add Header. 3. Add line setting any account and debit amount=100. 4. Add line setting any different account and credit amount=100. 5. Complete the journal entry. Check that it is successful. 6. Post the journal entry. Check that it is successful. 7. Unpost the journal entry. Check that it is successful. 8. Reactivate the journal entry. Check that it is successful. |
|
(0078749) hgbot (developer) 2015-07-10 11:58 edited on: 2015-07-16 12:00 |
Repository: erp/devel/pi Changeset: cde83b6e025c Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Fri Jul 10 11:24:17 2015 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/cde83b6e025c [^] Fixes Issue 30260:It is not possible to Reactivate a GL Journal with any line defined as "open items" Reactivating of GL Journal is allowed when its line/s have related payment with a warning message. If user tries to change credit / debit or open item flag of line having related payment event handler takes care to avoid user to update line. Warning/Error message guides user to reactivate and delete related payment inorder to update credit/debit, financial account, payment method, glitem, payment date of the line. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournal.java M src-db/database/sourcedata/AD_MESSAGE.xml A src/org/openbravo/event/GLJournalLineEventHandler.java --- |
|
(0078750) hgbot (developer) 2015-07-10 11:58 edited on: 2015-07-16 12:00 |
Repository: erp/devel/pi Changeset: 45f294a02a37 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Fri Jul 10 11:56:32 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/45f294a02a37 [^] Related to issue 30260: Code review improvements FIN_AddPaymentFromJournal.java: 1. Removed unused variables 2. Warning message improved to inform the user that the reactivation process was succesfull GLJournalLineEventHandler.java: 1. Removed TODO comment 2. Moved check stuff to a separate method 3. Cast objects to compare to BigDecimal and Boolean and use the right comparator methods --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournal.java M src/org/openbravo/event/GLJournalLineEventHandler.java --- |
|
(0078751) vmromanos (manager) 2015-07-10 11:59 |
Code review + testing OK |
|
(0079487) hudsonbot (developer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
|
(0079488) hudsonbot (developer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-06-26 13:56 | maite | New Issue | |
| 2015-06-26 13:56 | maite | Assigned To | => Triage Finance |
| 2015-06-26 13:56 | maite | Modules | => Core |
| 2015-06-26 13:56 | maite | Resolution time | => 1438380000 |
| 2015-06-26 13:56 | maite | Triggers an Emergency Pack | => No |
| 2015-06-26 13:57 | maite | Issue Monitored: networkb | |
| 2015-07-02 11:04 | AtulOpenbravo | Assigned To | Triage Finance => AtulOpenbravo |
| 2015-07-02 11:04 | AtulOpenbravo | Status | new => scheduled |
| 2015-07-07 15:42 | vmromanos | Note Added: 0078709 | |
| 2015-07-10 08:04 | AtulOpenbravo | Note Added: 0078747 | |
| 2015-07-10 08:08 | AtulOpenbravo | Note Added: 0078748 | |
| 2015-07-10 11:58 | hgbot | Checkin | |
| 2015-07-10 11:58 | hgbot | Note Added: 0078749 | |
| 2015-07-10 11:58 | hgbot | Status | scheduled => resolved |
| 2015-07-10 11:58 | hgbot | Resolution | open => fixed |
| 2015-07-10 11:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/766e0ed013ed798d723865abd6b02ba079afbdb4 [^] |
| 2015-07-10 11:58 | hgbot | Checkin | |
| 2015-07-10 11:58 | hgbot | Note Added: 0078750 | |
| 2015-07-10 11:59 | vmromanos | Review Assigned To | => vmromanos |
| 2015-07-10 11:59 | vmromanos | Note Added: 0078751 | |
| 2015-07-10 11:59 | vmromanos | Status | resolved => closed |
| 2015-07-16 11:59 | gorka_gil | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/766e0ed013ed798d723865abd6b02ba079afbdb4 [^] => http://code.openbravo.com/erp/devel/pi/rev/cde83b6e025c [^] |
| 2015-07-16 12:00 | gorka_gil | Note Edited: 0078749 | View Revisions |
| 2015-07-16 12:00 | gorka_gil | Note Edited: 0078750 | View Revisions |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079487 | |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079488 | |
| 2019-01-09 15:11 | ngarcia | Relationship added | related to 0039895 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |