Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030093 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Service Contract Management | major | always | 2015-06-04 13:36 | 2015-06-04 17:34 | |||
| Reporter | ngarcia | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 18e03aff655b | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ngarcia | |||||||
| Regression introduced in release | ||||||||
| Summary | 0030093: Contract Billing Background finishes with Error after 3.0PR15Q1 | |||||||
| Description | Contract Billing Background finishes with Error after 3.0PR15Q1 | |||||||
| Steps To Reproduce | As group admin role: Apply the dataset at * level Create a Contract Type set as Service Contract Create a Contract Invoice Schedule Create a Contract, configure an Invoice Plan Master to it and process it selecting the option of Generating the Invoice Plan Schedule the Contract Billing Background process and check it finishes with Error The following error is shown in the log: ERROR org.openbravo.service.db.DalBaseProcess - The process org.openbravo.contract.services.process.billing.BackgroundInvoiceProcessHandler has thrown an exception. java.lang.NullPointerException at org.openbravo.client.kernel.RequestContext.getSession(RequestContext.java:145) | |||||||
| Proposed Solution | The code that uses RequestContext.get().getSession() should be replaced in StandardContractInvoiceProcess.java | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0078082) vmromanos (manager) 2015-06-04 16:06 |
Test plan: In a 3.0PR15Q1 instance or higher, follow steps to reproduce. Verify no error is raised by the background process |
|
(0078083) hgbot (developer) 2015-06-04 16:10 |
Repository: erp/pmods/org.openbravo.contract.services Changeset: c5cfc1c84a05480533f48febc80399db55e0047d Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Thu Jun 04 15:38:48 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/c5cfc1c84a05480533f48febc80399db55e0047d [^] Fixed bug 30093: Contract Billing Background finishes with Error after 3.0PR15Q1 In case the Billing process is launched from a background process, the HttpSession is null creating a NPE starting from 3.0PR15Q1. The solution is to catch this exception and force to use a dummy sessionId, which is not used when launched from a background process. This change has no impact when executed before 3.0PR15Q1 --- M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java --- |
|
(0078084) hgbot (developer) 2015-06-04 16:10 |
Repository: erp/pmods/org.openbravo.contract.services Changeset: f39c5bf7bfa27b99af23d9e14fc55b0c477be9c3 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Thu Jun 04 15:38:48 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/f39c5bf7bfa27b99af23d9e14fc55b0c477be9c3 [^] Fixed bug 30093: Contract Billing Background finishes with Error after 3.0PR15Q1 In case the Billing process is launched from a background process, the HttpSession is null creating a NPE starting from 3.0PR15Q1. The solution is to catch this exception and force to use a dummy sessionId, which is not used when launched from a background process. This change has no impact when executed before 3.0PR15Q1 --- M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java --- |
|
(0078085) hgbot (developer) 2015-06-04 16:10 |
Repository: erp/pmods/org.openbravo.contract.services Changeset: 18e03aff655b92a704a98a3d9ff65181820f47ce Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Thu Jun 04 15:38:48 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/18e03aff655b92a704a98a3d9ff65181820f47ce [^] Fixed bug 30093: Contract Billing Background finishes with Error after 3.0PR15Q1 In case the Billing process is launched from a background process, the HttpSession is null creating a NPE starting from 3.0PR15Q1. The solution is to catch this exception and force to use a dummy sessionId, which is not used when launched from a background process. This change has no impact when executed before 3.0PR15Q1 --- M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-06-04 13:36 | ngarcia | New Issue | |
| 2015-06-04 13:36 | ngarcia | Assigned To | => Triage Finance |
| 2015-06-04 13:37 | ngarcia | Relationship added | caused by 0027244 |
| 2015-06-04 13:37 | ngarcia | Issue Monitored: networkb | |
| 2015-06-04 13:38 | ngarcia | Resolution time | => 1436911200 |
| 2015-06-04 13:43 | vmromanos | Status | new => scheduled |
| 2015-06-04 13:43 | vmromanos | Assigned To | Triage Finance => vmromanos |
| 2015-06-04 16:06 | vmromanos | Note Added: 0078082 | |
| 2015-06-04 16:10 | hgbot | Checkin | |
| 2015-06-04 16:10 | hgbot | Note Added: 0078083 | |
| 2015-06-04 16:10 | hgbot | Status | scheduled => resolved |
| 2015-06-04 16:10 | hgbot | Resolution | open => fixed |
| 2015-06-04 16:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/c5cfc1c84a05480533f48febc80399db55e0047d [^] |
| 2015-06-04 16:10 | hgbot | Checkin | |
| 2015-06-04 16:10 | hgbot | Note Added: 0078084 | |
| 2015-06-04 16:10 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/c5cfc1c84a05480533f48febc80399db55e0047d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/f39c5bf7bfa27b99af23d9e14fc55b0c477be9c3 [^] |
| 2015-06-04 16:10 | hgbot | Checkin | |
| 2015-06-04 16:10 | hgbot | Note Added: 0078085 | |
| 2015-06-04 16:10 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/f39c5bf7bfa27b99af23d9e14fc55b0c477be9c3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/18e03aff655b92a704a98a3d9ff65181820f47ce [^] |
| 2015-06-04 17:34 | ngarcia | Review Assigned To | => ngarcia |
| 2015-06-04 17:34 | ngarcia | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |