0030075: Return tickets should not be able to contain positive lines

diff --git a/src-db/database/sourcedata/AD_MESSAGE.xml b/src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml
@@ -4923,6 +4923,18 @@
 <!--D2731465445E4EAEBFE44C5955279BEB-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--D2731465445E4EAEBFE44C5955279BEB--></AD_MESSAGE>
 
+<!--D2B84F6EECCC407AB521128A71B42955--><AD_MESSAGE>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <AD_MESSAGE_ID><![CDATA[D2B84F6EECCC407AB521128A71B42955]]></AD_MESSAGE_ID>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <VALUE><![CDATA[OBPOS_MsgCannotAddPostiveToReturn]]></VALUE>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <MSGTEXT><![CDATA[Cannot add a positive line to a return ticket]]></MSGTEXT>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--D2B84F6EECCC407AB521128A71B42955-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--D2B84F6EECCC407AB521128A71B42955--></AD_MESSAGE>
+
 <!--D387B80B40A945B89B84255FFAD2076A--><AD_MESSAGE>
 <!--D387B80B40A945B89B84255FFAD2076A-->  <AD_MESSAGE_ID><![CDATA[D387B80B40A945B89B84255FFAD2076A]]></AD_MESSAGE_ID>
 <!--D387B80B40A945B89B84255FFAD2076A-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -716,6 +716,10 @@
           OB.UTIL.showError(OB.I18N.getLabel('OBPOS_MsgCannotAddNegative'));
           return;
         }
+        if (qty > 0 && oldqty < 0 && this.get('orderType') === 1) {
+          OB.UTIL.showError(OB.I18N.getLabel('OBPOS_MsgCannotAddPostiveToReturn'));
+          return;
+        }
         if (line.get('product').get('groupProduct') === false) {
           this.addProduct(line.get('product'));
           return true;

diff --git a/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java b/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
--- a/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
+++ b/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
@@ -205,6 +205,7 @@
   LABEL_MULTIORDERS_SEARCHRESULTS_ROW1_TOPLINE("multiorderslistitemprinter_row1_topLine"), //
   LABEL_MULTIORDERS_SEARCHRESULTS_ROW2_TOPLINE("multiorderslistitemprinter_row2_topLine"), //
   BUTTON_SEARCH_EXECUTE("searchProductCharacteristicHeader_smallButton2", EnyoKind.BUTTON), //
+  BUTTON_PRODUCTSEARCH_AVALANCHETRANSCEIVER("Avalanche transceiver", EnyoKind.SEARCHPRODUCT), //
 
   // Buttons
   MENU_CONTAINER("mainMenu_menuHolder"), //
diff --git a/src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java b/src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
--- a/src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
+++ b/src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
@@ -96,8 +96,12 @@
 
     // IMPORTANT: you must have a very good reason to add an entry to this list
     javascriptAllowedErrors = new ArrayList<String>();
-    // legal allowed errors:
-    // illegal allowed errors. these errors have to be fixed:
+    // Legal allowed errors:
+    // Issue 30075: trying to create a positive line in a return ticket will log an OBError (see
+    // order.js file, inside model folder)
+    javascriptAllowedErrors.add("Cannot add a positive line to a return ticket");
+
+    // Illegal allowed errors. these errors have to be fixed:
     // these errors are happening because synchronization issues
     javascriptAllowedErrors
         .add("servicePOST error: 401, source: org.openbravo.mobile.core.utils.LogClientLoader");
@@ -117,6 +121,7 @@
     // IMPORTANT: you must have a very good reason to add an entry to this list
     testsAllowedToHaveLogclientErrors = new ArrayList<String>();
     testsAllowedToHaveLogclientErrors.add("I27554_SwitchToERPAndBackToWebPOSDifferentAccount");
+    testsAllowedToHaveLogclientErrors.add("I30075_NoPositiveLinesInReturnTickets");
     return testsAllowedToHaveLogclientErrors;
   }
 
diff --git a/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I30075_NoPositiveLinesInReturnTickets.java b/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I30075_NoPositiveLinesInReturnTickets.java
new file mode 100644
--- /dev/null
+++ b/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I30075_NoPositiveLinesInReturnTickets.java
@@ -0,0 +1,62 @@
+/*
+ *************************************************************************
+ * The contents of this file are subject to the Openbravo  Public  License
+ * Version  1.0  (the  "License"),  being   the  Mozilla   Public  License
+ * Version 1.1  with a permitted attribution clause; you may not  use this
+ * file except in compliance with the License. You  may  obtain  a copy of
+ * the License at http://www.openbravo.com/legal/license.html
+ * Software distributed under the License  is  distributed  on  an "AS IS"
+ * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+ * License for the specific  language  governing  rights  and  limitations
+ * under the License.
+ * The Original Code is Openbravo ERP.
+ * The Initial Developer of the Original Code is Openbravo S.L.U.
+ * All portions are Copyright (C) 2015 Openbravo S.L.U.
+ * All Rights Reserved.
+ * Contributor(s):  ______________________________________.
+ ************************************************************************
+ *
+ * @author ACA
+ *
+ */
+
+package org.openbravo.test.mobile.retail.pack.selenium.tests.returns;
+
+import org.junit.Test;
+import org.openbravo.test.mobile.common.TestAnnotations;
+import org.openbravo.test.mobile.common.selenium.javascript.TestId;
+import org.openbravo.test.mobile.common.selenium.terminals.WebPOSTerminalHelper;
+
+/**
+ * This test verifies that it is not possible to create a return ticket with lines with quantity
+ * greater than 0
+ * 
+ * 
+ */
+public class I30075_NoPositiveLinesInReturnTickets extends WebPOSTerminalHelper {
+
+  @Test
+  @TestAnnotations(waitFixOf = 30075)
+  public void test() {
+    tap(TestId.BUTTON_MENU);
+    tap(TestId.BUTTON_MENU_RETURNTHISRECEIPT);
+    verify(TestId.LABEL_RECEIPT_TYPE, "To be Returned");
+    tap(TestId.BUTTON_SEARCH);
+    write(TestId.FIELD_SEARCH_TEXT, "avalanche");
+    tap(TestId.BUTTON_SEARCH_EXECUTE);
+    verify(TestId.BUTTON_PRODUCTSEARCH_AVALANCHETRANSCEIVER, "Avalanche transceiver");
+    tap(TestId.BUTTON_SEARCHPRODUCT_FIRSTROW);
+    verify(TestId.LABEL_TOTALTOPAY, "-150.50");
+    verify(TestId.LABEL_RECEIPT_ROW1_QTY, "-1");
+
+    // Trying to set the quantity greater than 0
+    tap(TestId.BUTTON_KEYPAD_2);
+    tap(TestId.BUTTON_KEYPAD_MINUS);
+
+    // Verifying that the ticket remains unchanged
+    verify(TestId.LABEL_TOTALTOPAY, "-150.50");
+    verify(TestId.LABEL_RECEIPT_ROW1_QTY, "-1");
+    tap(TestId.BUTTON_DELETERECEIPT);
+    tap(TestId.BUTTON_DELETERECEIPT_CONFIRM);
+  }
+}