0029966: Warehouse Picking List cannot be canceled if it has been shipped on another different shipment

Description

Warehouse Picking List cannot be canceled if it has been shipped on another different shipment.
Error is displayed:
"Error
Cannot delete released reservation"

This happens because the cancel process does not take into account if other shipments that the one created in the picking list have released the reservation.

Steps To Reproduce

Create a Sales order with a line of qty 10 for a product with stock.
Click on Generate Picking List:
* Picking List type: "Direct Picking List to Customer"
* Grouping Criteria: "Not group"
Click OK.
Go to Goods Shipment window.
Create a Header for the same Business Partner as Sales Order previously created.
Click on "Create Lines From"
* Select previous sales order.
* Select the line.
Click OK.
In Lines edit the created line and set movement qty 5.
Complete the shipment.
Go to Warehouse Picking List window.
Select the previously created Picking List.
Cancel it.
The following error is raised:
"Error
Cannot delete released reservation"

Tags

No tags attached.

Attached Files

errorReleased.diff [^] (792 bytes) 2015-05-21 17:52 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/warehouse/pickinglist/PickingListActionHandler.java b/src/org/openbravo/warehouse/pickinglist/PickingListActionHandler.java
--- a/src/org/openbravo/warehouse/pickinglist/PickingListActionHandler.java
+++ b/src/org/openbravo/warehouse/pickinglist/PickingListActionHandler.java
@@ -228,6 +228,9 @@
     }
     if (resStock != null) {
       resStock.setQuantity(resStock.getQuantity().subtract(iol.getMovementQuantity()));
+      if (resStock.getQuantity().compareTo(resStock.getReleased()) < 0) {
+        resStock.setQuantity(resStock.getReleased());
+      }
       if (resStock.getQuantity().equals(BigDecimal.ZERO)) {
         res.getMaterialMgmtReservationStockList().remove(resStock);
         // Flush to persist changes in database and execute triggers.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0035542		closed	aferraz	Wrong stock reservation when deleting lines or canceling partially shipped orders' picking lists
related to	defect	0035600		new	Triage Omni WMS	An exception is thrown in Eclipse and the popup to Delete line in the PL is not opened

Notes
(0077635) jorge-garcia (reporter) 2015-05-21 19:13	Test Plan Create a Sales order with a line of qty 10 for a product with stock. Click on Generate Picking List: * Picking List type: "Direct Picking List to Customer" * Grouping Criteria: "Not group" Click OK. Go to Goods Shipment window. Create a Header for the same Business Partner as Sales Order previously created. Click on "Create Lines From" * Select previous sales order. * Select the line. Click OK. In Lines edit the created line and set movement qty 5. Complete the shipment. Go to Warehouse Picking List window. Select the previously created Picking List. Cancel it. The process is done correctly

(0077647) umartirena (reporter) 2015-05-22 08:40	Fixed in the following commit: https://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e06ba2b7c571 [^]

(0077648) umartirena (reporter) 2015-05-22 08:41	Code Review + Testing OK

Issue History
Date Modified	Username	Field	Change
2015-05-21 17:52	umartirena	New Issue
2015-05-21 17:52	umartirena	Assigned To	=> Triage Finance
2015-05-21 17:52	umartirena	File Added: errorReleased.diff
2015-05-21 19:13	jorge-garcia	Note Added: 0077635
2015-05-21 19:13	jorge-garcia	Status	new => scheduled
2015-05-21 19:13	jorge-garcia	Assigned To	Triage Finance => jorge-garcia
2015-05-22 08:40	umartirena	Note Added: 0077647
2015-05-22 08:40	umartirena	Status	scheduled => resolved
2015-05-22 08:40	umartirena	Resolution	open => fixed
2015-05-22 08:41	umartirena	Fixed in SCM revision	=> https://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e06ba2b7c571 [^]
2015-05-22 08:41	umartirena	Review Assigned To	=> umartirena
2015-05-22 08:41	umartirena	Note Added: 0077648
2015-05-22 08:41	umartirena	Status	resolved => closed
2017-03-17 14:37	aferraz	Relationship added	related to 0035542
2017-03-22 16:44	markmm82	Relationship added	related to 0035600