0029921: ImportEntryProcessor.LocalHttpRequest compilation errors with Tomcat 7

Description

When working in Eclipse with Tomcat 7 as server, ImportEntryProcessor.LocalHttpRequest class has compilation errors because it does not implement all the methods the new javax.servlet.http.HttpServletRequest version declares.

Steps To Reproduce

Prepare an Eclipse workspace with a recent pi using Tomcat 7 as server
Compile and see the following errors:
Description Resource Path Location Type
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method HttpServletRequest.authenticate(HttpServletResponse) ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method HttpServletRequest.getPart(String) ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method HttpServletRequest.getParts() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method HttpServletRequest.login(String, String) ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method HttpServletRequest.logout() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.getAsyncContext() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.getDispatcherType() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.getServletContext() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.isAsyncStarted() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.isAsyncSupported() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.startAsync() ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem
The type ImportEntryProcessor.LocalHttpRequest must implement the inherited abstract method ServletRequest.startAsync(ServletRequest, ServletResponse) ImportEntryProcessor.java /openbravo/src/org/openbravo/service/importprocess line 480 Java Problem

Proposed Solution

Check whether it is required to use wrap HttpRequest at all, if not implement it in a different way. In case it is required, try to extend RequestContext.HttpServletRequestWrapper or javax.servlet.http.HttpServletRequestWrapper

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0027244		closed	alostale	Openbravo ERP	Tomcat 7 is not supported
caused by	feature request	0029766	RR15Q3	closed	mtaal	Retail Modules	Retail Operations Buffer: store all transactions in operations table before processing

Notes
(0077770) hgbot (developer) 2015-05-26 21:23	Repository: erp/devel/pi Changeset: a4b42603cc8941137d0ff3e36092444fbdd9ce1e Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue May 26 21:22:49 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a4b42603cc8941137d0ff3e36092444fbdd9ce1e [^] Fixes issue 29921: ImportEntryProcessor.LocalHttpRequest compilation errors with Tomcat 7 Removed local declared subclass declaration of HttpRequest, make use of VariablesSecureApp now working without session --- M src/org/openbravo/service/importprocess/ImportEntryProcessor.java ---

(0077812) hudsonbot (developer) 2015-05-27 15:38	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9cdfae4d18ae [^] Maturity status: Test

(0077942) alostale (manager) 2015-06-01 13:18	code reviewed tested compiling with Tomcat 7 libraries without error

Issue History
Date Modified	Username	Field	Change
2015-05-19 08:23	alostale	New Issue
2015-05-19 08:23	alostale	Assigned To	=> mtaal
2015-05-19 08:23	alostale	Modules	=> Core
2015-05-19 08:23	alostale	Regression level	=> Coding ( Testing )
2015-05-19 08:23	alostale	Regression date	=> 2015-05-11
2015-05-19 08:23	alostale	Regression introduced in release	=> pi
2015-05-19 08:23	alostale	Regression introduced by commit	=> https://code.openbravo.com/erp/devel/pi/rev/7f5dfe606b09 [^]
2015-05-19 08:23	alostale	Triggers an Emergency Pack	=> No
2015-05-19 08:23	alostale	Relationship added	caused by 0029766
2015-05-19 09:09	alostale	Relationship added	related to 0027244
2015-05-25 19:32	mtaal	Review Assigned To	=> alostale
2015-05-26 21:23	hgbot	Checkin
2015-05-26 21:23	hgbot	Note Added: 0077770
2015-05-26 21:23	hgbot	Status	new => resolved
2015-05-26 21:23	hgbot	Resolution	open => fixed
2015-05-26 21:23	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/a4b42603cc8941137d0ff3e36092444fbdd9ce1e [^]
2015-05-27 15:38	hudsonbot	Checkin
2015-05-27 15:38	hudsonbot	Note Added: 0077812
2015-06-01 13:18	alostale	Note Added: 0077942
2015-06-01 13:18	alostale	Status	resolved => closed
2015-06-01 13:18	alostale	Fixed in Version	=> 3.0PR15Q3