Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029823
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2015-05-08 12:312015-05-12 17:40
ReporterpsanjuanView Statuspublic 
Assigned Tovmromanos 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q3
StatusclosedFix in branchFixed in SCM revision3e8342709c19
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.6
OS VersionUbuntu 8.04.1Database version11.1.0.6.0Ant version1.7.0
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029823: Open/Close Period Control window should only shown the calendars associated to an Organization

DescriptionOpen/Close Period Control window should only shown the calendars associated to an Organization
Steps To ReproduceGo to Fiscal Calendar window
Create a new one called "Calendario España Test" for F&B España org (this organization already has a calendar assined in the "Organization" window).
Go to Year and create 2014 year.
Go to periods tab and create them (Periods) by using the process button "Create Periods".
Process completes successfully.

Go to Open/Close Period Control window and realize that the new calendar created is shown there. Select it and select all those periods. Try to open them.

Realize that those periods cannot be opened, realize that those periods do not have any document assigned and its status will always remains as "Mixed".

Above scenario is confusing.

Proposed SolutionOpen/Close period control window should only show calendars assigned to Organizations set as ready, because once an organization is set as ready, calendar option turns to read-only, it can not be changed.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00298273.0PR15Q2.1 closedvmromanos Open/Close Period Control window should only shown the calendars associated to an Organization 
depends on backport 00298283.0PR15Q1.4 closedvmromanos Open/Close Period Control window should only shown the calendars associated to an Organization 
related to defect 0028787 closedvmromanos Impossible to create several calendars for the same organization 

-  Notes
(0077240)
vmromanos (manager)
2015-05-08 14:17
edited on: 2015-05-08 14:32

Test plan:
Login into F&B Client
Go to Fiscal Calendar window.
Create a new record. Name = test. Organization = * (organization is only important if you haven't applied yet the fix for 0028787)
Save it.
Go to Year tab. Create Year 2015
Run Create periods process. Verify periods have been created
Go to Open/Close Period Control window.
Clear the filter
Verify "test" calendar previously created is NOT shown in the calendar's column filter

(0077273)
psanjuan (manager)
2015-05-11 11:58
edited on: 2015-05-11 11:59

Verified.

Scenario above verified for an existing organization which already has assigned a calendar and a new one is created.

Also tested the creation of a new organization and two calendars but only one assigned to the organization before the organization is set as ready.
Once set as ready, Open/Close fiscal calendar control window only gets the calendar assigned to the new organization.

(0077287)
hgbot (developer)
2015-05-11 16:04

Repository: erp/devel/pi
Changeset: 1414a1029667b603e097e25ba4f80e1d4de185d7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 08 14:02:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^]

Fixed bug 29823: Open/Close Period Control shows calendars associated to organizations

The Open/Close Period Control window was showing all the periods available at the C_Period table.
The target of this window is to open/close periods in fiscal calendars, so it should only show periods belonging to a fiscal calendar linked to an organization set as ready.

The fix has 2 parts:
1. Added a hql where clause to include only periods belonging to a fiscal calendar linked to an organization set as ready.
2. The hql filter clause was wrong because it was filtering by the c_period.ad_org_id. Instead it should be filtering by the organization linked to the calendar's periods

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0077299)
Sandrahuguet (developer)
2015-05-11 17:15

Code review + testing OK
(0077346)
hudsonbot (developer)
2015-05-12 17:40

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d9fee60cdbd [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-05-08 12:31 psanjuan New Issue
2015-05-08 12:31 psanjuan Assigned To => Triage Finance
2015-05-08 12:31 psanjuan Modules => Core
2015-05-08 12:31 psanjuan Triggers an Emergency Pack => No
2015-05-08 12:33 psanjuan Proposed Solution updated
2015-05-08 12:34 psanjuan Relationship added caused by 0028787
2015-05-08 12:35 psanjuan Assigned To Triage Finance => vmromanos
2015-05-08 12:49 vmromanos Status new => scheduled
2015-05-08 14:17 vmromanos Note Added: 0077240
2015-05-08 14:23 psanjuan Relationship deleted caused by 0028787
2015-05-08 14:24 psanjuan Relationship added related to 0028787
2015-05-08 14:32 vmromanos Note Edited: 0077240 View Revisions
2015-05-11 11:58 psanjuan Note Added: 0077273
2015-05-11 11:59 psanjuan Note Edited: 0077273 View Revisions
2015-05-11 16:04 hgbot Checkin
2015-05-11 16:04 hgbot Note Added: 0077287
2015-05-11 16:04 hgbot Status scheduled => resolved
2015-05-11 16:04 hgbot Resolution open => fixed
2015-05-11 16:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^]
2015-05-11 16:34 hgbot Checkin
2015-05-11 16:34 hgbot Note Added: 0077290
2015-05-11 16:34 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/3e8342709c1978c13af4f8d5bb628535976aadea [^]
2015-05-11 17:09 Sandrahuguet Note Deleted: 0077290
2015-05-11 17:14 Sandrahuguet Fixed in Version => 3.0PR15Q3
2015-05-11 17:15 Sandrahuguet Review Assigned To => Sandrahuguet
2015-05-11 17:15 Sandrahuguet Note Added: 0077299
2015-05-11 17:15 Sandrahuguet Status resolved => closed
2015-05-12 17:40 hudsonbot Checkin
2015-05-12 17:40 hudsonbot Note Added: 0077346


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker