Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029823Openbravo ERP09. Financial managementpublic2015-05-08 12:312015-05-12 17:40
Reporterpsanjuan 
Assigned Tovmromanos 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029823: Open/Close Period Control window should only shown the calendars associated to an Organization
DescriptionOpen/Close Period Control window should only shown the calendars associated to an Organization
Steps To ReproduceGo to Fiscal Calendar window
Create a new one called "Calendario España Test" for F&B España org (this organization already has a calendar assined in the "Organization" window).
Go to Year and create 2014 year.
Go to periods tab and create them (Periods) by using the process button "Create Periods".
Process completes successfully.

Go to Open/Close Period Control window and realize that the new calendar created is shown there. Select it and select all those periods. Try to open them.

Realize that those periods cannot be opened, realize that those periods do not have any document assigned and its status will always remains as "Mixed".

Above scenario is confusing.

Proposed SolutionOpen/Close period control window should only show calendars assigned to Organizations set as ready, because once an organization is set as ready, calendar option turns to read-only, it can not be changed.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00298273.0PR15Q2.1 closed vmromanos Open/Close Period Control window should only shown the calendars associated to an Organization 
depends on backport 00298283.0PR15Q1.4 closed vmromanos Open/Close Period Control window should only shown the calendars associated to an Organization 
related to defect 0028787 closed vmromanos Impossible to create several calendars for the same organization 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-08 12:31psanjuanNew Issue
2015-05-08 12:31psanjuanAssigned To => Triage Finance
2015-05-08 12:31psanjuanModules => Core
2015-05-08 12:31psanjuanTriggers an Emergency Pack => No
2015-05-08 12:33psanjuanProposed Solution updated
2015-05-08 12:34psanjuanRelationship addedcaused by 0028787
2015-05-08 12:35psanjuanAssigned ToTriage Finance => vmromanos
2015-05-08 12:49vmromanosStatusnew => scheduled
2015-05-08 14:17vmromanosNote Added: 0077240
2015-05-08 14:23psanjuanRelationship deletedcaused by 0028787
2015-05-08 14:24psanjuanRelationship addedrelated to 0028787
2015-05-08 14:32vmromanosNote Edited: 0077240bug_revision_view_page.php?bugnote_id=0077240#r8492
2015-05-11 11:58psanjuanNote Added: 0077273
2015-05-11 11:59psanjuanNote Edited: 0077273bug_revision_view_page.php?bugnote_id=0077273#r8502
2015-05-11 16:04hgbotCheckin
2015-05-11 16:04hgbotNote Added: 0077287
2015-05-11 16:04hgbotStatusscheduled => resolved
2015-05-11 16:04hgbotResolutionopen => fixed
2015-05-11 16:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^]
2015-05-11 16:34hgbotCheckin
2015-05-11 16:34hgbotNote Added: 0077290
2015-05-11 16:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/3e8342709c1978c13af4f8d5bb628535976aadea [^]
2015-05-11 17:09SandrahuguetNote Deleted: 0077290
2015-05-11 17:14SandrahuguetFixed in Version => 3.0PR15Q3
2015-05-11 17:15SandrahuguetReview Assigned To => Sandrahuguet
2015-05-11 17:15SandrahuguetNote Added: 0077299
2015-05-11 17:15SandrahuguetStatusresolved => closed
2015-05-12 17:40hudsonbotCheckin
2015-05-12 17:40hudsonbotNote Added: 0077346

Notes
(0077240)
vmromanos   
2015-05-08 14:17   
(edited on: 2015-05-08 14:32)
Test plan:
Login into F&B Client
Go to Fiscal Calendar window.
Create a new record. Name = test. Organization = * (organization is only important if you haven't applied yet the fix for 0028787)
Save it.
Go to Year tab. Create Year 2015
Run Create periods process. Verify periods have been created
Go to Open/Close Period Control window.
Clear the filter
Verify "test" calendar previously created is NOT shown in the calendar's column filter
(0077273)
psanjuan   
2015-05-11 11:58   
(edited on: 2015-05-11 11:59)
Verified.

Scenario above verified for an existing organization which already has assigned a calendar and a new one is created.

Also tested the creation of a new organization and two calendars but only one assigned to the organization before the organization is set as ready.
Once set as ready, Open/Close fiscal calendar control window only gets the calendar assigned to the new organization.
(0077287)
hgbot   
2015-05-11 16:04   
Repository: erp/devel/pi
Changeset: 1414a1029667b603e097e25ba4f80e1d4de185d7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 08 14:02:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1414a1029667b603e097e25ba4f80e1d4de185d7 [^]

Fixed bug 29823: Open/Close Period Control shows calendars associated to organizations

The Open/Close Period Control window was showing all the periods available at the C_Period table.
The target of this window is to open/close periods in fiscal calendars, so it should only show periods belonging to a fiscal calendar linked to an organization set as ready.

The fix has 2 parts:
1. Added a hql where clause to include only periods belonging to a fiscal calendar linked to an organization set as ready.
2. The hql filter clause was wrong because it was filtering by the c_period.ad_org_id. Instead it should be filtering by the organization linked to the calendar's periods

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0077299)
Sandrahuguet   
2015-05-11 17:15   
Code review + testing OK
(0077346)
hudsonbot   
2015-05-12 17:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d9fee60cdbd [^]
Maturity status: Test