Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029747 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Return Receipt | minor | always | 2015-04-30 10:27 | 2015-06-29 16:22 | |||
| Reporter | lorenzofidalgo | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | RR15Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 87b76c61d1a0 | ||||
| Projection | none | ETA | none | Target Version | RR15Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | malsasua | |||||||
| Regression level | Packaging and release | |||||||
| Regression date | 2015-01-13 | |||||||
| Regression introduced in release | main | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26cdf0109b187e9d1a968e80846bde61c45f2fb8 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029747: Following certain steps returning a receipt induces wrong change amount message | |||||||
| Description | Creating a return receipt and meanwhile to complete a receipt, induces a wrong return receipt change amount message. | |||||||
| Steps To Reproduce | 1-Login POS as vallblanca//openbravo. 2-In dropdown menu click "Return this receipt". 3-Add 1 x Adhesive body warmers. 4-Click '*' to create a new receipt. 5-Add 5 x Alpine Alpine skiing backpack 27 L 6-Click amount and complete this receipt. 7-Now, Return Receipt appears. Click Total Amount button and check change amount message that is shown is wrong. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  WrongChange.png [^] (139,834 bytes) 2015-04-30 10:27
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0076942) hgbot (developer) 2015-05-04 13:47 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 37235e8d729ae054946c4355d7cc74bf76168b11 Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com> Date: Mon May 04 13:47:04 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37235e8d729ae054946c4355d7cc74bf76168b11 [^] fixed issue 29747: removed execution of applypromotions when the receipt is cloning and the receipt is saved when calculate gross is executed when the receipt is cloning, the apply promotions is disabled, because it is generating multiples calls to cloneReceipt method, and it generates that the receipt cloned is corrupted So, we have problems of refresh of receipt, for example issue 28457 and 27983. To avoid this problems, the order is saved in database local, when calculate gross is executed (to fix of other way the issue 28457) And removed the fix to issue 27983, now it is working fine with the change to save the receipt in database local when calculate gross is executed --- M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0076983) malsasua (developer) 2015-05-05 10:37 |
reopened. It is not working fine in the next case: . new receipt R1 .. add line . new receipt R2 .. add line . go to cashup, and cancel cashup -> R1 is displayed . change to R2 .. add new line -> total is not recalculated |
|
(0076986) hgbot (developer) 2015-05-05 10:54 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e26bd6bc65dde648cf787ee514fe341ad8409d70 Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com> Date: Tue May 05 10:09:54 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e26bd6bc65dde648cf787ee514fe341ad8409d70 [^] related to issue 29747: backout changeset 4679 It is not working fine when: receipt 1 is created, receipt 2 is created, go to cashup, cancel cashup (receipt 1 is displayed), change to receipt 2, add new line in receipt 2-> total is not refresh It will be reviewed and fixed in RR15Q3 --- M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0077022) hgbot (developer) 2015-05-05 16:27 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 89287782a16328b35318df6fb754ae4942d9881e Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com> Date: Tue May 05 16:26:24 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/89287782a16328b35318df6fb754ae4942d9881e [^] Related to issue 29747: backed out of e26bd6bc65dd This changeset is undoing a backed out of 37235e8d729a (4679). The fix is ok, but it is falling in one case: receipt 1 is created, receipt 2 is created, go to cashup, cancel cashup (receipt 1 is displayed), change to receipt 2, add new line in receipt 2-> total is not refresh --- M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0077041) hgbot (developer) 2015-05-06 10:05 |
Repository: tools/automation/pi-mobile Changeset: 6c469f043ee4291e5dc980dc0a7df2f9e84c539c Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed May 06 10:04:23 2015 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c469f043ee4291e5dc980dc0a7df2f9e84c539c [^] Related to issue 29530, verifies issue 29747: Added the 'I29747_TotalNotUpdatedAfterCashupCancel' test --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I29747_TotalNotUpdatedAfterCashupCancel.java --- |
|
(0078548) hgbot (developer) 2015-06-29 09:23 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3d2850e5dea723a6242c0eb6aebc3aae5b9ad32f Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Jun 29 09:23:33 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d2850e5dea723a6242c0eb6aebc3aae5b9ad32f [^] Fixed issue 29747 --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0078550) hgbot (developer) 2015-06-29 10:52 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 87b76c61d1a027db490ed3e7606c369dcd8f1acf Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Jun 29 10:51:56 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/87b76c61d1a027db490ed3e7606c369dcd8f1acf [^] Fixed issue 29747. Prevent problems due to saving wrong property in the order model. Previously, it could happen that the skipApplyPromotions property was persisted in the database due to calculateGross saving the receipt. Now that cannot happen, as the skipApplyPromotions property is reset to its previous value before calling calculateGross. If skipApplyPromotions was saved to 'true', this could lead to serious problems as the promotions wouldn't be calculated, which means that in some cases even calculateGross would also not happen, so the ticket total would be wrong. --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0078566) malsasua (developer) 2015-06-29 16:22 |
verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-04-30 10:27 | lorenzofidalgo | New Issue | |
| 2015-04-30 10:27 | lorenzofidalgo | Assigned To | => Retail |
| 2015-04-30 10:27 | lorenzofidalgo | File Added: WrongChange.png | |
| 2015-04-30 10:27 | lorenzofidalgo | Regression level | => Packaging and release |
| 2015-04-30 10:27 | lorenzofidalgo | Regression introduced in release | => main |
| 2015-04-30 10:27 | lorenzofidalgo | Triggers an Emergency Pack | => No |
| 2015-04-30 10:28 | lorenzofidalgo | Relationship added | related to 0029699 |
| 2015-04-30 10:32 | lorenzofidalgo | Priority | normal => immediate |
| 2015-04-30 10:35 | Orekaria | Relationship added | blocks 0028933 |
| 2015-04-30 10:37 | Orekaria | Relationship added | blocks 0029465 |
| 2015-04-30 10:37 | Orekaria | Relationship deleted | blocks 0028933 |
| 2015-04-30 17:44 | marvintm | Assigned To | Retail => malsasua |
| 2015-04-30 17:45 | marvintm | Status | new => scheduled |
| 2015-05-04 13:47 | hgbot | Checkin | |
| 2015-05-04 13:47 | hgbot | Note Added: 0076942 | |
| 2015-05-04 13:47 | hgbot | Status | scheduled => resolved |
| 2015-05-04 13:47 | hgbot | Resolution | open => fixed |
| 2015-05-04 13:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37235e8d729ae054946c4355d7cc74bf76168b11 [^] |
| 2015-05-04 17:26 | malsasua | Regression date | => 2015-01-13 |
| 2015-05-04 17:26 | malsasua | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26cdf0109b187e9d1a968e80846bde61c45f2fb8 [^] |
| 2015-05-05 10:33 | malsasua | Relationship added | related to 0028582 |
| 2015-05-05 10:37 | malsasua | Note Added: 0076983 | |
| 2015-05-05 10:37 | malsasua | Status | resolved => new |
| 2015-05-05 10:37 | malsasua | Resolution | fixed => open |
| 2015-05-05 10:37 | malsasua | Target Version | => RR15Q3 |
| 2015-05-05 10:54 | hgbot | Checkin | |
| 2015-05-05 10:54 | hgbot | Note Added: 0076986 | |
| 2015-05-05 16:27 | hgbot | Checkin | |
| 2015-05-05 16:27 | hgbot | Note Added: 0077022 | |
| 2015-05-06 10:05 | hgbot | Checkin | |
| 2015-05-06 10:05 | hgbot | Note Added: 0077041 | |
| 2015-06-29 09:23 | hgbot | Checkin | |
| 2015-06-29 09:23 | hgbot | Note Added: 0078548 | |
| 2015-06-29 09:23 | hgbot | Status | new => resolved |
| 2015-06-29 09:23 | hgbot | Resolution | open => fixed |
| 2015-06-29 09:23 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37235e8d729ae054946c4355d7cc74bf76168b11 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d2850e5dea723a6242c0eb6aebc3aae5b9ad32f [^] |
| 2015-06-29 09:56 | marvintm | Assigned To | malsasua => marvintm |
| 2015-06-29 09:56 | marvintm | Status | resolved => new |
| 2015-06-29 09:56 | marvintm | Resolution | fixed => open |
| 2015-06-29 10:52 | hgbot | Checkin | |
| 2015-06-29 10:52 | hgbot | Note Added: 0078550 | |
| 2015-06-29 10:52 | hgbot | Status | new => resolved |
| 2015-06-29 10:52 | hgbot | Resolution | open => fixed |
| 2015-06-29 10:52 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d2850e5dea723a6242c0eb6aebc3aae5b9ad32f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/87b76c61d1a027db490ed3e7606c369dcd8f1acf [^] |
| 2015-06-29 16:22 | malsasua | Review Assigned To | => malsasua |
| 2015-06-29 16:22 | malsasua | Note Added: 0078566 | |
| 2015-06-29 16:22 | malsasua | Status | resolved => closed |
| 2015-06-29 16:22 | malsasua | Fixed in Version | => RR15Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |