Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029710
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Layaway orderminoralways2015-04-27 16:522015-06-23 18:00
ReporterlorenzofidalgoView Statuspublic 
Assigned Toadrianromero 
PriorityimmediateResolutionfixedFixed in VersionRR15Q3
StatusclosedFix in branchFixed in SCM revisionb60f5c999923
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned Tomigueldejuana
Regression levelPackaging and release
Regression date
Regression introduced in releaseRR15Q1.3
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029710: "Use Credit" button should not appear when a receipt is marked as "To be laid away"

Description"Use Credit" button should not appear, configured or not, when a receipt is marked as "To be laid away". (Before complete it as a layaway receipt. Only recovered layaway receipts could be paid, credit or not credit).
[This behaviour has been reproduced in RR15Q2 & RR15Q1.3.]
Steps To Reproduce0-Configure terminal and business partner to be able to use credit.
1-Login POS as vallblanca//openbravo.
2-Create a receipt and add a product to this receipt.
3-In dropdown menu button, click "Layaway this receipt".
4-Click Total Amount button.
Defect: Check "Use Credit" button appears.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0028963 closedadrianromero [RR15Q1.1] Use Credit button wrongly appears at webpos, when the user selects Layaway this receipt option 

-  Notes
(0076790)
hgbot (developer)
2015-04-27 18:00

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 810037773a7f8052ce54f05ee16f0912c4de0a87
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Apr 27 17:56:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/810037773a7f8052ce54f05ee16f0912c4de0a87 [^]

Fixes issue 0029710: 'Use Credit' button should not appear when a receipt is marked as 'To be laid away'
* It has been modified the behaviour when 'Use Credit' appears in layaways. It appears only in loaded layaways not in new layaways.
* It has been centralized in one funtion the logic that shows/hides 'Use Credit' button: updateCreditSalesAction()

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0077061)
malsasua (developer)
2015-05-06 18:03

 When a layaway is partial paid, and it is voided, use credit button is displayed, and it was not displayed before the changeset:
. configure the terminal and the customer to use credit
. create a layaway and to do a partial paid
. load the layaway, and void it:
use credit button is displayed

I think that the problem is in the line:
visible = visible && (this.receipt.get('isLayaway') || (this.receipt.get('orderType') !== 2 && this.receipt.get('orderType') !== 3));

In case that it is ok, and we want to able to use credit when layaway is voided, then this line:
visible = visible && (this.receipt.get('isLayaway') || (this.receipt.get('orderType') !== 2 && this.receipt.get('orderType') !== 3));
shoud be:
visible = visible && (this.receipt.get('isLayaway') || this.receipt.get('orderType') !== 2)
(0078291)
hgbot (developer)
2015-06-15 11:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b60f5c99992371c2b469b9db43a75484c740d299
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jun 15 11:33:39 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b60f5c99992371c2b469b9db43a75484c740d299 [^]

Fixes issue 0029710: 'Use Credit' button should not appear when a receipt is marked as 'To be laid away'
Fixing condition to show 'Use Credit' button to make it invisible for voided layaways

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0078456)
migueldejuana (developer)
2015-06-23 18:00

 Tested and reviewed d44b8cfd1584

- Issue History
Date Modified Username Field Change
2015-04-27 16:52 lorenzofidalgo New Issue
2015-04-27 16:52 lorenzofidalgo Assigned To => adrianromero
2015-04-27 16:52 lorenzofidalgo Regression level => Packaging and release
2015-04-27 16:52 lorenzofidalgo Regression introduced in release => RR15Q1.3
2015-04-27 16:52 lorenzofidalgo Triggers an Emergency Pack => No
2015-04-27 16:52 lorenzofidalgo Relationship added related to 0028963
2015-04-27 17:00 lorenzofidalgo Relationship replaced has duplicate 0028963
2015-04-27 18:00 hgbot Checkin
2015-04-27 18:00 hgbot Note Added: 0076790
2015-04-27 18:00 hgbot Status new => resolved
2015-04-27 18:00 hgbot Resolution open => fixed
2015-04-27 18:00 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/810037773a7f8052ce54f05ee16f0912c4de0a87 [^]
2015-05-06 18:03 malsasua Note Added: 0077061
2015-05-06 18:03 malsasua Status resolved => new
2015-05-06 18:03 malsasua Resolution fixed => open
2015-06-15 11:35 hgbot Checkin
2015-06-15 11:35 hgbot Note Added: 0078291
2015-06-15 11:35 hgbot Status new => resolved
2015-06-15 11:35 hgbot Resolution open => fixed
2015-06-15 11:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/810037773a7f8052ce54f05ee16f0912c4de0a87 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b60f5c99992371c2b469b9db43a75484c740d299 [^]
2015-06-23 18:00 migueldejuana Review Assigned To => migueldejuana
2015-06-23 18:00 migueldejuana Note Added: 0078456
2015-06-23 18:00 migueldejuana Status resolved => closed
2015-06-23 18:00 migueldejuana Fixed in Version => RR15Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker