Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029697
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementtrivialalways2015-04-24 19:292016-02-02 09:37
Reporterdmitry_mezentsevView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision036a9f9806d3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Toumartirena
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary

0029697: Description field is filled in with "null" in the FA Transaction when matched to GL Item

DescriptionDescription field is filled in with "null" in the FA Transaction when matched to GL Item, see steps to reproduce
Steps To Reproducelive.builds.pi

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Mention that its Description contains "null" while should contain "GL Item: <Name>".
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00297043.0PR15Q2 closedjorge-garcia Description field is filled in with "null" in the FA Transaction when matched to GL Item 
depends on backport 00297053.0PR15Q1.4 closedjorge-garcia Description field is filled in with "null" in the FA Transaction when matched to GL Item 
caused by feature request 00293903.0PR14Q4 closedSandrahuguet Reconciliation refactor project 

-  Notes
(0076787)
jorge-garcia (reporter)
2015-04-27 17:00

Test Plan:

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Check that its Description contains "GL Item: <Name>".
(0076818)
hgbot (developer)
2015-04-28 11:51

Repository: erp/devel/pi
Changeset: 036a9f9806d3533e37505b54d8792209d4e7850a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Apr 27 16:52:31 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/036a9f9806d3533e37505b54d8792209d4e7850a [^]

Fixed issue 29697: Description field is set with "null" in the FA Transaction

Description field is filled in with "null" in the FA Transaction when matched
to GL Item.

The problem was in the Match Statement process, more specifically, in the
Add new transaction button. The AddTransanctionActionHandler didn't
take in consideration that the received description could be null.

The fix for this issue is to check if the received description is null
or blank.

Now, the description field fill in the correct description.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
---
(0076827)
umartirena (reporter)
2015-04-28 12:42

Code Review + Testing OK
(0077170)
hudsonbot (developer)
2015-05-07 22:17

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0083819)
hgbot (developer)
2016-02-02 09:37

Repository: tools/automation/int
Changeset: 37883ad12198335a2070c9e1918114bfbb4d0ed6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 02 12:30:43 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/37883ad12198335a2070c9e1918114bfbb4d0ed6 [^]

Related to issue 29697: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/data/financial/receivablespayables/transactions/AddTransactionData.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression29697In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression29697Out.java
---

- Issue History
Date Modified Username Field Change
2015-04-24 19:29 dmitry_mezentsev New Issue
2015-04-24 19:29 dmitry_mezentsev Assigned To => Triage Finance
2015-04-24 19:29 dmitry_mezentsev Modules => Core
2015-04-24 19:29 dmitry_mezentsev Regression level => Production - Confirmed Stable
2015-04-24 19:29 dmitry_mezentsev Regression introduced in release => 3.0PR14Q4
2015-04-24 19:29 dmitry_mezentsev Triggers an Emergency Pack => No
2015-04-24 19:31 dmitry_mezentsev Relationship added caused by 0029390
2015-04-27 13:14 jorge-garcia Status new => scheduled
2015-04-27 13:14 jorge-garcia Assigned To Triage Finance => jorge-garcia
2015-04-27 13:16 umartirena Regression date => 2014-09-23
2015-04-27 13:16 umartirena Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-04-27 13:24 dmitry_mezentsev Assigned To jorge-garcia => dmitry_mezentsev
2015-04-27 13:25 dmitry_mezentsev Assigned To dmitry_mezentsev => jorge-garcia
2015-04-27 17:00 jorge-garcia Note Added: 0076787
2015-04-28 11:51 hgbot Checkin
2015-04-28 11:51 hgbot Note Added: 0076818
2015-04-28 11:51 hgbot Status scheduled => resolved
2015-04-28 11:51 hgbot Resolution open => fixed
2015-04-28 11:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/036a9f9806d3533e37505b54d8792209d4e7850a [^]
2015-04-28 12:42 umartirena Review Assigned To => umartirena
2015-04-28 12:42 umartirena Note Added: 0076827
2015-04-28 12:42 umartirena Status resolved => closed
2015-04-28 12:42 umartirena Fixed in Version => pi
2015-05-07 22:17 hudsonbot Checkin
2015-05-07 22:17 hudsonbot Note Added: 0077170
2016-02-02 09:37 hgbot Checkin
2016-02-02 09:37 hgbot Note Added: 0083819


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker