0002962: Heartbeat fails on pospone

Description

Choosing the "Later" option on the Heartbeat config popup fails giving the following error on the application server:

javax.servlet.ServletException: @CODE=0@ERROR: la columna Â«postpone_dateÂ» es de tipo timestamp without time zone pero la expresiÃ³n es de tipo character varying
at org.openbravo.erpCommon.ad_background.PeriodicHeartbeatData.postpone(Unknown Source)
at org.openbravo.erpCommon.ad_forms.Heartbeat.doPost(Unknown Source)

It refers to the datatypes of field postpone_date.
I'm using a SVN Trunk version on Glassfish Application Server v2.1, but it's not an App Srv issue.

I suggest this workaround/solution:
- File PeriodicHeartbeatData in package org.openbravo.erpCommon.ad_background
- Method postpone(...)
- Replace line:
UtilSql.setValue(st, iParameter, 12, null, postponeDate);
with
//UtilSql.setValue(st, iParameter, 12, null, postponeDate);
UtilSql.setValue(st, iParameter, java.sql.Types.TIMESTAMP, null, postponeDate);
(leave original line commented in case of anything)

- File UtilSql on package org.openbravo.data
- Method setValue(...)
- Find:
case java.sql.Types.LONGVARCHAR:
ps.setString(posicion, strValor);
break;
- Add after:
case java.sql.Types.TIMESTAMP:
Date date = (new SimpleDateFormat("dd/MM/yyyy")).parse(strValor);
Timestamp timestamp = new Timestamp(date.getTime());
ps.setTimestamp(posicion, timestamp);
break;

I see a design issue in this, because Timestamps can come in other formats. Perhaps a better solution involves changing the setValue method to receive Objects instead of Strings, so the types are correctly stated on each call. This last suggestion may require changes on every other methods using setValue.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003671) anthony_wolski (viewer) 2008-05-14 07:05 edited on: 2008-06-12 09:26	Logged In: YES user_id=2021124 Originator: NO The sql statement in the postpone method of PeriodicHeartbeat_data.xsql needed the TO_TIMESTAMP method. This line: update AD_SYSTEM_INFO set POSTPONE_DATE = ? has been modified to: update AD_SYSTEM_INFO set POSTPONE_DATE = TO_TIMESTAMP(?, 'DD/MM/YYYY') which fixes the problem. The same issue needed to be fixed in Registration_data.xsql.

(0006551) user71 2005-06-01 00:00 edited on: 2008-06-12 09:43	This bug was originally reported in SourceForge bug tracker and then migrated to Mantis. You can see the original bug report in: https://sourceforge.net/support/tracker.php?aid=1962662 [^]

Issue History
Date Modified	Username	Field	Change
2008-06-18 19:08	plujan	Status	resolved => closed