0002941: Oracle specific code fails on Postgresql

Description

Hi,

browse this file:
openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java

inside you'll see several refernces to
" strError = strError.substring( strError.lastIndexOf("@ORA-") ,strError.length());
"

But "@ORA-" is specific Oracle code that'll lead to errors such as out of range exception (-1 passed to lastIndexOf ) if used with Postgresql under certain circumstances. We got the error while importing the Frechn chart of account on postgresql, we add to comment out those lines to make it pass.

Anyway, I don't really know what the current code breaks wand what would be the best fix, but what I know is that this code is currently unsafe for Postgresql.

Best regards,

RaphaÃ«l Valyi
http://www.smile.fr [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0003698

closed

cromero

Oracle specific code fails on Postgresql

Notes
(0003642) cromero (viewer) 2008-05-06 01:59 edited on: 2008-06-12 09:26	Logged In: YES user_id=1500614 Originator: NO Fixed in the trunk in revision 3955

(0006530) user71 2005-06-01 00:00 edited on: 2008-06-12 09:43	This bug was originally reported in SourceForge bug tracker and then migrated to Mantis. You can see the original bug report in: https://sourceforge.net/support/tracker.php?aid=1953524 [^]

(0007886) psarobe (viewer) 2008-06-19 19:33	Change that code with this: strError = strError.substring( (strError.lastIndexOf("@ORA-")>0?strError.lastIndexOf("@ORA-"):0) ,strError.length());

Issue History
Date Modified	Username	Field	Change
2008-06-19 19:33	psarobe	Status	resolved => closed
2008-06-19 19:33	psarobe	Note Added: 0007886