Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029400
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupmajoralways2015-03-25 12:332015-05-08 14:13
ReporterVictorVillarView Statuspublic 
Assigned Tovmromanos 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision477a8767f780
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toumartirena
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029400: It is possible to add the same UPC for different products

DescriptionIt is possible to add the same UPC for different products
Steps To ReproduceAs group admin role,
 go to Product window,
   Create a new product and add the UPC: 123
   Create a new product and add the UPC: 123

Realise that is possible, and it should not.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0029495 closedOrekaria Retail Modules It is possible to add the same UPC for different products 

-  Notes
(0076309)
Orekaria (administrator)
2015-04-01 14:21

CREATE UNIQUE INDEX m_product_ad_client_upc
   ON m_product (ad_client_id, upc)
   WHERE upc IS NOT NULL;
(0076906)
AtulOpenbravo (developer)
2015-04-30 11:27
edited on: 2015-05-05 15:54

Test Plan:

- Log in as F&B International Group Admin.
- Create a preference with Property "DoNotAllowDuplicateUpc" with value=Y visible for F&B España org.
- Logout and Login.
- Create a Product for F&B España org with Upc and save it.
- Create another product for F&B Region Norte org with same upc as above and save it.
- System will display a error "Upc already exists for other product within F&B España org and its child. Duplicate Upc for product within F&B España org or its child not allowed."
- Create another product for * org with same upc as above and save it.
- Product will be saved successfully.
- Create another product for F&B US Inc. org with same upc as above and save it.
- Product will be saved successfully.
- Delete preference with property "DoNotAllowDuplicateUpc".
- Logout and Login.
- Create another product F&B Region Sur with same upc as above and save it.
- Product will be saved successfully.

(0077226)
vmromanos (manager)
2015-05-08 11:43

We have decided to implement this restriction in an external module called Unique Product UPC per Organization Tree. This way we avoid any possible collateral issue in Core as a consequence of this new restriction.

The user will have the possibility to configure the organization where the unique UPC restriction is active. This restriction will affect to all its child organizations too.
(0077227)
vmromanos (manager)
2015-05-08 11:48

Test Plan:

1. Install the Unique Product UPC per Organization Tree module
2. Go to Organization window. Select FB España.
3. Go to Information tab. Set Unique UPC.. = Y
4. Go to product window. Create a new product for FB España. Save it. Verify no errors are raised
5. Create a new product for FB España, UPC= A. Save it. Verify no errors are raised
6. Create a new product for FB España, UPC= A. Save it. An error is raised
7. Change organization to Norte. Save it. An error is raised
8. Change organization to FB US. Save it. Verify no errors are raised
(0077228)
hgbot (developer)
2015-05-08 11:54

Repository: erp/mods/org.openbravo.module.unique.upc
Changeset: 477a8767f7802391af8935c9cc6468d7913d5af0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 08 11:49:14 2015 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.unique.upc/rev/477a8767f7802391af8935c9cc6468d7913d5af0 [^]

Fixed bug 29400: Created module Unique Product UPC per Organization Tree

Avoid multiple products with the same UPC inside the organization's tree

Adds a new checkbox at Organization | Information tab to avoid using the same UPC in several products. The constraint affects the organization's child tree.

Note that this behavior is not backwards compatible. It means that the constraint will work only for the products created or updated just after installing & configuring this module

---
R src-db/database/model/modifiedTables/AD_ORGINFO.xml
R src-db/database/sourcedata/AD_COLUMN.xml
R src-db/database/sourcedata/AD_ELEMENT.xml
R src-db/database/sourcedata/AD_FIELD.xml
R src-db/database/sourcedata/AD_MESSAGE.xml
R src-db/database/sourcedata/AD_MODULE.xml
R src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
R src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
R src/org/openbravo/module/unique/upc/eventobserver/OBUUPC_ProductEventHandler.java
R src/org/openbravo/module/unique/upc/util/OBUUPC_Util.java
---
(0077239)
umartirena (reporter)
2015-05-08 14:13

Code Review + Testing OK

- Issue History
Date Modified Username Field Change
2015-03-25 12:33 VictorVillar New Issue
2015-03-25 12:33 VictorVillar Assigned To => migueldejuana
2015-03-25 12:33 VictorVillar Resolution time => 1429826400
2015-03-25 12:33 VictorVillar Triggers an Emergency Pack => No
2015-03-25 12:34 VictorVillar Issue Monitored: networkb
2015-04-01 14:11 Orekaria Assigned To migueldejuana => Orekaria
2015-04-01 14:19 Orekaria Project Retail Modules => Openbravo ERP
2015-04-01 14:20 Orekaria Modules => Core
2015-04-01 14:20 Orekaria Assigned To Orekaria =>
2015-04-01 14:20 Orekaria Category Multi UPC/EAN for Product => 01. General setup
2015-04-01 14:20 Orekaria Proposed Solution updated
2015-04-01 14:21 Orekaria Proposed Solution updated
2015-04-01 14:21 Orekaria Note Added: 0076309
2015-04-01 16:23 VictorVillar Assigned To => Sandrahuguet
2015-04-01 16:45 VictorVillar Steps to Reproduce Updated View Revisions
2015-04-01 16:46 VictorVillar Relationship added related to 0029495
2015-04-07 19:14 AtulOpenbravo Assigned To Sandrahuguet => AtulOpenbravo
2015-04-07 19:14 AtulOpenbravo Status new => scheduled
2015-04-30 11:27 AtulOpenbravo Note Added: 0076906
2015-05-05 15:53 umartirena Note Edited: 0076906 View Revisions
2015-05-05 15:53 umartirena Note Edited: 0076906 View Revisions
2015-05-05 15:54 umartirena Note Edited: 0076906 View Revisions
2015-05-08 11:35 vmromanos Assigned To AtulOpenbravo => vmromanos
2015-05-08 11:43 vmromanos Note Added: 0077226
2015-05-08 11:48 vmromanos Note Added: 0077227
2015-05-08 11:54 hgbot Checkin
2015-05-08 11:54 hgbot Note Added: 0077228
2015-05-08 11:54 hgbot Status scheduled => resolved
2015-05-08 11:54 hgbot Resolution open => fixed
2015-05-08 11:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.unique.upc/rev/477a8767f7802391af8935c9cc6468d7913d5af0 [^]
2015-05-08 14:13 umartirena Review Assigned To => umartirena
2015-05-08 14:13 umartirena Note Added: 0077239
2015-05-08 14:13 umartirena Status resolved => closed
2015-05-08 14:13 umartirena Fixed in Version => pi


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker