Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029319 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 04. Warehouse management | major | always | 2015-03-17 16:25 | 2015-05-12 17:40 | |||
| Reporter | ngarcia | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR15Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | cd9a5d049ffb | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | eduardo_Argal | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029319: Performance Problems on the process of Validating a Costing Rule | |||||||
| Description | Performance Problems on the process of Validating a Costing Rule. The query of the checkTransactionsWithMovDateInClosedPeriod function of the CostingRuleProcessOnProcessHandler class takes too much time | |||||||
| Steps To Reproduce | In an environment with lots of transaction without cost calculated (116405 in our example) As group admin role: Validate a new Costing Rule Check it takes too much time (35 minutes in our example) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0077008) aferraz (manager) 2015-05-05 13:23 |
Test plan: In an environment with lots of transaction without cost calculated (116405 in our example) As group admin role: Validate a new Costing Rule Check it does not take too much time (less than 2 seconds) |
|
(0077329) hgbot (developer) 2015-05-12 11:08 |
Repository: erp/devel/pi Changeset: cd9a5d049ffbfaa5236d30b9537d7df2ee9f8223 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 13:26:14 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/cd9a5d049ffbfaa5236d30b9537d7df2ee9f8223 [^] Fixes issue 29319: Performance problems validating a Costing Rule Query in checkTransactionsWithMovDateInClosedPeriod method of CostingRuleProcessOnProcessHandler class, which has performance problems, has been changed. Now M_Transaction.movementdate are truncated and grouped in order to have only one record per day instead of one record per transaction, which enhance a lot the performance of the query. The query has been created in XSQL, because subquerys in FROM statement in HQL are not supported. --- M src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java M src/org/openbravo/costing/CostingUtils_data.xsql --- |
|
(0077330) hgbot (developer) 2015-05-12 11:08 |
Repository: erp/devel/pi Changeset: e8b37e1f86397afcd9322e313afe4c07fda7afb9 Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Mon May 11 19:21:58 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e8b37e1f86397afcd9322e313afe4c07fda7afb9 [^] Related to issue 29319: Performance Problems on the process of Validating a Costing Rule Some code refactoring after code review --- M src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java M src/org/openbravo/costing/CostingUtils_data.xsql --- |
|
(0077331) aferraz (manager) 2015-05-12 11:10 |
Code review + Testing done by eduardo-Argal OK |
|
(0077350) hudsonbot (developer) 2015-05-12 17:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d9fee60cdbd [^] Maturity status: Test |
|
(0077351) hudsonbot (developer) 2015-05-12 17:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d9fee60cdbd [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-03-17 16:25 | ngarcia | New Issue | |
| 2015-03-17 16:25 | ngarcia | Assigned To | => umartirena |
| 2015-03-17 16:25 | ngarcia | Modules | => Core |
| 2015-03-17 16:25 | ngarcia | Resolution time | => 1428703200 |
| 2015-03-17 16:25 | ngarcia | Triggers an Emergency Pack | => No |
| 2015-03-17 16:26 | ngarcia | Issue Monitored: networkb | |
| 2015-03-17 16:39 | heccam | Issue Monitored: heccam | |
| 2015-05-04 09:20 | aferraz | Assigned To | umartirena => aferraz |
| 2015-05-04 13:48 | aferraz | Status | new => scheduled |
| 2015-05-05 13:23 | aferraz | Note Added: 0077008 | |
| 2015-05-12 11:08 | hgbot | Checkin | |
| 2015-05-12 11:08 | hgbot | Note Added: 0077329 | |
| 2015-05-12 11:08 | hgbot | Status | scheduled => resolved |
| 2015-05-12 11:08 | hgbot | Resolution | open => fixed |
| 2015-05-12 11:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/cd9a5d049ffbfaa5236d30b9537d7df2ee9f8223 [^] |
| 2015-05-12 11:08 | hgbot | Checkin | |
| 2015-05-12 11:08 | hgbot | Note Added: 0077330 | |
| 2015-05-12 11:10 | aferraz | Review Assigned To | => eduardo_Argal |
| 2015-05-12 11:10 | aferraz | Note Added: 0077331 | |
| 2015-05-12 11:10 | aferraz | Status | resolved => closed |
| 2015-05-12 11:10 | aferraz | Fixed in Version | => 3.0PR15Q3 |
| 2015-05-12 17:40 | hudsonbot | Checkin | |
| 2015-05-12 17:40 | hudsonbot | Note Added: 0077350 | |
| 2015-05-12 17:40 | hudsonbot | Checkin | |
| 2015-05-12 17:40 | hudsonbot | Note Added: 0077351 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |