Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029254 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | always | 2015-03-12 09:56 | 2015-03-13 20:09 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR14Q3.8 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ea610afa4225 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR14Q3.8 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2014-05-20 | |||||||
| Regression introduced in release | 3.0PR14Q3 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/d9ce373c75dad51598fb943d75e4d8e56f1d56eb [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029254: Can't filter in numeric fields using the value 0 | |||||||
| Description | Is not possible to filter numeric fields using the value 0, the following error appears in the javascript console: "Uncaught TypeError: Cannot read property 'operator' of undefined" | |||||||
| Steps To Reproduce | 1) Go to the Sales Order window 2) Try to filter by Delivery Status or Invoice Status fields , using the value 0 3) Notice that the filtering is not done and the error in description appears | |||||||
| Tags | Approved | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0075496) hgbot (developer) 2015-03-12 17:08 |
Repository: erp/backports/3.0PR14Q3.8 Changeset: ea610afa4225516668fe5f6c86c9232ff8d12013 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Mar 12 12:00:30 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/ea610afa4225516668fe5f6c86c9232ff8d12013 [^] Fixes issue 29254: 0 can be used to filter numeric columns In this changeset [1] this code was added to the OBNumberItem.parseValueExpressions function: ret = this.Super('parseValueExpressions', [value, fieldName, operator]); + + // if operator is not supported remove it + if (!this.validOperators.contains(ret.operator)) { + ret.operator = ''; + ret.value = ''; + this.setValue(''); + } if (ret && ret.start) { ret.start = this.convertToTypedValue(ret.start); } The problem is that if the provided value is 0, this.Super('parseValueExpressions', [value, fieldName, operator]) will return undefined. This happens because of a bug in smartclient's implementation of the parseValueExpressions function. This code is placed at the beginning of that function: if (!value) value = this.getValue(); if (!value) return; if (!isc.isA.String(value)) value += ""; If the provided value is 0, the value will be taken from this.getValue(). The returned value will again be evaluated to false, so the function will not return any value. Right after that, there is a comman d to convert the provided value to String. To fix this, in the call to this.Super('parseValueExpressions'), the string representation of the number will be passed instead of its numerical value. This way smartclient will accept the value and will n ot return undefined. Smartclient was already converting the passed values to String, so there is no risk there. The value passed to the OBNumberItem.parseValueExpressions is not modified to prevent unexpected consequences. A copy of it is converted to string and passed to the this.Super('parseValueExpressions') func tion. [1] https://code.openbravo.com/erp/devel/pi/rev/d9ce373c75dad51598fb943d75e4d8e56f1d56eb [^] --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js --- |
|
(0075539) alostale (manager) 2015-03-13 11:57 |
code reviewed tested in Sales Order delivery status (computed column) and total gross amount (regular column) with values: -0 -100 ->1000 -<1000 -^3 (as reported in 0026305, in this case the filter is removed as it is not supported textual filters in numeric columns) |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-03-12 11:33 | AugustoMauch | Type | defect => backport |
| 2015-03-12 11:33 | AugustoMauch | Target Version | => 3.0PR14Q3.8 |
| 2015-03-12 17:07 | AugustoMauch | Issue Monitored: alostale | |
| 2015-03-12 17:08 | AugustoMauch | Review Assigned To | => alostale |
| 2015-03-12 17:08 | hgbot | Checkin | |
| 2015-03-12 17:08 | hgbot | Note Added: 0075496 | |
| 2015-03-12 17:08 | hgbot | Status | scheduled => resolved |
| 2015-03-12 17:08 | hgbot | Resolution | open => fixed |
| 2015-03-12 17:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/ea610afa4225516668fe5f6c86c9232ff8d12013 [^] |
| 2015-03-13 11:06 | alostale | Relationship added | caused by 0026305 |
| 2015-03-13 11:57 | alostale | Note Added: 0075539 | |
| 2015-03-13 11:57 | alostale | Status | resolved => closed |
| 2015-03-13 11:57 | alostale | Fixed in Version | => 3.0PR14Q3.8 |
| 2015-03-13 20:09 | dmitry_mezentsev | Tag Attached: Approved | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |