Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029221
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Return Receiptmajoralways2015-03-10 13:282015-03-30 12:38
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR15Q2
StatusclosedFix in branchFixed in SCM revisionf876c9ef309b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029221: Discounts wrong calculated when splitting lines in returns

DescriptionWe are no calculating well discounts when returning a verified return. We are using remaining quantity instead of total line qty.
Steps To Reproduce- Activate "Split Lines in Shipments when Returning" preference
- Login
- Create an order with stock in 2 different bins adding 10% discount
- Press Verified Returns in the menu
- Select previous order and return part of the qty
- Complete the return
- Press Verified Returns in the menu
- Select previous order and return all qty
- ERROR: See discounts applied
Proposed SolutionReplace:

 splitpromo.amt = OB.DEC.mul(p.amt, (splitline.remainingQuantity / line.remainingQuantity));
                  splitpromo.actualAmt = OB.DEC.mul(p.actualAmt, (splitline.remainingQuantity / line.remainingQuantity));

With:

 splitpromo.amt = OB.DEC.mul(p.amt, (splitline.remainingQuantity / line.quantity));
                  splitpromo.actualAmt = OB.DEC.mul(p.actualAmt, (splitline.remainingQuantity / line.quantity));
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0075681)
hgbot (developer)
2015-03-17 09:56

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: f876c9ef309bcafba6ca8644fc4f01a7462c4c1e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 17 09:50:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/f876c9ef309bcafba6ca8644fc4f01a7462c4c1e [^]

Fixed issue 0029221: Discounts wrong calculated when splitting lines in returns

We have to calculate amount discounted based on the total line quantity.

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---

- Issue History
Date Modified Username Field Change
2015-03-10 13:28 migueldejuana New Issue
2015-03-10 13:28 migueldejuana Assigned To => malsasua
2015-03-10 13:28 migueldejuana OBNetwork customer => No
2015-03-10 13:28 migueldejuana Regression level => Production - QA Approved
2015-03-10 13:28 migueldejuana Triggers an Emergency Pack => No
2015-03-12 16:23 migueldejuana Regression level Production - QA Approved =>
2015-03-17 09:21 migueldejuana Assigned To malsasua => migueldejuana
2015-03-17 09:56 hgbot Checkin
2015-03-17 09:56 hgbot Note Added: 0075681
2015-03-17 09:56 hgbot Status new => resolved
2015-03-17 09:56 hgbot Resolution open => fixed
2015-03-17 09:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/f876c9ef309bcafba6ca8644fc4f01a7462c4c1e [^]
2015-03-30 11:45 marvintm Note Added: 0076129
2015-03-30 11:45 marvintm Status resolved => new
2015-03-30 11:45 marvintm Resolution fixed => open
2015-03-30 12:28 marvintm Note Deleted: 0076129
2015-03-30 12:35 marvintm Status new => scheduled
2015-03-30 12:35 marvintm Status scheduled => resolved
2015-03-30 12:35 marvintm Fixed in Version => RR15Q2
2015-03-30 12:35 marvintm Resolution open => fixed
2015-03-30 12:38 marvintm Review Assigned To => marvintm
2015-03-30 12:38 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker