Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029214 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 07. Sales management | major | always | 2015-03-10 10:03 | 2015-04-01 08:31 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR15Q1.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 721b9a12adee | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q1.2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2014-12-22 | |||||||
| Regression introduced in release | 3.0PR15Q1 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/95dd177fbbc7 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029214: can't filter multiple products in return from/to P&Es | |||||||
| Description | In Return from Customer and Return to Vendor P&E it is not possible to filter by more than one product at the same time using product filter drop down list. A HQL error occurs and no data is shown in the grid. Even the request from client is correctly sent to backend, there is a problem when generating the HQL query: 1. When there is a single product it looks like: select ... FROM MaterialMgmtShipmentInOutLine as iol where ... AND ( iol.product.id = :alias_0 ) 2. When filtering by multiple products: select ... FROM MaterialMgmtShipmentInOutLine as iol where ... AND ( ( join_0.id = :alias_0 or join_0.id = :alias_1 ) ) 2nd case is incorrect (join_0 is not a valid alias) | |||||||
| Steps To Reproduce | -Go to Return to Vendor window -Create new record -Click Pick/Edit lines -Clear filters to show several lines with different product -Open product filter drop down list and select 1 product ->OK: grid is filtered correctly by that product -Open product filter drop down list and select another product keeping previous selection -> FAIL: -No data is shown in grid -Openbravo log shows: de854ee5 1817163 [http-8080-2] ERROR org.openbravo.service.datasource.DataSourceServlet - Invalid path: 'join_0.id' [select ...] at org.hibernate.hql.ast.QuerySyntaxException.convert(QuerySyntaxException.java:54) | |||||||
| Tags | Approved | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0075375) hgbot (developer) 2015-03-10 12:50 |
Repository: erp/backports/3.0PR15Q1.2 Changeset: 721b9a12adeea9332779275d4e290a2db8b603f2 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Mar 10 12:20:08 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/721b9a12adeea9332779275d4e290a2db8b603f2 [^] Fixes issue 29214: Filtering multiple products work in Return from/to P&E The problem was that the HQL WHERE clause built by the AdvancedQueryBuilder was not proper, as it where using join aliases that where not present in the FROM clause. This happened when the AdvancedQueryBuilder was used in the HQLDataSourceService class, because that class uses the WHERE clause returned by the AdvancedQueryBuilder, and the HQL FROM clause defined in the application dictionary. The resulting HQL query was like this: SELECT iol.id as id, ... FROM OrderLine AS ol LEFT JOIN ol.salesOrder AS o WHERE ... AND (( join_0.id = :alias_0 or join_0.id = :alias_1 ) ) The first two lines are built using the HQL transformers based on the HQL defined in the application dictionary, and the last two lines are built using the AdvancedQueryBuilder. The WHERE clause uses a join alias (join_0) that is not defined in the FROM clause The new join alias was created in the resolveJoins method, that was invoked when the criteria contained an OR operator. To fix this issue, a new flag, creatingJoinsInWhereClauseIsPrevented, has been added. If this flag is true, instead of creating a new join alias for the where clause, the clause will be built using the entity main alias and the property name. As for now this new flag is only set to true in the HqlDataSourceService class. --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java --- |
|
(0075408) alostale (manager) 2015-03-10 16:10 edited on: 2015-03-10 16:14 |
Code reviewed Tested: -Following steps to reproduce -UOM field in Return window -No other FK drops downs are present in core P&E -As per code review this patch only affects P&E windows, so standard windows shouldn't be affected |
|
(0076205) hgbot (developer) 2015-04-01 08:06 |
Repository: erp/backports/3.0PR15Q2 Changeset: 721b9a12adeea9332779275d4e290a2db8b603f2 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Mar 10 12:20:08 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/721b9a12adeea9332779275d4e290a2db8b603f2 [^] Fixes issue 29214: Filtering multiple products work in Return from/to P&E The problem was that the HQL WHERE clause built by the AdvancedQueryBuilder was not proper, as it where using join aliases that where not present in the FROM clause. This happened when the AdvancedQueryBuilder was used in the HQLDataSourceService class, because that class uses the WHERE clause returned by the AdvancedQueryBuilder, and the HQL FROM clause defined in the application dictionary. The resulting HQL query was like this: SELECT iol.id as id, ... FROM OrderLine AS ol LEFT JOIN ol.salesOrder AS o WHERE ... AND (( join_0.id = :alias_0 or join_0.id = :alias_1 ) ) The first two lines are built using the HQL transformers based on the HQL defined in the application dictionary, and the last two lines are built using the AdvancedQueryBuilder. The WHERE clause uses a join alias (join_0) that is not defined in the FROM clause The new join alias was created in the resolveJoins method, that was invoked when the criteria contained an OR operator. To fix this issue, a new flag, creatingJoinsInWhereClauseIsPrevented, has been added. If this flag is true, instead of creating a new join alias for the where clause, the clause will be built using the entity main alias and the property name. As for now this new flag is only set to true in the HqlDataSourceService class. --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java --- |
|
(0076270) priyam (administrator) 2015-04-01 08:31 |
closed again, as the status changed due the merge tag of 3.0PR15Q1.2 to backports/3.0PR15Q2 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-03-10 11:24 | AugustoMauch | Type | defect => backport |
| 2015-03-10 11:24 | AugustoMauch | Target Version | => 3.0PR15Q1.2 |
| 2015-03-10 12:50 | hgbot | Checkin | |
| 2015-03-10 12:50 | hgbot | Note Added: 0075375 | |
| 2015-03-10 12:50 | hgbot | Status | scheduled => resolved |
| 2015-03-10 12:50 | hgbot | Resolution | open => fixed |
| 2015-03-10 12:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/721b9a12adeea9332779275d4e290a2db8b603f2 [^] |
| 2015-03-10 12:53 | AugustoMauch | Issue Monitored: alostale | |
| 2015-03-10 12:53 | AugustoMauch | Review Assigned To | => alostale |
| 2015-03-10 16:10 | alostale | Note Added: 0075408 | |
| 2015-03-10 16:10 | alostale | Status | resolved => closed |
| 2015-03-10 16:10 | alostale | Fixed in Version | => 3.0PR15Q1.2 |
| 2015-03-10 16:14 | alostale | Note Edited: 0075408 | View Revisions |
| 2015-03-13 14:01 | dmitry_mezentsev | Tag Attached: Approved | |
| 2015-04-01 08:06 | hgbot | Checkin | |
| 2015-04-01 08:06 | hgbot | Note Added: 0076205 | |
| 2015-04-01 08:06 | hgbot | Status | closed => resolved |
| 2015-04-01 08:06 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/721b9a12adeea9332779275d4e290a2db8b603f2 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/721b9a12adeea9332779275d4e290a2db8b603f2 [^] |
| 2015-04-01 08:31 | priyam | Status | resolved => closed |
| 2015-04-01 08:31 | priyam | Note Added: 0076270 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |