Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029188
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 04. Warehouse managementmajoralways2015-03-03 18:302015-04-01 14:02
ReporterumartirenaView Statuspublic 
Assigned Toumartirena 
PriorityhighResolutionfixedFixed in Version3.0PR15Q1.3
StatusclosedFix in branchFixed in SCM revisiondbad9bc87bbd
ProjectionnoneETAnoneTarget Version3.0PR15Q1.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029188: Performance Problems on Costing Background process

DescriptionRunning Costing Background process on an environment with a lot of transactions to be calculated (200.000), it consumes a lot of memory and cpu, and it does not finish.
Steps To ReproduceWe have an environment with a lot of transactions in which the problem is reproduced.

Launch Costing Background process.
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0029118 closedumartirena Performance Problems on Costing Background process 

-  Notes
(0076288)
hgbot (developer)
2015-04-01 10:47

 Repository: erp/backports/3.0PR15Q1.3
Changeset: dbad9bc87bbda4a186943b37333a1bdcbf55254d
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Mar 04 16:09:33 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/dbad9bc87bbda4a186943b37333a1bdcbf55254d [^]

Fixes bug 29188: Performance improved in Costing Background process.

There are two methods in Costing Background process in which an ScrollableResult is built and iterated. 'setCalculatedTransactionsAsProcessed' and 'setCalculatedTransactionsAsProcessed'. This loops where causing Out of memory issues because they were not flushing and clearing session every little amount of iterations. Apart from this, the two ScrollableResults were leaving opened, which may cause lot of issues especially in Oracle.

Finally, these methods have been implemented in another way. Directly updating all the records on a single update in hql. In this way the performance is improved even adding flush and clear on the previously loops.

---
M src/org/openbravo/costing/CostingBackground.java
---
(0076292)
Sandrahuguet (developer)
2015-04-01 10:49

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2015-03-09 09:21 umartirena Type defect => backport
2015-03-09 09:21 umartirena Target Version => 3.0PR15Q1.2
2015-03-27 13:31 Sandrahuguet Target Version 3.0PR15Q1.2 => 3.0PR15Q1.3
2015-04-01 10:47 hgbot Checkin
2015-04-01 10:47 hgbot Note Added: 0076288
2015-04-01 10:47 hgbot Status scheduled => resolved
2015-04-01 10:47 hgbot Resolution open => fixed
2015-04-01 10:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/dbad9bc87bbda4a186943b37333a1bdcbf55254d [^]
2015-04-01 10:49 Sandrahuguet Review Assigned To => Sandrahuguet
2015-04-01 10:49 Sandrahuguet Note Added: 0076292
2015-04-01 10:49 Sandrahuguet Status resolved => closed
2015-04-01 10:49 Sandrahuguet Fixed in Version => 3.0PR15Q1.3
2015-04-01 14:02 dmitry_mezentsev Tag Attached: Approved

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker