0029094: Wrong behaviour of Generate Receipt from invoice, generates too many receipts

Notes
(0075181) reinaldoguerra (viewer) 2015-03-05 00:38	Test plan used: 1- Login into Openbravo ERP 2- As syetem administrator go to Purchase Invoice window 3- Select header tab and go to Fields tab 4- Check Displayed option for the field "Generate Receipt from Invoice" 5- Logout and login again 6- Go to Purchase Order and create a new header 7- Go to lines tab and create a new one. 8- Select a product, qty: 1 9- Book it 10- Go to Goods Receipt window and create a new header (same order's business partner and organization) 11- Click on Create Lines From button, select previous created order, enter a storage bin in the grid's record and click OK button 12- Complete the receipt. 13- Go to Purchase invoice window and create a new header 14- Click on Create Lines From button, select previous created receipt, select grid's record and click OK button 15- Realize that button "Generate Receipt from Invoice" does not appear. 16- Complete the invoice 17- Now the button will be shown. Click on it and a new receipt will be generated 18- Click the button again and now an error message will be shown indicating that a Receipt (Shipment) already exists for this invoice.

(0076070) hgbot (developer) 2015-03-27 11:42	Repository: erp/devel/pi Changeset: 91b7e873c3b12a21f0a08de5d1140d69454b6890 Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com> Date: Wed Mar 04 22:20:33 2015 -0500 URL: http://code.openbravo.com/erp/devel/pi/rev/91b7e873c3b12a21f0a08de5d1140d69454b6890 [^] Fixed bug 29094: Generate Receipt from Invoice generates too many receipts. Stored procedure called when Generate Receipt from Invoice process is executed, was returning null when catching the exception launched during regeneration of receitp from the same invoice. This code was removed from the stored procedure, so now the exception is raised and the error message is shown successfuly. No wrong relation is generated between the new Receipt and the Invoice. Another solution would be to relaunch the exception instead of returning null. Also display's logic for field "Generate Receipt from Invoice" was changed to show the button when the invoice is processed. --- M src-db/database/model/functions/C_INVOICE_CREATERECEIPT.xml M src-db/database/sourcedata/AD_FIELD.xml ---

(0076071) vmromanos (viewer) 2015-03-27 11:43	Code review + testing OK

(0076159) hudsonbot (viewer) 2015-03-31 00:07	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/34da08f135b8 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2015-02-27 15:18	VictorVillar	New Issue
2015-02-27 15:18	VictorVillar	Assigned To	=> Sandrahuguet
2015-02-27 15:18	VictorVillar	OBNetwork customer	=> Yes
2015-02-27 15:18	VictorVillar	Modules	=> Core
2015-02-27 15:18	VictorVillar	Support ticket	=> 32587
2015-02-27 15:18	VictorVillar	Resolution time	=> 1426806000
2015-02-27 15:18	VictorVillar	Triggers an Emergency Pack	=> No
2015-02-27 15:18	VictorVillar	Issue Monitored: networkb
2015-03-03 21:20	reinaldoguerra	Assigned To	Sandrahuguet => reinaldoguerra
2015-03-03 21:20	reinaldoguerra	Status	new => scheduled
2015-03-05 00:38	reinaldoguerra	Note Added: 0075181
2015-03-27 11:42	hgbot	Checkin
2015-03-27 11:42	hgbot	Note Added: 0076070
2015-03-27 11:42	hgbot	Status	scheduled => resolved
2015-03-27 11:42	hgbot	Resolution	open => fixed
2015-03-27 11:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/91b7e873c3b12a21f0a08de5d1140d69454b6890 [^]
2015-03-27 11:43	vmromanos	Review Assigned To	=> vmromanos
2015-03-27 11:43	vmromanos	Note Added: 0076071
2015-03-27 11:43	vmromanos	Status	resolved => closed
2015-03-31 00:07	hudsonbot	Checkin
2015-03-31 00:07	hudsonbot	Note Added: 0076159

Relationships [ Relation Graph ] [ Dependency Graph ]