Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029042
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2015-02-24 11:252017-10-02 17:58
ReportermaiteView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityhighResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revisione14398655b0f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029042: Should not be possible to delete a summary node in User Defined Accounting Report Setup

DescriptionShould not be possible to delete a summary node in User Defined Accounting Report
Steps To Reproduce1. Access "User Defined Accounting Report Setup" and create:
 - Node "a" defined as "summary level"
 - Node "b" defined as NOT summary level
 - Node "c" defined as "summary level"
 - Node "d" defined as NOT summary level
2. Go to Tree view and configure tree as:
 - Node b inside of node a
 - Node c inside of node a
 - Node d inside of node c
3. Delete node "c", which is defined as Summary level and contains node d

Realize that no error is shown, but if you try to show Tree view again you will not see node d any more
Proposed SolutionShould not be possible to delete node defined as "summary level" or in case it is possible to delete it, children should also be removed
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0076107)
AtulOpenbravo (developer)
2015-03-30 09:18
edited on: 2016-03-01 13:54

Test Plan
1. Navigate "User Defined Accounting Report Setup" and create:
 - Node "a", set "summary level" = Yes
 - Node "b", set "summary level" = No
 - Node "c", set "summary level" = Yes
 - Node "d", set "summary level" = No
2. Go to Tree view and configure tree as:
 - Node b inside of node a
 - Node c inside of node a
 - Node d inside of node c
3. Delete node "c", which is defined as Summary level and contains node d

Check that OBException is raised as "You cannot delete this node because it has children nodes associated."

Check that it is possible to delete node d (not summary) and after that node c(summary)

(0077369)
hgbot (developer)
2015-05-13 11:12

Repository: erp/devel/pi
Changeset: e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 12 14:03:06 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^]

Fixes Issue 29042:Should not be possible to delete a summary node in User
Defined Accounting Report Setup

After Delete part is added in AD_Accountingrpt_Element_Trg which checks
that whether there exists childs for the element being deleted.

---
M src-db/database/model/triggers/AD_ACCOUNTINGRPT_ELEMENT_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0077370)
umartirena (developer)
2015-05-13 11:13

Code Review + Testing OK
(0077404)
hudsonbot (developer)
2015-05-13 17:15

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fd39a8e74d78 [^]
Maturity status: Test
(0078489)
maite (developer)
2015-06-24 16:01

Wrong error is shown in Oracle instead of proper message:

Error
ORA-04091: table ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT is mutating, trigger/function may not see it ORA-06512: at "ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT_TRG", line 99 ORA-04088: error during execution of trigger 'ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT_TRG'
(0078588)
hgbot (developer)
2015-06-30 11:40

Repository: erp/devel/pi
Changeset: 6241ce62712978814b01b2422aa34d0e58d75963
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Jun 30 11:40:10 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6241ce62712978814b01b2422aa34d0e58d75963 [^]

Related to issue 29042: Backout changeset e8bebe16d4bf

The reverted changeset creates a mutanting trigger in Oracle

---
M src-db/database/model/triggers/AD_ACCOUNTINGRPT_ELEMENT_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0078602)
hudsonbot (developer)
2015-06-30 20:44

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a0fd6a76a3d5 [^]
Maturity status: Test
(0078917)
vmromanos (developer)
2015-07-17 10:17

This functionality can be easily implemented using the Node Deletion Policy = "Reparent Child Nodes" at Tables and Columns | Table Tree Category for the AD_AccountingRpt_Element table
(0084618)
psanjuan (manager)
2016-03-01 12:58

Issue Verified.
(0084621)
psanjuan (manager)
2016-03-01 13:55

Test plan verified in PostgreSQL.
(0099667)
hgbot (developer)
2017-09-28 18:36

Repository: erp/devel/pi
Changeset: e14398655b0f0a616951774dd93eef04d8e0929c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jul 28 17:10:05 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e14398655b0f0a616951774dd93eef04d8e0929c [^]

Fixes issue 29042: Shouldn't be possible to delete summary node in User Defined Accounting Report Setup

Implemented using Node Deletion Policy = "Do Not Allow If Has Children" at
Tables and Columns | Table Tree Category for the AD_AccountingRpt_Element
table

---
M src-db/database/sourcedata/AD_TABLE_TREE.xml
---
(0099668)
aferraz (developer)
2017-09-28 18:36

Code review + Testing OK
(0099700)
hudsonbot (developer)
2017-10-02 17:58

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/44a89970274a [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-02-24 11:25 maite New Issue
2015-02-24 11:25 maite Assigned To => Sandrahuguet
2015-02-24 11:25 maite Modules => Core
2015-02-24 11:25 maite Resolution time => 1430949600
2015-02-24 11:25 maite Triggers an Emergency Pack => No
2015-02-24 11:25 maite Issue Monitored: networkb
2015-03-09 17:37 jonalegriaesarte Resolution time 1430949600 =>
2015-03-30 08:42 AtulOpenbravo Assigned To Sandrahuguet => AtulOpenbravo
2015-03-30 08:43 AtulOpenbravo Status new => scheduled
2015-03-30 09:18 AtulOpenbravo Note Added: 0076107
2015-05-13 11:12 hgbot Checkin
2015-05-13 11:12 hgbot Note Added: 0077369
2015-05-13 11:12 hgbot Status scheduled => resolved
2015-05-13 11:12 hgbot Resolution open => fixed
2015-05-13 11:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^]
2015-05-13 11:13 umartirena Review Assigned To => umartirena
2015-05-13 11:13 umartirena Note Added: 0077370
2015-05-13 11:13 umartirena Status resolved => closed
2015-05-13 11:13 umartirena Fixed in Version => pi
2015-05-13 17:15 hudsonbot Checkin
2015-05-13 17:15 hudsonbot Note Added: 0077404
2015-06-24 16:01 maite Note Added: 0078489
2015-06-24 16:01 maite Status closed => new
2015-06-24 16:01 maite Resolution fixed => open
2015-06-24 16:01 maite Fixed in Version pi =>
2015-06-29 12:42 vmromanos Target Version 3.0PR15Q3 => 3.0PR15Q4
2015-06-30 11:40 hgbot Checkin
2015-06-30 11:40 hgbot Note Added: 0078588
2015-06-30 20:44 hudsonbot Checkin
2015-06-30 20:44 hudsonbot Note Added: 0078602
2015-07-17 10:17 vmromanos Note Added: 0078917
2015-07-28 14:19 AtulOpenbravo Status new => scheduled
2015-07-28 14:22 AtulOpenbravo Note Edited: 0076107 View Revisions
2015-09-28 11:18 vmromanos Target Version 3.0PR15Q4 => 3.0PR16Q1
2015-12-21 16:17 vmromanos Target Version 3.0PR16Q1 =>
2016-03-01 12:58 psanjuan Note Added: 0084618
2016-03-01 13:54 psanjuan Note Edited: 0076107 View Revisions
2016-03-01 13:54 psanjuan Note Edited: 0076107 View Revisions
2016-03-01 13:55 psanjuan Note Added: 0084621
2017-09-28 18:36 hgbot Checkin
2017-09-28 18:36 hgbot Note Added: 0099667
2017-09-28 18:36 hgbot Status scheduled => resolved
2017-09-28 18:36 hgbot Resolution open => fixed
2017-09-28 18:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^] => http://code.openbravo.com/erp/devel/pi/rev/e14398655b0f0a616951774dd93eef04d8e0929c [^]
2017-09-28 18:36 aferraz Review Assigned To umartirena => aferraz
2017-09-28 18:36 aferraz Note Added: 0099668
2017-09-28 18:36 aferraz Status resolved => closed
2017-09-28 18:36 aferraz Fixed in Version => 3.0PR17Q4
2017-10-02 17:58 hudsonbot Checkin
2017-10-02 17:58 hudsonbot Note Added: 0099700


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker