Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029042Openbravo ERP09. Financial managementpublic2015-02-24 11:252017-10-02 17:58
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34511
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029042: Should not be possible to delete a summary node in User Defined Accounting Report Setup
DescriptionShould not be possible to delete a summary node in User Defined Accounting Report
Steps To Reproduce1. Access "User Defined Accounting Report Setup" and create:
 - Node "a" defined as "summary level"
 - Node "b" defined as NOT summary level
 - Node "c" defined as "summary level"
 - Node "d" defined as NOT summary level
2. Go to Tree view and configure tree as:
 - Node b inside of node a
 - Node c inside of node a
 - Node d inside of node c
3. Delete node "c", which is defined as Summary level and contains node d

Realize that no error is shown, but if you try to show Tree view again you will not see node d any more
Proposed SolutionShould not be possible to delete node defined as "summary level" or in case it is possible to delete it, children should also be removed
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-24 11:25maiteNew Issue
2015-02-24 11:25maiteAssigned To => Sandrahuguet
2015-02-24 11:25maiteOBNetwork customer => Yes
2015-02-24 11:25maiteModules => Core
2015-02-24 11:25maiteSupport ticket => 34511
2015-02-24 11:25maiteResolution time => 1430949600
2015-02-24 11:25maiteTriggers an Emergency Pack => No
2015-02-24 11:25maiteIssue Monitored: networkb
2015-03-09 17:37jonalegriaesarteResolution time1430949600 =>
2015-03-30 08:42AtulOpenbravoAssigned ToSandrahuguet => AtulOpenbravo
2015-03-30 08:43AtulOpenbravoStatusnew => scheduled
2015-03-30 09:18AtulOpenbravoNote Added: 0076107
2015-05-13 11:12hgbotCheckin
2015-05-13 11:12hgbotNote Added: 0077369
2015-05-13 11:12hgbotStatusscheduled => resolved
2015-05-13 11:12hgbotResolutionopen => fixed
2015-05-13 11:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^]
2015-05-13 11:13umartirenaReview Assigned To => umartirena
2015-05-13 11:13umartirenaNote Added: 0077370
2015-05-13 11:13umartirenaStatusresolved => closed
2015-05-13 11:13umartirenaFixed in Version => pi
2015-05-13 17:15hudsonbotCheckin
2015-05-13 17:15hudsonbotNote Added: 0077404
2015-06-24 16:01maiteNote Added: 0078489
2015-06-24 16:01maiteStatusclosed => new
2015-06-24 16:01maiteResolutionfixed => open
2015-06-24 16:01maiteFixed in Versionpi =>
2015-06-29 12:42vmromanosTarget Version3.0PR15Q3 => 3.0PR15Q4
2015-06-30 11:40hgbotCheckin
2015-06-30 11:40hgbotNote Added: 0078588
2015-06-30 20:44hudsonbotCheckin
2015-06-30 20:44hudsonbotNote Added: 0078602
2015-07-17 10:17vmromanosNote Added: 0078917
2015-07-28 14:19AtulOpenbravoStatusnew => scheduled
2015-07-28 14:22AtulOpenbravoNote Edited: 0076107bug_revision_view_page.php?bugnote_id=0076107#r9110
2015-09-28 11:18vmromanosTarget Version3.0PR15Q4 => 3.0PR16Q1
2015-12-21 16:17vmromanosTarget Version3.0PR16Q1 =>
2016-03-01 12:58psanjuanNote Added: 0084618
2016-03-01 13:54psanjuanNote Edited: 0076107bug_revision_view_page.php?bugnote_id=0076107#r11291
2016-03-01 13:54psanjuanNote Edited: 0076107bug_revision_view_page.php?bugnote_id=0076107#r11292
2016-03-01 13:55psanjuanNote Added: 0084621
2017-09-28 18:36hgbotCheckin
2017-09-28 18:36hgbotNote Added: 0099667
2017-09-28 18:36hgbotStatusscheduled => resolved
2017-09-28 18:36hgbotResolutionopen => fixed
2017-09-28 18:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^] => http://code.openbravo.com/erp/devel/pi/rev/e14398655b0f0a616951774dd93eef04d8e0929c [^]
2017-09-28 18:36aferrazReview Assigned Toumartirena => aferraz
2017-09-28 18:36aferrazNote Added: 0099668
2017-09-28 18:36aferrazStatusresolved => closed
2017-09-28 18:36aferrazFixed in Version => 3.0PR17Q4
2017-10-02 17:58hudsonbotCheckin
2017-10-02 17:58hudsonbotNote Added: 0099700

Notes
(0076107)
AtulOpenbravo   
2015-03-30 09:18   
(edited on: 2016-03-01 13:54)
Test Plan
1. Navigate "User Defined Accounting Report Setup" and create:
 - Node "a", set "summary level" = Yes
 - Node "b", set "summary level" = No
 - Node "c", set "summary level" = Yes
 - Node "d", set "summary level" = No
2. Go to Tree view and configure tree as:
 - Node b inside of node a
 - Node c inside of node a
 - Node d inside of node c
3. Delete node "c", which is defined as Summary level and contains node d

Check that OBException is raised as "You cannot delete this node because it has children nodes associated."

Check that it is possible to delete node d (not summary) and after that node c(summary)
(0077369)
hgbot   
2015-05-13 11:12   
Repository: erp/devel/pi
Changeset: e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 12 14:03:06 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e8bebe16d4bf675c41dc52a31fa6dc64a793ffbe [^]

Fixes Issue 29042:Should not be possible to delete a summary node in User
Defined Accounting Report Setup

After Delete part is added in AD_Accountingrpt_Element_Trg which checks
that whether there exists childs for the element being deleted.

---
M src-db/database/model/triggers/AD_ACCOUNTINGRPT_ELEMENT_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0077370)
umartirena   
2015-05-13 11:13   
Code Review + Testing OK
(0077404)
hudsonbot   
2015-05-13 17:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fd39a8e74d78 [^]
Maturity status: Test
(0078489)
maite   
2015-06-24 16:01   
Wrong error is shown in Oracle instead of proper message:

Error
ORA-04091: table ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT is mutating, trigger/function may not see it ORA-06512: at "ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT_TRG", line 99 ORA-04088: error during execution of trigger 'ERP_PI_ORACLE.AD_ACCOUNTINGRPT_ELEMENT_TRG'
(0078588)
hgbot   
2015-06-30 11:40   
Repository: erp/devel/pi
Changeset: 6241ce62712978814b01b2422aa34d0e58d75963
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Jun 30 11:40:10 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6241ce62712978814b01b2422aa34d0e58d75963 [^]

Related to issue 29042: Backout changeset e8bebe16d4bf

The reverted changeset creates a mutanting trigger in Oracle

---
M src-db/database/model/triggers/AD_ACCOUNTINGRPT_ELEMENT_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0078602)
hudsonbot   
2015-06-30 20:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a0fd6a76a3d5 [^]
Maturity status: Test
(0078917)
vmromanos   
2015-07-17 10:17   
This functionality can be easily implemented using the Node Deletion Policy = "Reparent Child Nodes" at Tables and Columns | Table Tree Category for the AD_AccountingRpt_Element table
(0084618)
psanjuan   
2016-03-01 12:58   
Issue Verified.
(0084621)
psanjuan   
2016-03-01 13:55   
Test plan verified in PostgreSQL.
(0099667)
hgbot   
2017-09-28 18:36   
Repository: erp/devel/pi
Changeset: e14398655b0f0a616951774dd93eef04d8e0929c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jul 28 17:10:05 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e14398655b0f0a616951774dd93eef04d8e0929c [^]

Fixes issue 29042: Shouldn't be possible to delete summary node in User Defined Accounting Report Setup

Implemented using Node Deletion Policy = "Do Not Allow If Has Children" at
Tables and Columns | Table Tree Category for the AD_AccountingRpt_Element
table

---
M src-db/database/sourcedata/AD_TABLE_TREE.xml
---
(0099668)
aferraz   
2017-09-28 18:36   
Code review + Testing OK
(0099700)
hudsonbot   
2017-10-02 17:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/44a89970274a [^]
Maturity status: Test