Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028977 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2015-02-18 10:43 | 2015-11-23 21:17 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 3fd452d82f35 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028977: NPE if property field can not reach the complete path | |||||||
| Description | When there is a property field which path can not be completed because there is a null object within it, a NPE is thrown when the tab containing it is opened. | |||||||
| Steps To Reproduce | As system admin role: * Create a new field in the Sales Invoice - Header tab * Add the following value in the Property field: businessPartner.priceList.name As group admin role: * Create a new record in the Sales Invoice window * Check the following error message is shown in the log 1f923ef8 357624 [http-8080-7] ERROR org.openbravo.client.application.window.FormInitializationComponent - Couldn't get data for column Name java.lang.NullPointerException at org.openbravo.dal.core.DalUtil.getValueFromPath(DalUtil.java:174) at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:625) at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:258) The problem is businessPartner is null, so it is trying to get priceList from a null object resulting in a NPE. | |||||||
| Proposed Solution | in this case the field property value should be null, without NPE in the logs | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0081800) hgbot (developer) 2015-11-13 08:44 |
Repository: erp/devel/pi Changeset: 3fd452d82f3582f226bc4c9c2d289c518a47ec68 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Fri Nov 13 08:43:20 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/3fd452d82f3582f226bc4c9c2d289c518a47ec68 [^] fixes issue 28977: NPE if property field can not reach the complete path The NPE was thrown when defining a property field in the header tab. The FIC is using the getValueFromPath() method to calculate the value of the property field on NEW mode. It is sending as parameter the reference to the parent record for the cases where the value of the property field can be retrieved using the parent information. As in the header tabs we do not have a reference to a parent record, the parameter is null in these cases. To solve the problem now we first check in getValueFromPath() method if the bob passed as parameter is null. In that case we return null in order to avoid the NPE. --- M src/org/openbravo/dal/core/DalUtil.java --- |
|
(0081825) alostale (manager) 2015-11-13 14:19 |
code reviewed tested: * Following steps to reproduce: new record * With same property path, removing price list for a BP that is used in invoice, show a record in Sales Invoice for that BP. 2nd case is not covered by current fix but by existent code: if (value instanceof BaseOBObject) { currentBob = (BaseOBObject) value; } else { return value; } when null 1st if is false |
|
(0082222) hudsonbot (developer) 2015-11-23 21:17 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-02-18 10:43 | alostale | New Issue | |
| 2015-02-18 10:43 | alostale | Assigned To | => AugustoMauch |
| 2015-02-18 10:43 | alostale | Modules | => Core |
| 2015-02-18 10:43 | alostale | Triggers an Emergency Pack | => No |
| 2015-02-18 10:43 | alostale | Relationship added | related to 0028438 |
| 2015-03-11 09:49 | alostale | Priority | normal => high |
| 2015-03-11 09:49 | alostale | Status | new => acknowledged |
| 2015-03-17 14:37 | alostale | Assigned To | AugustoMauch => platform |
| 2015-11-11 11:37 | alostale | Priority | high => normal |
| 2015-11-12 19:41 | caristu | Assigned To | platform => caristu |
| 2015-11-12 19:41 | caristu | Status | acknowledged => scheduled |
| 2015-11-13 08:44 | hgbot | Checkin | |
| 2015-11-13 08:44 | hgbot | Note Added: 0081800 | |
| 2015-11-13 08:44 | hgbot | Status | scheduled => resolved |
| 2015-11-13 08:44 | hgbot | Resolution | open => fixed |
| 2015-11-13 08:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3fd452d82f3582f226bc4c9c2d289c518a47ec68 [^] |
| 2015-11-13 08:46 | caristu | Relationship added | has duplicate 0031305 |
| 2015-11-13 08:48 | caristu | Relationship added | related to 0025754 |
| 2015-11-13 14:19 | alostale | Review Assigned To | => alostale |
| 2015-11-13 14:19 | alostale | Note Added: 0081825 | |
| 2015-11-13 14:19 | alostale | Status | resolved => closed |
| 2015-11-13 14:19 | alostale | Fixed in Version | => 3.0PR16Q1 |
| 2015-11-23 21:17 | hudsonbot | Checkin | |
| 2015-11-23 21:17 | hudsonbot | Note Added: 0082222 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |