Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028931
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2015-02-13 09:302016-06-17 19:37
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision78fd9bade67b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028931: Cannot add a payment from an invoice if the role does not have access to the organization of the document sequence

DescriptionCannot add a payment from an invoice if the role does not have access to the organization of the document sequence
Steps To ReproduceAs group admin role:
   Delete the '*', 'F&B España, S.A' and 'F&B International Group' from the 'F&B International Group Admin' role
   Create a Sales Invoice and complete it
   Click on Add Payment button
   Check the following error is raised:
      Organization B843C30461EA4501935CB1D125C9C25A of object (ADSequence(0BC1D46D77844119AAAC72636119BF43) (name: AR Receipt)) is not present in OrganizationList ...
   Go to Payment In window and check you could add a payment to the invoice
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0033043 closedmarkmm82 Permissions problem after process payment: role defined for an specific org (norte) is able to see data from sister orgs (sur) 

-  Notes
(0076566)
aferraz (manager)
2015-04-15 18:15

 Test plan:

As group admin role:
   Delete the '*', 'F&B España, S.A' and 'F&B International Group' from the 'F&B International Group Admin' role

Logout and login again:
   Create a Sales Invoice and complete it
   Click on Add Payment button
   Check the payment is created correctly
(0076567)
hgbot (developer)
2015-04-15 18:16

 Repository: erp/devel/pi
Changeset: 78fd9bade67beea0399977fcdc05fd267c4af8c4
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 12:22:10 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Fixes Issue 28931: Cannot add a payment from an invoice if the role does not
have access to the organization of the document sequence

Document sequence updation using add payment from invoice and add details from
payment in is done differently. In add payment from invoice OBDal checks org
access so doc seq organization is added explicitly using add writable
organization in OBContext and removed after work is done.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0076568)
aferraz (manager)
2015-04-15 18:17

 Code review + Testing OK
(0077130)
hudsonbot (developer)
2015-05-07 22:16

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0086824)
hgbot (developer)
2016-05-30 20:21

 Repository: erp/devel/pi
Changeset: 008b04a52b68e233ec58cd0440b951b1bb962205
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 12:53:49 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/008b04a52b68e233ec58cd0440b951b1bb962205 [^]

Fixes issue 33043: Permissions problems after process payment solved

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0086828)
hgbot (developer)
2016-05-30 21:21

 Repository: erp/backports/3.0PR16Q2
Changeset: 2c5ee42cc25845403e5df69e8ac274799d923d71
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 12:53:49 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/2c5ee42cc25845403e5df69e8ac274799d923d71 [^]

Fixed issue 33053: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0086831)
hgbot (developer)
2016-05-30 21:22

 Repository: erp/backports/3.0PR16Q1.3
Changeset: 56ff23f68667342d6dbc66eec2911979ba26cdb6
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 13:12:14 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.3/rev/56ff23f68667342d6dbc66eec2911979ba26cdb6 [^]

Fixed issue 33054: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0086834)
hgbot (developer)
2016-05-30 21:22

 Repository: erp/backports/3.0PR15Q4.7
Changeset: f38bc9208cdcd529ecd6f8f574df435cf08a690a
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 13:12:14 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.7/rev/f38bc9208cdcd529ecd6f8f574df435cf08a690a [^]

Fixed issue 33055: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0087575)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087576)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-02-13 09:30 ngarcia New Issue
2015-02-13 09:30 ngarcia Assigned To => Sandrahuguet
2015-02-13 09:30 ngarcia Modules => Core
2015-02-13 09:30 ngarcia Resolution time => 1426719600
2015-02-13 09:30 ngarcia Triggers an Emergency Pack => No
2015-02-13 09:30 ngarcia Issue Monitored: networkb
2015-02-26 07:33 AtulOpenbravo Assigned To Sandrahuguet => AtulOpenbravo
2015-02-26 07:33 AtulOpenbravo Status new => scheduled
2015-02-26 07:33 AtulOpenbravo fix_in_branch => pi
2015-03-02 08:05 AtulOpenbravo Review Assigned To => Sandrahuguet
2015-03-02 08:05 AtulOpenbravo fix_in_branch pi =>
2015-04-15 18:15 aferraz Note Added: 0076566
2015-04-15 18:16 hgbot Checkin
2015-04-15 18:16 hgbot Note Added: 0076567
2015-04-15 18:16 hgbot Status scheduled => resolved
2015-04-15 18:16 hgbot Resolution open => fixed
2015-04-15 18:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]
2015-04-15 18:17 aferraz Review Assigned To Sandrahuguet => aferraz
2015-04-15 18:17 aferraz Note Added: 0076568
2015-04-15 18:17 aferraz Status resolved => closed
2015-05-07 22:16 hudsonbot Checkin
2015-05-07 22:16 hudsonbot Note Added: 0077130
2016-05-25 17:23 aferraz Relationship added causes 0033043
2016-05-30 20:21 hgbot Checkin
2016-05-30 20:21 hgbot Note Added: 0086824
2016-05-30 21:21 hgbot Checkin
2016-05-30 21:21 hgbot Note Added: 0086828
2016-05-30 21:22 hgbot Checkin
2016-05-30 21:22 hgbot Note Added: 0086831
2016-05-30 21:22 hgbot Checkin
2016-05-30 21:22 hgbot Note Added: 0086834
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087575
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087576

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker