0028925: Refactor the cash management rate conversion to use the Currency API

Description

Refactor the cash management rate conversion to use the Currency Conversion API

Steps To Reproduce

Verify that in the 'cashmgmt-model.js' file, the amount and origamount are not using the Currency API:

amount: OB.DEC.mul(p.amount, p.rate),
origAmount: p.amount,

Proposed Solution

Close example can be found in 'cashup-model.js' lines 180-188

          var fromCurrencyId = auxPay.paymentMethod.currency;
          cashUpReport.get('deposits').push(new Backbone.Model({
            searchKey: p.get('searchKey'),
            origAmount: OB.UTIL.currency.toDefaultCurrency(fromCurrencyId, OB.DEC.add(p.get('totalDeposits'), p.get('totalSales'))),
            amount: OB.DEC.add(0, OB.DEC.add(p.get('totalDeposits'), p.get('totalSales'))),
            description: p.get('name'),
            isocode: auxPay.isocode,
            rate: p.get('rate')
          }));

The reason is that we need to centralize all currency conversion operations
- for easier maintenance
- because we have a precission bug that will be solved in a centralized way
- easier custom developments

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0028916

closed

guillermogil

Doing a cash management with a different currency than the original generates wrong data

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2015-02-12 13:56	Orekaria	New Issue
2015-02-12 13:56	Orekaria	Assigned To	=> marvintm
2015-02-12 13:56	Orekaria	OBNetwork customer	=> No
2015-02-12 13:56	Orekaria	Triggers an Emergency Pack	=> No
2015-02-12 13:56	Orekaria	Relationship added	blocks 0028916