0028925: Refactor the cash management rate conversion to use the Currency API

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028925

Retail Modules

Web POS

public

2015-02-12 13:56

Reporter

Orekaria

Assigned To

marvintm

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028925: Refactor the cash management rate conversion to use the Currency API

Description

Refactor the cash management rate conversion to use the Currency Conversion API

Steps To Reproduce

Verify that in the 'cashmgmt-model.js' file, the amount and origamount are not using the Currency API:

amount: OB.DEC.mul(p.amount, p.rate),
origAmount: p.amount,

Proposed Solution

Close example can be found in 'cashup-model.js' lines 180-188

          var fromCurrencyId = auxPay.paymentMethod.currency;
          cashUpReport.get('deposits').push(new Backbone.Model({
            searchKey: p.get('searchKey'),
            origAmount: OB.UTIL.currency.toDefaultCurrency(fromCurrencyId, OB.DEC.add(p.get('totalDeposits'), p.get('totalSales'))),
            amount: OB.DEC.add(0, OB.DEC.add(p.get('totalDeposits'), p.get('totalSales'))),
            description: p.get('name'),
            isocode: auxPay.isocode,
            rate: p.get('rate')
          }));

The reason is that we need to centralize all currency conversion operations
- for easier maintenance
- because we have a precission bug that will be solved in a centralized way
- easier custom developments

Additional Information