Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028868
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POScriticalsometimes2015-02-04 18:132015-08-28 12:25
ReporteradrianromeroView Statuspublic 
Assigned Tomarvintm 
PriorityimmediateResolutionfixedFixed in VersionRR15Q2
StatusclosedFix in branchFixed in SCM revisionacf88f4b5354
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression levelProduction - QA Approved
Regression date2015-01-29
Regression introduced in releaseRR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e297b3a1e623 [^]
Triggers an Emergency PackNo
Summary

0028868: Cascade taxes are not properly applied

DescriptionWhen there are cascade taxes, and there is a discount applied. Taxes sometimes are calculated wrongly.

For example a taxes cascade definition:
Summary tax: IEPS + IVA
First tax: IEPS 26%
Second tax: IVA 16%

Apply a discount.

The taxes calculation to fix for issue checks for the first tax in the tree. If this first tax is the summary tax, that usually has rate 0%, net will be calculated wrongly and as a consequence taxes too.
Steps To ReproduceIn description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0028610 closedmigueldejuana Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context  
related to defect 0029339 closedmigueldejuana Discounts are not properly calculated in Q1.1 of 2015 version 
related to defect 0029501RR15Q2 closedadrianromero [RR15Q2] At web POS, taxable & tax amount are wrongly calculated. 

-  Notes
(0074245)
hgbot (developer)
2015-02-06 11:25

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a9433c56a9b4fa1c34f24db8e4d74044f1b4e5b2
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 06 11:24:49 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9433c56a9b4fa1c34f24db8e4d74044f1b4e5b2 [^]

Fixes issue 0028868: Cascade taxes are not properly applied
Now line net is not calculated based on pricenet*quantity, this way rounding is avoided

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0074246)
adrianromero (manager)
2015-02-06 11:31

 The fix actually consists in two changesets:

1.- The backout of the changeset that makes this regression.
http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dafeeccc8ab7f41693186dff35b6b864c7e005f1 [^]
2.- The Fix
http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9433c56a9b4fa1c34f24db8e4d74044f1b4e5b2 [^]
(0074272)
hgbot (developer)
2015-02-09 10:26

 Repository: tools/automation/pi-mobile
Changeset: c5c8e3d41da1ad3a454ac7aef88cb2ef4fa21fa9
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Feb 09 10:26:14 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c5c8e3d41da1ad3a454ac7aef88cb2ef4fa21fa9 [^]

Related to issue 0028868: Cascade taxes are not properly applied
Changed tests with new values

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithOverpayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I26806_CashupTotalNotShown.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6780_FixedPercentageDiscount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleVerifyingFieldsII.java
---
(0074509)
migueldejuana (developer)
2015-02-16 13:40

 Tested and reviewed in a60c91b96139
(0075883)
hgbot (developer)
2015-03-23 16:04

 Repository: retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal
Changeset: fa0267bcbeb30de1d68d0de8dcd503f564a0acc1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Mar 23 16:04:24 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/fa0267bcbeb30de1d68d0de8dcd503f564a0acc1 [^]

Fixes issue 0028868: Cascade taxes are not properly applied
Now line net is not calculated based on pricenet*quantity, this way rounding is avoided

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0075935)
hgbot (developer)
2015-03-24 16:00

 Repository: retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal
Changeset: 88dff068c3e4942fd21396b0fd033e740386370e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 24 16:00:03 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/88dff068c3e4942fd21396b0fd033e740386370e [^]

Fixes issue 0028868: Cascade taxes are not properly applied
Now line net is not calculated based on pricenet*quantity, this way rounding is avoided

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0075942)
malsasua (developer)
2015-03-24 17:23

 verified in RR15Q1.2
(0078739)
hgbot (developer)
2015-07-08 09:48

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: acf88f4b5354a5bc85a53a66038596b24d42316a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 05 11:21:06 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acf88f4b5354a5bc85a53a66038596b24d42316a [^]

Fixes issue 0028868: Cascade taxes are not properly applied
Now line net is not calculated based on pricenet*quantity, this way rounding is avoided

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---

- Issue History
Date Modified Username Field Change
2015-02-04 18:13 adrianromero New Issue
2015-02-04 18:13 adrianromero Assigned To => marvintm
2015-02-04 18:13 adrianromero Regression level => Production - QA Approved
2015-02-04 18:13 adrianromero Regression introduced in release => RR15Q1
2015-02-04 18:13 adrianromero Triggers an Emergency Pack => No
2015-02-04 18:19 adrianromero Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e297b3a1e623 [^]
2015-02-04 18:19 adrianromero Priority normal => immediate
2015-02-04 18:19 adrianromero Description Updated View Revisions
2015-02-04 18:21 adrianromero Regression date => 2015-01-29
2015-02-04 18:22 adrianromero Relationship added caused by 0028610
2015-02-06 11:25 hgbot Checkin
2015-02-06 11:25 hgbot Note Added: 0074245
2015-02-06 11:26 hgbot Status new => resolved
2015-02-06 11:26 hgbot Resolution open => fixed
2015-02-06 11:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9433c56a9b4fa1c34f24db8e4d74044f1b4e5b2 [^]
2015-02-06 11:31 adrianromero Note Added: 0074246
2015-02-09 10:26 hgbot Checkin
2015-02-09 10:26 hgbot Note Added: 0074272
2015-02-16 13:40 migueldejuana Review Assigned To => migueldejuana
2015-02-16 13:40 migueldejuana Note Added: 0074509
2015-02-16 13:40 migueldejuana Status resolved => closed
2015-02-16 13:40 migueldejuana Fixed in Version => RR15Q2
2015-03-18 19:07 Orekaria Relationship added related to 0029339
2015-03-23 16:04 hgbot Checkin
2015-03-23 16:04 hgbot Note Added: 0075883
2015-03-23 16:04 hgbot Status closed => resolved
2015-03-23 16:04 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9433c56a9b4fa1c34f24db8e4d74044f1b4e5b2 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/fa0267bcbeb30de1d68d0de8dcd503f564a0acc1 [^]
2015-03-24 16:00 hgbot Checkin
2015-03-24 16:00 hgbot Note Added: 0075935
2015-03-24 16:00 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/fa0267bcbeb30de1d68d0de8dcd503f564a0acc1 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/88dff068c3e4942fd21396b0fd033e740386370e [^]
2015-03-24 17:23 malsasua Note Added: 0075942
2015-03-24 17:23 malsasua Status resolved => closed
2015-04-07 12:29 adrianromero Relationship added related to 0029501
2015-07-08 09:48 hgbot Checkin
2015-07-08 09:48 hgbot Note Added: 0078739
2015-07-08 09:48 hgbot Status closed => resolved
2015-07-08 09:48 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/88dff068c3e4942fd21396b0fd033e740386370e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acf88f4b5354a5bc85a53a66038596b24d42316a [^]
2015-08-28 12:25 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker