Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028693
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Approval process - onlinecriticalalways2015-01-20 13:582015-02-16 13:48
ReporterlorenzofidalgoView Statuspublic 
Assigned Toaaroncalero 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond01a26e86625
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028693: Approval process can be evaded following certain steps

DescriptionOnce approval is required, you can cancel that window, try to logout, cancel that and then you will be able to complete that receipt.
Steps To ReproduceCreate a new preference, for example, "Web POS Discretionary Discount Approval"
--
Log in ERP as System Admin
Go to Preferences window
Check for record with Property: Web POS Discretionary Discount Approval
if found then change the value to 'N"
If not found, then create a new record by entering new details
Client : System
Organization: *
Property List: Checked
Property: Web POS Discretionary Discount Approval
Value: N
Visible at client:
Visible at Organization:
Visible at User:
 

Log in ERP as Group -Admin-The White Valley Group
Go to Preferences window
Create a new proference:
Client : The White Valley Group
Organization: Vall Blanca Store
Property List: Checked
Property: Web POS Discretionary Discount Approval
Value: Y
Visible at client:The White Valley Group
Visible at Organization:Vall Blanca Store
Visible at User: Openbravo
--

Then set a discount to use that approval:
--
Log in ERP as Group -Admin-The White Valley Group
Go to Discounts and Promotions window
Create new record
Header tab
Discount type: Discretionary Fixed Percentage
Name: Discount 5%
Starting Date: 01-01-2012
Percentage Discount: 5.00
Included Roles: Only those defined
Role tab
VallBlancaUser
--
Now, go to POS Login screen and login as VallBlanca.
Create a line with any product, go to "Receipt discounts" at menu, set the just created discount to that line and apply that.
Try to complete the receipt and you will see that approval is required. Click cancel in that window.
Go to POS menu and click "Online" tab, click "End Session", check that now approval is avoided. In "Log Out" window, click Cancel.
Now click green "Tick" and click "Done". Receipt completed.


TagsNo tags attached.
Attached Filespng file icon ApprovalEvaded.png [^] (185,505 bytes) 2015-01-20 13:58

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0073771)
hgbot (developer)
2015-01-26 12:47

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9f6afe376ed505bed5162bd4a6a73347548e2168
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Jan 26 12:44:55 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9f6afe376ed505bed5162bd4a6a73347548e2168 [^]

Fixed issue 28693: Approval process can be evaded following certain steps

Added callbacks on rejected approvals (cancelled or missing supervisors) to efectively notify components that the approval has been rejected

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0073880)
migueldejuana (viewer)
2015-01-29 09:55

 Tested and reviewed in 932c019fa9c2
(0073986)
lorenzofidalgo (viewer)
2015-02-02 13:55

 There is another similar flow that let you also to avoid approval.
In "Steps To Reproduce", instead of:
--
"Try to complete the receipt and you will see that approval is required. Click cancel in that window."
--
Do the following:
--
"Try to complete the receipt and you will see that approval is required. Click outside the green approval window."
--
And continue following the cited steps.
(0074014)
hgbot (developer)
2015-02-03 10:17

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: fafa4f97032ecf5b38fb9a53e8899582ab2f4f30
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Feb 03 10:12:35 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fafa4f97032ecf5b38fb9a53e8899582ab2f4f30 [^]

Fixed issue 28693: Approval process can be evaded following certain steps

Implemented executeOnHide function to cover the case where the approval popup is dismissed by clicking outside

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0074021)
aaroncalero (viewer)
2015-02-03 13:08

 Reopened because the added executeOnHide function is preventing valid approvals.
(0074032)
hgbot (developer)
2015-02-03 15:34

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d01a26e866255454fa72ef80e4ae9f83596082a4
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Feb 03 15:31:08 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d01a26e866255454fa72ef80e4ae9f83596082a4 [^]

Fixed issue 28693: Approval process can be evaded following certain steps

Prevented the approval from being requested twice if the Approve button is tapped on the approval popup

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0074510)
migueldejuana (viewer)
2015-02-16 13:48

 Tested and reviewed in 3f936397a692

- Issue History
Date Modified Username Field Change
2015-01-20 13:58 lorenzofidalgo New Issue
2015-01-20 13:58 lorenzofidalgo Assigned To => marvintm
2015-01-20 13:58 lorenzofidalgo File Added: ApprovalEvaded.png
2015-01-20 13:58 lorenzofidalgo OBNetwork customer => No
2015-01-20 13:58 lorenzofidalgo Triggers an Emergency Pack => No
2015-01-20 14:06 plujan Priority immediate => urgent
2015-01-26 12:47 hgbot Checkin
2015-01-26 12:47 hgbot Note Added: 0073771
2015-01-26 12:47 hgbot Status new => resolved
2015-01-26 12:47 hgbot Resolution open => fixed
2015-01-26 12:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9f6afe376ed505bed5162bd4a6a73347548e2168 [^]
2015-01-26 12:47 aaroncalero Assigned To marvintm => aaroncalero
2015-01-29 09:55 migueldejuana Review Assigned To => migueldejuana
2015-01-29 09:55 migueldejuana Note Added: 0073880
2015-01-29 09:55 migueldejuana Status resolved => closed
2015-02-02 13:55 lorenzofidalgo Note Added: 0073986
2015-02-02 13:55 lorenzofidalgo Status closed => new
2015-02-02 13:55 lorenzofidalgo Resolution fixed => open
2015-02-03 10:17 hgbot Checkin
2015-02-03 10:17 hgbot Note Added: 0074014
2015-02-03 10:17 hgbot Status new => resolved
2015-02-03 10:17 hgbot Resolution open => fixed
2015-02-03 10:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9f6afe376ed505bed5162bd4a6a73347548e2168 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fafa4f97032ecf5b38fb9a53e8899582ab2f4f30 [^]
2015-02-03 13:08 aaroncalero Note Added: 0074021
2015-02-03 13:08 aaroncalero Status resolved => new
2015-02-03 13:08 aaroncalero Resolution fixed => open
2015-02-03 15:34 hgbot Checkin
2015-02-03 15:34 hgbot Note Added: 0074032
2015-02-03 15:34 hgbot Status new => resolved
2015-02-03 15:34 hgbot Resolution open => fixed
2015-02-03 15:34 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fafa4f97032ecf5b38fb9a53e8899582ab2f4f30 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d01a26e866255454fa72ef80e4ae9f83596082a4 [^]
2015-02-16 13:48 migueldejuana Note Added: 0074510
2015-02-16 13:48 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker