Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028640
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2015-01-16 10:352015-02-04 20:34
ReporterngarciaView Statuspublic 
Assigned Toumartirena 
PriorityurgentResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revisiond4a038cf2708
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028640: Reservation line is duplicated if it is already released and it is selected when managing it from Sales Order window

DescriptionReservation line is duplicated if it is already released and it is selected when managing it from Sales Order window
Steps To ReproduceAs group admin role:
   Create a Sales Order
   Add 10 units of Zumo de Naranja Bio 0.33L
   Book it
   Click on Manage Reservation and Done
   Click again and reduce the reserved quantity (4 units)
   Select a reservation line with a different attribute set and add a quantity less than the pending quantity (2 units)
   Create a Goods shipment with the same attribute set and quantity (4 units) than the first reservation line and complete it
   Return to the Sales Order, click on the Manage Reservation and increase the quantity of the second line without unmarking the already released one
   Check a new reservation line of 4 units is created
   
Note: You should unselect the released line not to duplicate it. The problem is not reproduced from the Stock Reservation window
   
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0073726)
hgbot (developer)
2015-01-22 17:05

Repository: erp/devel/pi
Changeset: d4a038cf2708b1e64c68b9f9a0015e0d419126a1
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Jan 22 17:05:07 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d4a038cf2708b1e64c68b9f9a0015e0d419126a1 [^]

Fixes bug 28640:Res. line with amt released not duplicated in Manage Reservation

The problem is that when opening Manage Reservations P&E from sales order line, the property 'reservationStock' comes blank, even when a reservation stock line exists (When there is no reservation for the sales orderline a temporary one is created just to display lines in the selector selected correctly, and after that is deleted. This happens in the datasource of the P&E). In this cases the Manage Reservations action handler deletes these lines y they exists and creates new ones. But this is not possible for already released lines, so it was creating a duplicate of those.

In order to fix this, the property 'id' is used (allways comes with a value) in the case that the reservation is released, because in this case for sure that the reservation stock line exists, so it will update the existing one instead of creating a new one.

---
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0073849)
Sandrahuguet (developer)
2015-01-28 10:21

Code review + testing OK
(0074173)
hudsonbot (developer)
2015-02-04 20:34

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-01-16 10:35 ngarcia New Issue
2015-01-16 10:35 ngarcia Assigned To => Sandrahuguet
2015-01-16 10:35 ngarcia Modules => Core
2015-01-16 10:35 ngarcia Resolution time => 1424300400
2015-01-16 10:35 ngarcia Triggers an Emergency Pack => No
2015-01-16 10:36 ngarcia Steps to Reproduce Updated View Revisions
2015-01-22 13:05 umartirena Assigned To Sandrahuguet => umartirena
2015-01-22 17:05 hgbot Checkin
2015-01-22 17:05 hgbot Note Added: 0073726
2015-01-22 17:05 hgbot Status new => resolved
2015-01-22 17:05 hgbot Resolution open => fixed
2015-01-22 17:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d4a038cf2708b1e64c68b9f9a0015e0d419126a1 [^]
2015-01-22 17:08 umartirena Review Assigned To => Sandrahuguet
2015-01-28 10:21 Sandrahuguet Note Added: 0073849
2015-01-28 10:21 Sandrahuguet Status resolved => closed
2015-01-28 10:21 Sandrahuguet Fixed in Version => 3.0PR15Q2
2015-02-04 20:34 hudsonbot Checkin
2015-02-04 20:34 hudsonbot Note Added: 0074173


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker