Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028513
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminoralways2015-01-02 11:172015-05-07 22:17
ReporterngarciaView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision7b24a42b4b25
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toumartirena
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028513: Error message wrongly shown when processing an inventory with a product with % in its name and negative stock

DescriptionError message wrongly shown when processing an inventory with a product with % in its name and negative stock
Steps To ReproduceAs group admin role:
   Check the Client does not allow negative stock
   Create a new product whose name contains a '%'
   Create two Goods Receipts for that product to different storage bins
   Update from the database the qtyonhand value of one of the records in the m_storage_detail table with a negative value
   Create a physical inventory for that product and increase the stock in the storage bin with positive stock
   Try to process it and check you get the following error:
      Conversion = '''
Proposed SolutionIn InventoryCountProcess.checkStock function, an exception is launched when trying to format the error message
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0074990)
jorge-garcia (reporter)
2015-02-26 18:24

Test Plan

As group admin role:
   Check the Client does not allow negative stock.
   Create a new product whose name contains a '%'.
   Create two Goods Receipts for that product to different storage bins.
   Update from the database the qtyonhand value of one of the records in the m_storage_detail table with a negative value.
   Create a physical inventory for that product and increase the stock in the storage bin with positive stock.
   Process it and check you get correct message of the product, UOM and storage bin from the storage bin with negative stock
(0076872)
hgbot (developer)
2015-04-29 12:43

Repository: erp/devel/pi
Changeset: 7b24a42b4b251f43154dc00a869c86da93606fc5
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Feb 26 17:46:48 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b24a42b4b251f43154dc00a869c86da93606fc5 [^]

Fixed issue 28513: Error message wrongly shown when processing an inventory.

The error message when processing an inventory is wrongly shown with a product
with % in its name and a negative stock.

The issue occurs when we are parsing the error message and detects the % symbol
and try to find the string format in the next character.

The proposal solution is to eliminate the String.format() method from the
code.

Now, the error message is shown properly with the correct name.

---
M src/org/openbravo/materialmgmt/InventoryCountProcess.java
---
(0076873)
umartirena (reporter)
2015-04-29 12:43

Code Review + Testing OK
(0077183)
hudsonbot (developer)
2015-05-07 22:17

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-01-02 11:17 ngarcia New Issue
2015-01-02 11:17 ngarcia Assigned To => AtulOpenbravo
2015-01-02 11:17 ngarcia Modules => Core
2015-01-02 11:17 ngarcia Resolution time => 1426633200
2015-01-02 11:17 ngarcia Triggers an Emergency Pack => No
2015-01-02 11:18 ngarcia Issue Monitored: networkb
2015-01-13 18:55 ngarcia Target Version => 3.0PR15Q2
2015-02-23 13:30 jonalegriaesarte Target Version 3.0PR15Q2 => 3.0PR15Q3
2015-02-23 15:38 Sandrahuguet Assigned To AtulOpenbravo => jorge-garcia
2015-02-26 18:24 jorge-garcia Note Added: 0074990
2015-03-09 17:27 jonalegriaesarte Resolution time 1426633200 =>
2015-03-11 13:26 ngarcia Target Version 3.0PR15Q3 =>
2015-03-25 09:38 jorge-garcia Status new => scheduled
2015-04-29 12:43 hgbot Checkin
2015-04-29 12:43 hgbot Note Added: 0076872
2015-04-29 12:43 hgbot Status scheduled => resolved
2015-04-29 12:43 hgbot Resolution open => fixed
2015-04-29 12:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b24a42b4b251f43154dc00a869c86da93606fc5 [^]
2015-04-29 12:43 umartirena Review Assigned To => umartirena
2015-04-29 12:43 umartirena Note Added: 0076873
2015-04-29 12:43 umartirena Status resolved => closed
2015-04-29 12:44 umartirena Fixed in Version => pi
2015-05-07 22:17 hudsonbot Checkin
2015-05-07 22:17 hudsonbot Note Added: 0077183


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker