Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028505
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2014-12-31 10:192015-02-04 20:33
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in Version3.0PR15Q1
StatusclosedFix in branchFixed in SCM revision2722f629170e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028505: Document Number field has different length in grid and form view

DescriptionThe document number field of the header tab of the Sales Order window has a differente length in the form view (30) and in the grid view (20). The length of the documentno column in the c_order table is 30.

This disparity is a problem when a record with a document number longer than 30 characters is edited in grid view, because only its first 20 characters will be saved
Steps To ReproduceAs F&B Admin:
- Open the Sales Order window
- Create a new record in form view and save.
- Modify the document number of the record and set this: 012345678901234567890123456789 (30 characters).
- Save the record and go back to the grid view.
- Edit the record in grid view. See that only the first 20 characters are shown. Modify any other field and save. See that the document number has been truncated without you modifying it.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0073285)
AugustoMauch (administrator)
2014-12-31 10:19
edited on: 2014-12-31 10:20

 This is the document number field definition included in the view definition:

{name:'documentNo',id:'1081',title:'Document No.',required:true,columnName:'DocumentNo',inpColumnName:'inpdocumentno',"length":30,gridProps:{sort:2,showHover:true,length:20,displaylength:10},type:'_id_10'}

See that the field length is 30 in the form view but 20 in the grid view.
(0073288)
AugustoMauch (administrator)
2014-12-31 12:32

 Problem caused in this changeset [1], that hardcodes the document number grid length to 20

[1] https://code.openbravo.com/erp/devel/pi/rev/ae5c327c567f#l3.14 [^]
(0073324)
AugustoMauch (administrator)
2015-01-07 10:27

 Updated to minor since it only happens in the Document Number field, and it has been working that way since the beginning of Openbravo 3.0
(0073329)
hgbot (developer)
2015-01-07 12:54

 Repository: erp/devel/pi
Changeset: 2722f629170e8d1426ebc21dfe5dbfef57508274
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jan 07 12:42:34 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2722f629170e8d1426ebc21dfe5dbfef57508274 [^]

Fixes issue 28505: Document number field length is not always hardcoded to 20

In this changeset [1], that was included in the first release of Openbravo 3.0, the length of the document number field length for the grids is hardcoded to 20. The length of the form field is taken from the length of the column in the application dictionary.

Having a different length in the grid and form fields resulted in the value of the field being truncated when it is edited in the view with the shortest length. It is not possible to remove the hardcoded code because it is possible that some Openbravo instances depend on it (i.e. if the length of the document number column is set to 0). In order to fix this issue, now the hardcoded code only affects the fields whose length is 0. For all the other cases, the length of the grid field will be taken from the length of the column.

[1] https://code.openbravo.com/erp/devel/pi/rev/ae5c327c567f#l3.14 [^]

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java
---
(0073414)
alostale (viewer)
2015-01-12 12:08

 code reviewed

tested
(0074117)
hudsonbot (viewer)
2015-02-04 20:33

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-12-31 10:19 AugustoMauch New Issue
2014-12-31 10:19 AugustoMauch Assigned To => AugustoMauch
2014-12-31 10:19 AugustoMauch OBNetwork customer => No
2014-12-31 10:19 AugustoMauch Modules => Core
2014-12-31 10:19 AugustoMauch Triggers an Emergency Pack => No
2014-12-31 10:19 AugustoMauch Note Added: 0073285
2014-12-31 10:20 AugustoMauch Note Edited: 0073285 View Revisions
2014-12-31 10:21 AugustoMauch OBNetwork customer No => Yes
2014-12-31 10:21 AugustoMauch Resolution time => 1421794800
2014-12-31 12:32 AugustoMauch Note Added: 0073288
2014-12-31 13:59 daniOpenbravo Issue Monitored: daniOpenbravo
2014-12-31 13:59 daniOpenbravo Issue Monitored: malsasua
2015-01-07 10:27 AugustoMauch Note Added: 0073324
2015-01-07 10:27 AugustoMauch Severity major => minor
2015-01-07 12:42 AugustoMauch Issue Monitored: alostale
2015-01-07 12:54 AugustoMauch Review Assigned To => alostale
2015-01-07 12:54 hgbot Checkin
2015-01-07 12:54 hgbot Note Added: 0073329
2015-01-07 12:54 hgbot Status new => resolved
2015-01-07 12:54 hgbot Resolution open => fixed
2015-01-07 12:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2722f629170e8d1426ebc21dfe5dbfef57508274 [^]
2015-01-12 12:08 alostale Note Added: 0073414
2015-01-12 12:08 alostale Status resolved => closed
2015-01-12 12:08 alostale Fixed in Version => 3.0PR15Q1
2015-02-04 20:33 hudsonbot Checkin
2015-02-04 20:33 hudsonbot Note Added: 0074117

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker