Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028314 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Discounts and Promotions | major | always | 2014-11-28 10:02 | 2015-01-15 18:55 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | mario_castello | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | pi | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | e12ef207a022 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | Orekaria | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028314: discounts can be applied to paid receipts | |||||||
| Description | If the old flow of discounts is activated, you can apply discounts to paid orders | |||||||
| Steps To Reproduce | . activate old flow discount: . in the backend, change the property OBPOS_new flow discount to false; . in POS . load a paid ordered . apply a discretionary discount | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  issueDiscounts.png [^] (276,355 bytes) 2014-11-28 10:02 Selection_017.png [^] (351,367 bytes) 2014-12-13 00:37 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0072289) hgbot (developer) 2014-12-04 20:43 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4c3cce0cd07f7807c944bf98c45905e2e11cee75 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Thu Dec 04 13:42:48 2014 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4c3cce0cd07f7807c944bf98c45905e2e11cee75 [^] fixed issue 28314: discounts can be applied to paid receipts --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0072465) mtaal (manager) 2014-12-13 00:39 |
When reviewing, I can still somehow open the discount dialog, the apply button is enabled. The discount is not really applied, when you press the apply button no discount is applied. So I think it is better to not show the discount dialog in the top if the order is not editable. So maybe better to show the not-editable message when clicking the discount button. gr. Martin |
|
(0073339) hgbot (developer) 2015-01-07 17:51 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3b2f423d11b98125330cb879c0e821fffb5e594f Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed Jan 07 10:50:05 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b2f423d11b98125330cb879c0e821fffb5e594f [^] fixed issue 28314: discounts can be applied to paid receipts --- M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js --- |
|
(0073425) Orekaria (administrator) 2015-01-12 13:48 |
Tested in livebuilds - Discounts are not applied - but I cannot see any message poping neither with or without the new discounts flow BTW, if discounts cannot be applied (non editable receipt), we should not show the menu entry |
|
(0073501) hgbot (developer) 2015-01-14 17:49 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 7c9d6a0657f35ddf20d5617ca45e4852a43a88ec Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed Jan 14 10:47:44 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c9d6a0657f35ddf20d5617ca45e4852a43a88ec [^] fixed issue 28314: Disable the menu entry --- M web/org.openbravo.retail.posterminal/js/components/menu.js --- |
|
(0073516) Orekaria (administrator) 2015-01-15 12:28 |
There is a use case in which the 'Receipt discounts' menu entry should be active and is not active: 1- log in 1- add a product to the receipt verify that the menu entry is enabled 2- retrieve an existing receipt. verify that 2 tickets are present verify that the menu entry is disabled 3- delete the retrieved receipt 4- the first receipt is shown, verify that the menu entry is disabled (INCORRECT) |
|
(0073529) hgbot (developer) 2015-01-15 17:00 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e12ef207a022a73f040402ab61ee8638b41bc4ef Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Thu Jan 15 09:59:17 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12ef207a022a73f040402ab61ee8638b41bc4ef [^] fixed issue 28314: Validate menu entry when change the order --- M web/org.openbravo.retail.posterminal/js/components/menu.js --- |
|
(0073546) hgbot (developer) 2015-01-15 18:55 |
Repository: tools/automation/pi-mobile Changeset: d3a2619a7fa828f280a7a678922355891b219d26 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Thu Jan 15 13:02:45 2015 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d3a2619a7fa828f280a7a678922355891b219d26 [^] Related to issue 28314: Added test 'I28314_ReceiptDiscountsMenuEntryVisibility' * * * Finished the 'I28314_ReceiptDiscountsMenuEntryVisibility' test --- M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/ReceiptSuite.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I28314_ReceiptDiscountsMenuEntryVisibility.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-11-28 10:02 | malsasua | New Issue | |
| 2014-11-28 10:02 | malsasua | Assigned To | => marvintm |
| 2014-11-28 10:02 | malsasua | File Added: issueDiscounts.png | |
| 2014-11-28 10:02 | malsasua | Triggers an Emergency Pack | => No |
| 2014-12-04 20:43 | hgbot | Checkin | |
| 2014-12-04 20:43 | hgbot | Note Added: 0072289 | |
| 2014-12-04 20:43 | hgbot | Status | new => resolved |
| 2014-12-04 20:43 | hgbot | Resolution | open => fixed |
| 2014-12-04 20:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4c3cce0cd07f7807c944bf98c45905e2e11cee75 [^] |
| 2014-12-13 00:37 | mtaal | File Added: Selection_017.png | |
| 2014-12-13 00:39 | mtaal | Note Added: 0072465 | |
| 2014-12-13 00:39 | mtaal | Status | resolved => new |
| 2014-12-13 00:39 | mtaal | Resolution | fixed => open |
| 2015-01-07 15:06 | mario_castello | Assigned To | marvintm => mario_castello |
| 2015-01-07 15:06 | mario_castello | Status | new => scheduled |
| 2015-01-07 15:06 | mario_castello | fix_in_branch | => pi |
| 2015-01-07 17:51 | hgbot | Checkin | |
| 2015-01-07 17:51 | hgbot | Note Added: 0073339 | |
| 2015-01-07 17:51 | hgbot | Status | scheduled => resolved |
| 2015-01-07 17:51 | hgbot | Resolution | open => fixed |
| 2015-01-07 17:51 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4c3cce0cd07f7807c944bf98c45905e2e11cee75 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b2f423d11b98125330cb879c0e821fffb5e594f [^] |
| 2015-01-12 13:48 | Orekaria | Assigned To | mario_castello => Orekaria |
| 2015-01-12 13:48 | Orekaria | Note Added: 0073425 | |
| 2015-01-12 13:48 | Orekaria | Status | resolved => new |
| 2015-01-12 13:48 | Orekaria | Resolution | fixed => open |
| 2015-01-14 17:09 | mario_castello | Assigned To | Orekaria => mario_castello |
| 2015-01-14 17:09 | mario_castello | Status | new => scheduled |
| 2015-01-14 17:49 | hgbot | Checkin | |
| 2015-01-14 17:49 | hgbot | Note Added: 0073501 | |
| 2015-01-14 17:49 | hgbot | Status | scheduled => resolved |
| 2015-01-14 17:49 | hgbot | Resolution | open => fixed |
| 2015-01-14 17:49 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b2f423d11b98125330cb879c0e821fffb5e594f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c9d6a0657f35ddf20d5617ca45e4852a43a88ec [^] |
| 2015-01-15 12:28 | Orekaria | Note Added: 0073516 | |
| 2015-01-15 12:28 | Orekaria | Status | resolved => new |
| 2015-01-15 12:28 | Orekaria | Resolution | fixed => open |
| 2015-01-15 17:00 | hgbot | Checkin | |
| 2015-01-15 17:00 | hgbot | Note Added: 0073529 | |
| 2015-01-15 17:00 | hgbot | Status | new => resolved |
| 2015-01-15 17:00 | hgbot | Resolution | open => fixed |
| 2015-01-15 17:00 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c9d6a0657f35ddf20d5617ca45e4852a43a88ec [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12ef207a022a73f040402ab61ee8638b41bc4ef [^] |
| 2015-01-15 18:32 | Orekaria | Review Assigned To | => Orekaria |
| 2015-01-15 18:32 | Orekaria | Status | resolved => closed |
| 2015-01-15 18:32 | Orekaria | Fixed in Version | => pi |
| 2015-01-15 18:55 | hgbot | Checkin | |
| 2015-01-15 18:55 | hgbot | Note Added: 0073546 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |