Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028126
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Modules] Warehouse Pickingmajorhave not tried2014-11-10 10:122015-05-27 18:43
ReporterjonalegriaesarteView Statuspublic 
Assigned ToTriage Omni WMS 
PriorityimmediateResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision383009869420
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Toeduardo_Argal
Regression introduced in release
Summary

0028126: The field 'isinpickinglist' of Sales orders which generates a outbound picking list is set to false when picking list is complet

DescriptionThe field 'isinpickinglist' of Sales orders which generates a outbound picking list is set to false when picking list is completed
Steps To ReproduceCreate a outbound picking list
Check that field "is in picking list" is set to true
Complete the picking list
Check that the field which before was set to false now is true

At this moment the user can generate a new picking list using the same orders used in the previous one.

Other issue:
I have the following stock:
prod a -- att A -> 5
prod b -> att B -> 2

I generate a sales order for:
4 units of A -> reservation as automatic
4 units of B -> reservation as automatic

When I book the order everything is OK, but the reservation for the 2nd line is 2.

Then I generate the picking list.
ERROR 1: No message appear saying that not every units has been included in the picking.
ERROR 2: No message appear saying that picking list has been generated

If I check the picking list I realize that picking list has been generated with the following lines:
4 units of A
2 units of B
Proposed SolutionThe problem is caused by the line which I comment in the following piece of code. I dn't know why it is there, but for outbound picking doesn't make
sense.

diff -r c261c64e1eb1 src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java
--- a/src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java Fri Nov 07 09:40:07 2014 +0530
+++ b/src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java Fri Nov 07 17:11:50 2014 +0530
@@ -129,7 +129,7 @@
orders.add(mvmtLine.getStockReservation().getSalesOrderLine().getSalesOrder());
}
for (Order order : orders) {
- order.setObwplIsinpickinglist(false);
+ //order.setObwplIsinpickinglist(false);
for (Bean<?> abstractBean : beansList) {
ClosePLOutbound_ProcessOrdersHook hook = (ClosePLOutbound_ProcessOrdersHook) WeldUtils
.getStaticInstanceBeanManager().getReference(abstractBean,
TagsNo tags attached.
Attached Filesdiff file icon diffIssuePicking.diff [^] (767 bytes) 2014-11-10 10:12 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
causes defect 0029918 closedAtulOpenbravo Cannot generate a new picking list if the order was partially included in an outbound picking list 

-  Notes
(0076717)
hgbot (developer)
2015-04-23 12:59

Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 383009869420cff56933fa8bd703df87585cb4e4
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 13 21:39:16 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/383009869420cff56933fa8bd703df87585cb4e4 [^]

Fixes Issue 28126:Field 'isinpickinglist' of Sales orders which generates a
outbound picking list is set to false when picking list is complete

Problem is while closing picking list, sales orders are set as
isinpickinglist=No

---
M src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java
---
(0076718)
eduardo_Argal (developer)
2015-04-23 13:00

Code Review done.

scenario tested and working fine. On regards of message when quantity exceeds stock, we have a message when generating picking:
'Picking List created successfully
OPL1019
There is not enough stock in warehouses to create the whole Picking List. : [OPL1019]'
(0077801)
umartirena (reporter)
2015-05-27 12:43

Issue reopened because it causes regression 29918.

The original solution of the issue 28126 it is going to be redesigned. It has to be implemented a solution to be able to know on each moment which goods of a sales order are being managed on a Warehouse Picking List previous to release the Goods Shipment of the Order.

It could be added to the order line a column "Qty in picking list" (Just an idea).
(0077802)
umartirena (reporter)
2015-05-27 12:44

Issue moved to design defect to implement a new functionality.
(0077835)
hgbot (developer)
2015-05-27 18:43

Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: a064bf4524af92ac918ea25c555b9158cdc6bd5b
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed May 27 12:39:18 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/a064bf4524af92ac918ea25c555b9158cdc6bd5b [^]

Related to bug 28126: Backout changeset 383009869420

The changeset has been backed out because it causes the regression 29918. The solution of issue 28126 is going to be redesigned, allowing properly to create Outbound Picking Lists for pending quantity to be added in a picking list.

---
M src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java
---

- Issue History
Date Modified Username Field Change
2014-11-10 10:12 jonalegriaesarte New Issue
2014-11-10 10:12 jonalegriaesarte Assigned To => naiaramartinez
2014-11-10 10:12 jonalegriaesarte File Added: diffIssuePicking.diff
2014-11-10 10:12 jonalegriaesarte Resolution time => 1415660400
2014-11-10 10:13 jonalegriaesarte Assigned To naiaramartinez => AtulOpenbravo
2014-11-10 10:13 jonalegriaesarte Priority normal => immediate
2015-01-13 12:18 AtulOpenbravo Status new => scheduled
2015-01-13 12:18 AtulOpenbravo fix_in_branch => pi
2015-04-23 12:59 hgbot Checkin
2015-04-23 12:59 hgbot Note Added: 0076717
2015-04-23 12:59 hgbot Status scheduled => resolved
2015-04-23 12:59 hgbot Resolution open => fixed
2015-04-23 12:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/383009869420cff56933fa8bd703df87585cb4e4 [^]
2015-04-23 13:00 eduardo_Argal Review Assigned To => eduardo_Argal
2015-04-23 13:00 eduardo_Argal Note Added: 0076718
2015-04-23 13:00 eduardo_Argal Status resolved => closed
2015-05-18 17:57 ngarcia Relationship added causes 0029918
2015-05-27 12:43 umartirena Assigned To AtulOpenbravo => Triage Finance
2015-05-27 12:43 umartirena Note Added: 0077801
2015-05-27 12:43 umartirena Status closed => new
2015-05-27 12:43 umartirena Resolution fixed => open
2015-05-27 12:44 umartirena Note Added: 0077802
2015-05-27 12:44 umartirena Type defect => design defect
2015-05-27 12:44 umartirena fix_in_branch pi =>
2015-05-27 18:43 hgbot Checkin
2015-05-27 18:43 hgbot Note Added: 0077835


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker