0028114: [Costing] Remove cost re-calculation related to output transactions such as shipments.

Description

[Costing] Remove cost re-calculation related to output transactions such as shipments.

Steps To Reproduce

In QA testing client go to Product window.
Create a new product named Costing V11. Select a purchase price list and enter a unit/list price of 20.00

Go to purchase order window and create a new one dated on 6/11/2014. Enter product Costing V11. Enter 100 units. Net Unit Price 20.00. Book the order.

Go to purchase order window and create a new one dated on 15/11/2014. Enter product Costing V11. Enter 200 units. Change Net Unit Price to 15.00. Book the order.

Go to Goods Receipt window and create a new one dated on 20/11/2014. Select two orders created above by using process button "Create Lines From". Complete the receipt.

Go to process request window and run costing background process.

Go back to Goods Receipt window and post it. Realize that value posted is 5000.00 (300 units + 16.67 €/unit).

Go to Product window, search by the product and navigate to Costing tab.
Realize that there are two cost related lines:

Line 1 - related to 200 units - Cost 15
Line 2 - related to 100 units - Cost 16.67 - total move qty 300 - ending date 31-12-9999

Go to Goods shipment and create a new one dated on 25/11/2014. Select the product and ship 150 units. Complete the shipment.

Go to process request window and run costing background process.

Go back to Goods Shipment window and post it. Realize that value posted is 2500.50 (150 units + 16.67 €/unit).

Go to purchase invoice window and create a new one based dated on 22/11/2014 for the first purchase order. Realize that 100 units are shown. Change the price from 20 to 25.00 €
Complete and post the invoice.

Go to process request window and run price correction background process.

Go to Product window, search by the product and navigate to Costing tab.
Realize that there are three cost related lines:

Line 1 - related to 200 units and Vendor receipt - Cost 15
Line 2 - related to 100 units and Vendor receipt - Cost 18.33 - total move qty 300
Line 3 - empty - Cost 18.34 - total mov qty 150 - Ending date 31-12-9999

This is not correct. Correct should be:
Line 1 - related to 200 units and Vendor receipt - Cost 15
Line 2 - related to 100 units and Vendor receipt - Cost 18.33 - total move qty 300 - Ending date 31-12-9999

Once more create a second purchase invoice for second purchase order dated on 24/11/2014. Realize that 200 units are shown. Change the price from 15.00 to 20.00. Complete and post the invoice.

Go to process request window and run price correction background process.

Go to Product window, search by the product and navigate to Costing tab.
Realize that there are four cost related lines:

Line 1 - related to 200 units and Vendor receipt - Cost 20
Line 2 - related to 100 units and Vendor receipt - Cost 21.67 - total move qty 300
Line 3 - empty - Cost 18.34 - total mov qty 150
Line 4 - empty - Cost 21.66 - total mov qty 150 - ending date 31-12-9999

This is not correct. Correct should be:

Line 1 - related to 200 units and Vendor receipt - Cost 20
Line 2 - related to 100 units and Vendor receipt - Cost 21.67 - total move qty 300

Proposed Solution

see steps to reproduce.

In summary, product transaction cost recalculation should not take care whenever last product transaction is an output transaction (shipment), therefore those empty inventory transactions are not created.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0071501) hgbot (developer) 2014-11-07 13:36	Repository: erp/devel/pi Changeset: 90b35b04c6afabfba28c6a03d5a95c1f2341c3ba Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Fri Nov 07 13:36:16 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/90b35b04c6afabfba28c6a03d5a95c1f2341c3ba [^] Fixes Issue 28114: Remove cost re-calculation related to output transactions The cost recalculation related to adjustments on output transactions has been removed because it was causing amounts rounding issues and because of this extra records in Costing tab were being created. This recalculation was being doing because of reported issue 28019. --- M src/org/openbravo/costing/AverageCostAdjustment.java ---

(0071504) psanjuan (viewer) 2014-11-07 15:07	Verified. See excel sheet below: https://docs.google.com/a/openbravo.com/spreadsheets/d/1Ilm1oct0vH4iKFlI1I0VbmYM-r8fdo1moK02jd2Zigg/edit#gid=1025660841 [^] Product: Costing 28114

(0073029) hudsonbot (viewer) 2014-12-30 23:24	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2014-11-06 18:09	psanjuan	New Issue
2014-11-06 18:09	psanjuan	Assigned To	=> dmiguelez
2014-11-06 18:09	psanjuan	OBNetwork customer	=> No
2014-11-06 18:09	psanjuan	Modules	=> Core
2014-11-06 18:09	psanjuan	Triggers an Emergency Pack	=> No
2014-11-07 09:19	psanjuan	Assigned To	dmiguelez => umartirena
2014-11-07 09:19	psanjuan	Steps to Reproduce Updated	View Revisions
2014-11-07 09:19	psanjuan	Proposed Solution updated
2014-11-07 13:36	hgbot	Checkin
2014-11-07 13:36	hgbot	Note Added: 0071501
2014-11-07 13:36	hgbot	Status	new => resolved
2014-11-07 13:36	hgbot	Resolution	open => fixed
2014-11-07 13:36	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/90b35b04c6afabfba28c6a03d5a95c1f2341c3ba [^]
2014-11-07 15:07	psanjuan	Note Added: 0071504
2014-11-07 15:07	psanjuan	Status	resolved => closed
2014-12-30 23:24	hudsonbot	Checkin
2014-12-30 23:24	hudsonbot	Note Added: 0073029