0027836: On the backend, Quantity field is not overridden by making it a Gift Product

Description

When using the "Buy X and get Y as gift" promotion type, if I choose a product and I assign a quantity before checking the "Gift product" option, this value keeps counting even if the field is hidden.
So the discount will not be properly calculated until the user unchecks the Gift Product option, clears the field and checks it again.

Steps To Reproduce

1. Log in the backend as Group -Admin-The White Valley Group
2. Go to Discounts and Promotions window
3. Create new record
4. On Header tab
- Discount type: Buy X and get Y as gift
- Name: free wax
- Starting date: 01-01-2012
- Products: Only those defined
5. On Products tab
- Create a new line:
   - Product: All mountain ski board
   - Quantity 1
- Create a second line:
   - Ski wax
   - Quantity 1
   - Gift product: yes
   - Gift Quantity: 1
6. Note that when marking "Gift product" check, "Quantity" field disappears.
7. Use the promotion by logging in at the Frontend
8. Add 1 All mountain ski board and 1 Ski wax. Check that no discount is shown although it should.
9. Add 1 extra ski wax. Check that the discount is shown.
10. Return to the record created on step 5. Uncheck the Gift Product field for the Wax and check that Quantity still keeps the 1 value set before.
11. Delete this value, check the Gift Product again and repeat steps 7 to 9. Note that now the first wax gets the discount while the second does not, and that is the expected behaviour.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0071288) hgbot (developer) 2014-10-31 02:57	Repository: erp/pmods/org.openbravo.retail.discounts Changeset: 169f5d96a5724fcb96686cdd1400cf9394813280 Author: Salvador Zapata <salvador.zapata <at> gmail.com> Date: Thu Oct 30 22:56:53 2014 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/169f5d96a5724fcb96686cdd1400cf9394813280 [^] Fixed issue 27836: QtyToGetGift has to be 0 for the product gift --- M web/org.openbravo.retail.discounts/js/promotion-buyXgiftY.js ---

(0071732) mtaal (manager) 2014-11-17 20:20	Reviewed and tested

Issue History
Date Modified	Username	Field	Change
2014-10-10 13:55	plujan	New Issue
2014-10-10 13:55	plujan	Assigned To	=> marvintm
2014-10-10 13:55	plujan	Triggers an Emergency Pack	=> No
2014-10-10 14:31	plujan	Issue cloned	0027840
2014-10-10 15:33	mtaal	Issue Monitored: mtaal
2014-10-10 15:33	mtaal	Assigned To	marvintm => szapata
2014-10-31 02:57	hgbot	Checkin
2014-10-31 02:57	hgbot	Note Added: 0071288
2014-10-31 02:57	hgbot	Status	new => resolved
2014-10-31 02:57	hgbot	Resolution	open => fixed
2014-10-31 02:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/169f5d96a5724fcb96686cdd1400cf9394813280 [^]
2014-11-17 20:20	mtaal	Review Assigned To	=> mtaal
2014-11-17 20:20	mtaal	Note Added: 0071732
2014-11-17 20:20	mtaal	Status	resolved => closed
2014-11-17 20:20	mtaal	Fixed in Version	=> RR15Q1