0027719: When saving a customer in the CustomerLoader also check for user names in other clients/org/inactive to prevent unique constrain

Description

In the CustomerLoader there is a piece of code which automatically changes the username if there is a collision with an existing user. The current query ignores users in other clients/inactive ones.

The query should also search for users in other clients/org/inactive

Steps To Reproduce

- Create a new user, give it a specific username (Jelle Taal or something), set the user to be inactive
- In WebPOS in customers dialog create a new user with firstname: Martin and second name: Taal, save
- See that a record is created in the POS import errors

Tags

No tags attached.

Attached Files

27719.diff [^] (770 bytes) 2014-09-30 14:54 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/CustomerLoader.java b/src/org/openbravo/retail/posterminal/CustomerLoader.java
--- a/src/org/openbravo/retail/posterminal/CustomerLoader.java
+++ b/src/org/openbravo/retail/posterminal/CustomerLoader.java
@@ -199,6 +199,9 @@
       final OBCriteria<org.openbravo.model.ad.access.User> userCriteria = OBDal.getInstance()
           .createCriteria(org.openbravo.model.ad.access.User.class);
       userCriteria.add(Restrictions.eq("username", possibleUsername));
+      userCriteria.setFilterOnReadableClients(false);
+      userCriteria.setFilterOnReadableOrganization(false);
+      userCriteria.setFilterOnActive(false);
       userCriteria.setMaxResults(1);
       usersWithPossibleUsername = userCriteria.count();

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0070719) hgbot (developer) 2014-10-05 23:17	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 5ed1c2d6ec1bb9d099fb328f34f984b82e56e0e6 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Oct 05 23:17:36 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ed1c2d6ec1bb9d099fb328f34f984b82e56e0e6 [^] Fixes issue 27719: when saving customer also check for inactive users The ad_user table has a unique constraint on the user name, so when searching for user name collisions then also search for inactive users and users of other clients/orgs --- M src/org/openbravo/retail/posterminal/CustomerLoader.java ---

Issue History
Date Modified	Username	Field	Change
2014-09-30 14:44	mtaal	New Issue
2014-09-30 14:44	mtaal	Assigned To	=> mtaal
2014-09-30 14:44	mtaal	OBNetwork customer	=> No
2014-09-30 14:44	mtaal	Triggers an Emergency Pack	=> No
2014-09-30 14:54	mtaal	File Added: 27719.diff
2014-10-05 23:17	hgbot	Checkin
2014-10-05 23:17	hgbot	Note Added: 0070719
2014-10-05 23:17	hgbot	Status	new => resolved
2014-10-05 23:17	hgbot	Resolution	open => fixed
2014-10-05 23:17	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ed1c2d6ec1bb9d099fb328f34f984b82e56e0e6 [^]
2014-10-07 12:38	szapata	Review Assigned To	=> szapata
2014-10-07 12:38	szapata	Status	resolved => closed