Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027690 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Discounts and Promotions | major | have not tried | 2014-09-25 18:49 | 2014-10-02 17:00 | |||
| Reporter | jonalegriaesarte | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR14Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d43b20a1455b | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | migueldejuana | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027690: Best deal case take too long in some cases | |||||||
| Description | Best deal case take too long in some cases. It depends on the options to analyze due to the combos, packs included in the ticket. | |||||||
| Steps To Reproduce | Example of configuration: 2 x Combo 1 = 4 product a 4 product b 2 product c 1x product d 1x product e 1x product f The application will freeze for at least 10 minutes before it goes to the next screen. | |||||||
| Proposed Solution | We can provide an environment where the configuration described takes some minutes to finish | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0070396) marvintm (manager) 2014-09-25 18:53 |
The cause of this problem is the pre filtering phase of the best deal case computation. This pre filtering will take too much time in case of a huge amount of potential combinations. Two changes will be implemented: - Some performance improvements will be applied so that the pre filtering phase takes less time per combination checked. - A maximum number of combinations to filter will be set, in case the organization has the preference defined to block the best deal case calculation in case the current ticket is too complex |
|
(0070397) hgbot (developer) 2014-09-25 19:01 |
Repository: erp/pmods/org.openbravo.retail.discounts.combo Changeset: ceb6c471eb154b7bcd1212fe2fa7feb64ddcb98c Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 25 18:58:48 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/ceb6c471eb154b7bcd1212fe2fa7feb64ddcb98c [^] Related to issue 27690. Replace .each by normal for loop to reduce the number of function calls in the stack. --- M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js --- |
|
(0070400) hgbot (developer) 2014-09-25 19:28 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 2385c117eb8bea9d9143d18ccf4e718493de2b2e Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 25 19:27:40 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2385c117eb8bea9d9143d18ccf4e718493de2b2e [^] Related to issue 27690. Increased max stack size to improve performance of findUsingCache method in ob-dal --- M web/org.openbravo.mobile.core/source/data/ob-dal.js --- |
|
(0070401) hgbot (developer) 2014-09-25 19:31 |
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal Changeset: d43b20a1455b593e64be0f0a3c1a17514e8d70b5 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 25 19:31:14 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/d43b20a1455b593e64be0f0a3c1a17514e8d70b5 [^] Fixed issue 27690. Added check to stop the best deal case calculation in case the amount of prefiltered combinations is too big, and the 'stop long bdc' preference is set in the organization. --- M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js --- |
|
(0070408) hgbot (developer) 2014-09-25 20:26 |
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal Changeset: 360b4c3d0db813e6c050dc65aa1579bdf32423fe Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 25 20:26:20 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/360b4c3d0db813e6c050dc65aa1579bdf32423fe [^] Related to issue 27690. Changed the criteria to stop early. Now it's based on number of lines in combinations, to make it more accurate. --- M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js --- |
|
(0070409) hgbot (developer) 2014-09-25 20:28 |
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal Changeset: 6d395a649e19ddb369c3ff025d0793a9b1941dd8 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 25 20:28:39 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/6d395a649e19ddb369c3ff025d0793a9b1941dd8 [^] Related to issue 27690. Removed unneeded change. --- M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js --- |
|
(0070666) migueldejuana (developer) 2014-10-02 17:00 |
Tested and reviewed in 7df701d05751 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-09-25 18:49 | jonalegriaesarte | New Issue | |
| 2014-09-25 18:49 | jonalegriaesarte | Assigned To | => marvintm |
| 2014-09-25 18:49 | jonalegriaesarte | Resolution time | => 1410472800 |
| 2014-09-25 18:49 | jonalegriaesarte | Triggers an Emergency Pack | => No |
| 2014-09-25 18:53 | marvintm | Note Added: 0070396 | |
| 2014-09-25 19:01 | hgbot | Checkin | |
| 2014-09-25 19:01 | hgbot | Note Added: 0070397 | |
| 2014-09-25 19:28 | hgbot | Checkin | |
| 2014-09-25 19:28 | hgbot | Note Added: 0070400 | |
| 2014-09-25 19:31 | hgbot | Checkin | |
| 2014-09-25 19:31 | hgbot | Note Added: 0070401 | |
| 2014-09-25 19:31 | hgbot | Status | new => resolved |
| 2014-09-25 19:31 | hgbot | Resolution | open => fixed |
| 2014-09-25 19:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/d43b20a1455b593e64be0f0a3c1a17514e8d70b5 [^] |
| 2014-09-25 20:26 | hgbot | Checkin | |
| 2014-09-25 20:26 | hgbot | Note Added: 0070408 | |
| 2014-09-25 20:28 | hgbot | Checkin | |
| 2014-09-25 20:28 | hgbot | Note Added: 0070409 | |
| 2014-10-02 17:00 | migueldejuana | Review Assigned To | => migueldejuana |
| 2014-10-02 17:00 | migueldejuana | Note Added: 0070666 | |
| 2014-10-02 17:00 | migueldejuana | Status | resolved => closed |
| 2014-10-02 17:00 | migueldejuana | Fixed in Version | => RR14Q4 |
| 2015-10-27 13:27 | marvintm | Relationship added | has duplicate 0031073 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |