Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027662
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-09-23 15:252015-09-15 17:49
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revisiona7fad012414b
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027662: Remote request to org.openbravo.mobile.core.login.Context to check login status causes a record to be created in ad_session tabl

DescriptionThe code below in the ob-terminal-model.js file checks if the user is logged in. This call results in an extra record in the ad_session table. This should not happen, no record should be created in that table for this.

 me.trigger('initializedCommonComponents');
        me.preLoadContext(function () {
          new OB.DS.Request('org.openbravo.mobile.core.login.Context').exec({
            ignoreForConnectionStatus: true
          }, function (inResponse) {
            OB.MobileApp.model.triggerOnLine();
            if (inResponse && !inResponse.exception) {
              OB.MobileApp.model.user = inResponse[0].user.username;
              if (me.isUserCacheAvailable() && window.localStorage.getItem('cacheAvailableForUser:' + OB.MobileApp.model.user)) {
                me.loginUsingCache();
              } else {
                OB.MobileApp.model.set('orgUserId', inResponse[0].user.id);
                OB.UTIL.showLoading(true);
                me.set('context', inResponse[0]);
                me.renderTerminalMain();
              }
            } else {
Steps To Reproduce- check count in ad_session table
- open webpos page, login page is shown
- check that the count in the session table has increased by one
TagsNo tags attached.
Attached Filespng file icon Selection_007.png [^] (341,142 bytes) 2015-09-09 10:22

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0080271)
mtaal (manager)
2015-09-09 10:23

Happens in pi-q4 still, could be related to the message shown in the attachment
(0080272)
mtaal (manager)
2015-09-09 10:39

Tested again in pi-q4, when opening the webpos page several requests are done. I tested individual requests by opening an anonymous chrome for each one by one. The list is below. Only this request resulted in an extra record in ad_session:
http://localhost:8080/openbravo/org.openbravo.mobile.core.context?ignoreForConnectionStatus=true [^]

The other requests didn't:
http://localhost:8080/openbravo/org.openbravo.retail.posterminal.service.loginutils?terminalName=VBS-1&command=initActions&0.8726465555373579 [^]

http://localhost:8080/openbravo/org.openbravo.mobile.core/OBMOBC_Main/ClientModel?entity=FinancialMgmtTaxRate&modelName=TaxRate&source=org.openbravo.retail.posterminal.master.TaxRate [^]

http://localhost:8080/openbravo/org.openbravo.retail.posterminal.service.loginutils?terminalName=VBS-1&command=preRenderActions [^]

http://localhost:8080/openbravo/org.openbravo.retail.posterminal.service.loginutils?terminalName=VBS-1&command=companyLogo&appName=WebPOS&0.9206963295582682 [^]

http://localhost:8080/openbravo/org.openbravo.retail.posterminal.service.loginutils?terminalName=VBS-1&command=userImages&appName=WebPOS&0.1618948788382113 [^]
(0080305)
hgbot (developer)
2015-09-10 09:09

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a7fad012414bc6b03a8b8800f27582d824d1d092
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 09 11:59:35 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a7fad012414bc6b03a8b8800f27582d824d1d092 [^]

Fixes issue 27662: Remote request to org.openbravo.mobile.core.login.Context to check login status causes a record to be created in ad_session tabl
Check for isAuthenticated in a more explicit way without calling authentication manager

---
M src/org/openbravo/mobile/core/login/Context.java
---
(0080422)
migueldejuana (developer)
2015-09-15 17:49

Tested and reviewed in 5fa909d5e1af

- Issue History
Date Modified Username Field Change
2014-09-23 15:25 mtaal New Issue
2014-09-23 15:25 mtaal Assigned To => mtaal
2014-09-23 15:25 mtaal Triggers an Emergency Pack => No
2014-09-30 17:42 mtaal Target Version => RR15Q1
2014-12-01 16:12 shuehner Issue Monitored: shuehner
2014-12-08 11:51 mtaal Target Version RR15Q1 => RR15Q2
2015-03-30 20:14 marvintm Target Version RR15Q2 => RR15Q3
2015-06-15 18:16 marvintm Target Version RR15Q3 => RR15Q4
2015-09-09 10:22 mtaal File Added: Selection_007.png
2015-09-09 10:23 mtaal Note Added: 0080271
2015-09-09 10:39 mtaal Note Added: 0080272
2015-09-10 09:09 hgbot Checkin
2015-09-10 09:09 hgbot Note Added: 0080305
2015-09-10 09:09 hgbot Status new => resolved
2015-09-10 09:09 hgbot Resolution open => fixed
2015-09-10 09:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a7fad012414bc6b03a8b8800f27582d824d1d092 [^]
2015-09-15 14:00 mtaal Review Assigned To => migueldejuana
2015-09-15 17:49 migueldejuana Note Added: 0080422
2015-09-15 17:49 migueldejuana Status resolved => closed
2015-09-15 17:49 migueldejuana Fixed in Version => RR15Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker