Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0027466 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Retail Modules] Web POS | critical | always | 2014-08-26 02:10 | 2014-10-02 03:42 | |||
Reporter | Orekaria | View Status | public | |||||
Assigned To | Orekaria | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR14Q4 | |||
Status | closed | Fix in branch | pi | Fixed in SCM revision | add14f5332a1 | |||
Projection | none | ETA | none | Target Version | RR14Q4 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | marvintm | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0027466: Stabilization: The route (OBRoute) object should be use to redirect to the proper webpage | |||||||
Description | Stabilization: The route object should be use to redirect to the proper webpage | |||||||
Steps To Reproduce | In ob-terminal-component verify that OB.MobileApp.model.initializeCommonComponents() is called In ob-terminal-model verify that the loading process skips the router, which is undesired The router should handle the loading of the proper environment | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||||||||||||||||
|
Notes | |
(0069732) hgbot (developer) 2014-08-26 03:46 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 8bf9dfb3aaffff04e49d7e54b72562ec829408eb Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Aug 26 03:46:18 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8bf9dfb3aaffff04e49d7e54b72562ec829408eb [^] Issue 27466: The router (OBRoute) will handle the routing to the proper webpage --- M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070069) hgbot (developer) 2014-09-10 00:12 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 76f96280afa385720c866a145cbb4dde798c4c40 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed Sep 10 00:12:05 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/76f96280afa385720c866a145cbb4dde798c4c40 [^] Fixes issue 27466: Refactor of navigation logic (II, core) - removed the redirect when the window was not the root, as it is no longer necessary - window.onload used to initialize the router - removed unnecessary hack code 'executeWhenDOMReady' - added some checks with debug messages to prevent loading inexistent windows or code - added more log while in debug --- M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070070) hgbot (developer) 2014-09-10 00:13 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b26a27cdae6ff505c856d73e0cec141bfaaeebcf Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed Sep 10 00:12:13 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b26a27cdae6ff505c856d73e0cec141bfaaeebcf [^] Fixes issue 27466: Refactor of navigation logic (II, posterminal) - removed the redirect when the window was not the root, as it is no longer necessary - window.onload used to initialize the router - removed unnecessary hack code 'executeWhenDOMReady' - added some checks with debug messages to prevent loading inexistent windows or code - added more log while in debug --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
(0070304) hgbot (developer) 2014-09-24 10:48 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6a811fb0a0e6355aace1994066e84208de75623d Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed Sep 24 10:47:50 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a811fb0a0e6355aace1994066e84208de75623d [^] Fixes issue 27466: Refactor of navigation logic (III, posterminal) - some code from the body has been moved to the head - the logic now informs that the body content will be replaced - used addEventListener for better compatibility --- M web/org.openbravo.retail.posterminal/index.jsp --- |
(0070305) hgbot (developer) 2014-09-24 10:48 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 66f8b45fcd7529d8858bd418e233d36a2ccb147d Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed Sep 24 10:42:22 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/66f8b45fcd7529d8858bd418e233d36a2ccb147d [^] Fixes issue 27466: Refactor of navigation logic (III, core) - some code from the body has been moved to the head - the logic now informs that the body content will be replaced - used addEventListener for better compatibility --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070513) hgbot (developer) 2014-09-29 19:52 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: ec891e6512fbaece4b48e5cb811842533a10ca81 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Mon Sep 29 19:51:47 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec891e6512fbaece4b48e5cb811842533a10ca81 [^] Fixes issue 27466: OBRouter has, finally, been moved to its own file - the file 'ob-router' has been added - a new OB.Model.RouterHelper class has been created with the same content as the OBRouter - the terminal model now references this namespace - the initialization of the objects in the terminal model have been collected - the code is exactly the same as before --- M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js A web/org.openbravo.mobile.core/source/model/ob-router.js --- |
(0070523) hgbot (developer) 2014-09-30 04:03 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 7a903e4abd46838e765dd98409bea97d3bc58348 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 04:01:39 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7a903e4abd46838e765dd98409bea97d3bc58348 [^] Fixes issue 27466: Refactor for the navigation logic (IV, core) - the navigation has been refactored for better load flow - the url of the page is now again in line with the window loaded - the initialization of the localdatabase has been moved from 'initLocalDB' to the 'OB.Dal.openWebSQL' method, but still will initialize the database if called - the 'loadQueue' from 'loadTerminalInfo' has been renamed to 'loadTerminalInfoQueue' to be different from the 'loadModels' queue as they are different flows --- M web/org.openbravo.mobile.core/source/data/ob-dal.js M web/org.openbravo.mobile.core/source/model/ob-router.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070525) hgbot (developer) 2014-09-30 04:03 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 89cc639ad5c19ece0cedbc5b17946d92daec0ebc Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 04:02:46 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/89cc639ad5c19ece0cedbc5b17946d92daec0ebc [^] Fixes issue 27466: Refactor for the navigation logic (IV, posterminal) - the navigation has been refactored for better load flow - the url of the page is now again in line with the window loaded - the initialization of the localdatabase has been moved from 'initLocalDB' to the 'OB.Dal.openWebSQL' method, but still will initialize the database if called - the 'loadQueue' from 'loadTerminalInfo' has been renamed to 'loadTerminalInfoQueue' to be different from the 'loadModels' queue as they are different flows --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
(0070526) hgbot (developer) 2014-09-30 04:11 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 98c61758c2720e3560f80276a8ebad7032775af4 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 04:11:05 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/98c61758c2720e3560f80276a8ebad7032775af4 [^] Fixes issue 27466: Refactor for the navigation logic (IV, core) - the lines commented are wrong, commenting the correct ones --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070562) hgbot (developer) 2014-09-30 15:39 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: e68d94f8a084da134a72f1a86acbaf4ac5ad3214 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 15:39:16 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e68d94f8a084da134a72f1a86acbaf4ac5ad3214 [^] Fixes issue 27466, related to issue 27409: Refactor for the navigation logic (IV, core) - the database will be reopened after chrome closes it ('forcibly closing database') - better logging for ob-dal - the error when 'OB.Dal.find' fails because the table is still not present has been changed to warn - the 'OB.Dal.save' now catch database transaction errors. this approach should be extended to any transaction - more argument checks --- M web/org.openbravo.mobile.core/source/data/ob-dal.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070574) hgbot (developer) 2014-09-30 19:04 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 359302769b41c71e55e217ece3854a30139b3b67 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 19:03:34 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/359302769b41c71e55e217ece3854a30139b3b67 [^] Related to issue 27466: the terminalName will be saved in the localStorage if it was not present - this value is used also to check if the user changed the terminal --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
(0070575) hgbot (developer) 2014-09-30 19:04 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: eb97d8d3412a6d5b0dc191438e7e391c65aba310 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 19:04:41 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eb97d8d3412a6d5b0dc191438e7e391c65aba310 [^] Fixes issue 27466: Refactor for the navigation logic (IVc, core) - when the database version changes, the tables will be dropped if its safe to drop them; if not, a message will be shown - the flow when the user changes the terminal has been also fixed --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070581) hgbot (developer) 2014-09-30 20:43 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 741bce8fb97266e49a0b9d54f9a8ef8d4d84cd0e Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 20:43:04 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/741bce8fb97266e49a0b9d54f9a8ef8d4d84cd0e [^] Fixes issue 27466: Refactor for the navigation logic (IVd, core) - added a console warn when the database version has changed - added a console warn when the terminal changed --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070582) hgbot (developer) 2014-09-30 20:44 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b1b0a5ddd7393ccd706679cff879b5927e5fd4b7 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 20:44:38 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b1b0a5ddd7393ccd706679cff879b5927e5fd4b7 [^] Related to issue 27466: when the terminalName is empty, do not save it to the localStorage --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
(0070584) hgbot (developer) 2014-09-30 21:50 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: fd9bc44f91d3aa261ceec069c2ce85d76b5a8305 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 21:49:53 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fd9bc44f91d3aa261ceec069c2ce85d76b5a8305 [^] Fixes issue 27466: Refactor for the navigation logic (IVd, core) - the terminal lock has been moved to the 'databaseCannotBeResetAction' method --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070585) hgbot (developer) 2014-09-30 21:52 |
Repository: tools/automation/pi-mobile Changeset: 705ebe1bb536101adc83911c064845e8cc478afb Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 21:52:31 2014 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/705ebe1bb536101adc83911c064845e8cc478afb [^] Related to issue 27466: added 4 tests to verify the terminal change process --- M src-test/org/openbravo/retail/integrationtest/tests/general/loginout/LoginoutTestSuite.java A src-test/org/openbravo/retail/integrationtest/tests/general/loginout/TerminalChangeI.java A src-test/org/openbravo/retail/integrationtest/tests/general/loginout/TerminalChangeII.java A src-test/org/openbravo/retail/integrationtest/tests/general/loginout/TerminalChangeIII.java A src-test/org/openbravo/retail/integrationtest/tests/general/loginout/TerminalChangeIV.java --- |
(0070598) hgbot (developer) 2014-10-01 09:00 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: add14f5332a1bc60bef36e6f737a882ddba7887b Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Tue Sep 30 21:49:45 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/add14f5332a1bc60bef36e6f737a882ddba7887b [^] Fixes issue 27466: Refactor for the navigation logic (IVd, core) - the terminal lock has been moved to the 'databaseCannotBeResetAction' method - the message has been improved - the terminal will lock --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
(0070638) hgbot (developer) 2014-10-02 03:34 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 105d06f6cea8199dba8404447a36a6bce9f09889 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Thu Oct 02 03:30:57 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/105d06f6cea8199dba8404447a36a6bce9f09889 [^] Related to issue 27466: Refactor for the navigation logic (V, core) - the database is opened regardless the version - if the 'processPropertyLoaders' condition happen, the cache flag is set to false - the terminal change will be propertly checked to meet the changes after the cashup back out - after a successful terminal change, a logout will be performed --- M web/org.openbravo.mobile.core/source/data/ob-dal.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0070640) hgbot (developer) 2014-10-02 03:42 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: aea044e8169f30b344e8f89830b992e791252634 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Thu Oct 02 03:41:40 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aea044e8169f30b344e8f89830b992e791252634 [^] Related to issue 27466: Refactor for the navigation logic (V, posterminal) - the 'isSafeToResetDatabase' method has been fixed to correctly check if the cashup has data that cannot be removed --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
Copyright © 2000 - 2009 MantisBT Group |