Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027434 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | trivial | have not tried | 2014-08-23 14:14 | 2014-10-16 10:37 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | f65eeca4b228 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | eduardo_Argal | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027434: Delete c_dp_managementline_trg as it is useless | |||||||
| Description | This trigger is run on insert + updates. But only has code for insert. All it's code is inside (new:status_from IS NULL). However that column status_from is table c_dp_managementline is defined as 'not null' So none of that code is ever run. NOTE: This table is related to 'Old-flow' so in normal operation not even used. | |||||||
| Steps To Reproduce | Review code of that trigger and compare to table definition | |||||||
| Proposed Solution | Just delete the whole trigger. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0070805) hgbot (developer) 2014-10-08 12:45 |
Repository: erp/devel/pi Changeset: f65eeca4b22845d2f65ed92f83cf7b2f488e8f9b Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Oct 07 18:25:57 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f65eeca4b22845d2f65ed92f83cf7b2f488e8f9b [^] Fixed 27434. Deleted useless trigger C_DP_MANAGEMENTLINE_TRG. All code for this trigger is inside an if :new.status_from == null check Checking definition of that status_from column in the c_dp_managementline table shows that it is defined as not null (as has been since hg revision 0). So that condition can never be true so all the trigger is not useful. --- R src-db/database/model/triggers/C_DP_MANAGEMENTLINE_TRG.xml --- |
|
(0070985) eduardo_Argal (developer) 2014-10-16 10:37 |
Reviewed and closed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-08-23 14:14 | shuehner | New Issue | |
| 2014-08-23 14:14 | shuehner | Assigned To | => dmiguelez |
| 2014-08-23 14:14 | shuehner | Modules | => Core |
| 2014-08-23 14:14 | shuehner | Triggers an Emergency Pack | => No |
| 2014-08-23 14:21 | shuehner | Relationship added | related to 0027435 |
| 2014-09-03 13:57 | eduardo_Argal | Assigned To | dmiguelez => shuehner |
| 2014-10-07 18:26 | shuehner | Review Assigned To | => eduardo_Argal |
| 2014-10-08 12:45 | hgbot | Checkin | |
| 2014-10-08 12:45 | hgbot | Note Added: 0070805 | |
| 2014-10-08 12:45 | hgbot | Status | new => resolved |
| 2014-10-08 12:45 | hgbot | Resolution | open => fixed |
| 2014-10-08 12:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f65eeca4b22845d2f65ed92f83cf7b2f488e8f9b [^] |
| 2014-10-16 10:37 | eduardo_Argal | Note Added: 0070985 | |
| 2014-10-16 10:37 | eduardo_Argal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |