Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0027405

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

major

have not tried

2014-08-21 12:11

2014-08-25 08:03

Reporter

AugustoMauch

View Status

public

Assigned To

AugustoMauch

Priority

urgent

Resolution

fixed

Fixed in Version

3.0PR14Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0PR14Q4

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

shankarb

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0027405: Problems filtering P&E grids in slow environments

Description

The is a problem when filtering the P&E grids with the following conditions:
- There are some records selected
- A request is done to the grid datasource while other previous request is in progress. This can be done by filtering a text field one keystroke at a time, if the server is slow.

When this happens, an error is shown in the javascript console and the records are not filtered properly.

Steps To Reproduce

- Install the attached patch. It will simulate a slow server, and it will provide a P&E with more than 100 records.
- Compile
- Open the Sales Invoice window
- Select a record with Total Outstanding > 0
- Click on the Add Payment Button. The Order/Invoice grid should have lots of records.
- Enter a '1' in the Invoice No filter, and a '2' just after the Loading data message is shown. An errror will be shown in the javascript console and the grid will not be filtered properly.

Tags

No tags attached.

testIssue27405.diff [^] (1,972 bytes) 2014-08-21 12:12 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
@@ -94,7 +94,8 @@
 
     String transformedHql = hqlQuery.replace("@selectClause@", selectClause.toString());
     transformedHql = transformedHql.replace("@joinClause@", " ");
-    transformedHql = transformedHql.replace("@whereClause@", whereClause.toString());
+    // transformedHql = transformedHql.replace("@whereClause@", whereClause.toString());
+    transformedHql = transformedHql.replace("@whereClause@", " 1=1 ");
     transformedHql = transformedHql.replace("@groupByClause@", groupByClause.toString());
     transformedHql = appendOrderByClause(transformedHql, orderByClause, justCount);
     // Sets parameters
diff --git a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
@@ -291,6 +291,10 @@
 
     Query query = OBDal.getInstance().getSession().createQuery(hqlQuery);
 
+    try {
+      Thread.sleep(3000);
+    } catch (InterruptedException e) {
+    }
     // sets the parameters of the query
     for (String key : queryNamedParameters.keySet()) {
       // Injection and transforms might have modified the query removing named parameters. Check

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0069568) hgbot (developer) 2014-08-21 12:16	Repository: erp/devel/pi Changeset: 12574ebf963a9a8a9a84da1cf84dcfa1f2384d5f Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Aug 21 12:14:32 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/12574ebf963a9a8a9a84da1cf84dcfa1f2384d5f [^] Fixes issue 27405: Problems filtering P&E grids in slow environments The problem was that when the response of the first datasource request was received, the second one was already in progress, so the grid local data only contained 'loading' records. At that point the grid local data was not accessible. To fix this, now it takes into accout if the grid local data can be accessed. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js ---

(0069594) hudsonbot (viewer) 2014-08-22 04:18	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/077608c0d57c [^] Maturity status: Test

(0069696) shankarb (viewer) 2014-08-25 08:03	Code reviewed and verified in pi changeset 09ce5c4deb2b.

Issue History
Date Modified	Username	Field	Change
2014-08-21 12:11	AugustoMauch	New Issue
2014-08-21 12:11	AugustoMauch	Assigned To	=> AugustoMauch
2014-08-21 12:11	AugustoMauch	OBNetwork customer	=> No
2014-08-21 12:11	AugustoMauch	Modules	=> Core
2014-08-21 12:11	AugustoMauch	Triggers an Emergency Pack	=> No
2014-08-21 12:12	AugustoMauch	File Added: testIssue27405.diff
2014-08-21 12:14	AugustoMauch	Issue Monitored: shankarb
2014-08-21 12:14	AugustoMauch	Review Assigned To	=> shankarb
2014-08-21 12:16	hgbot	Checkin
2014-08-21 12:16	hgbot	Note Added: 0069568
2014-08-21 12:16	hgbot	Status	new => resolved
2014-08-21 12:16	hgbot	Resolution	open => fixed
2014-08-21 12:16	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/12574ebf963a9a8a9a84da1cf84dcfa1f2384d5f [^]
2014-08-22 04:18	hudsonbot	Checkin
2014-08-22 04:18	hudsonbot	Note Added: 0069594
2014-08-25 08:03	shankarb	Note Added: 0069696
2014-08-25 08:03	shankarb	Status	resolved => closed
2014-08-25 08:03	shankarb	Fixed in Version	=> 3.0PR14Q4

Copyright © 2000 - 2009 MantisBT Group