Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027388
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Payment Aging Balance Reportmajoralways2014-08-20 13:062014-10-14 14:01
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision595928b476b2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0027388: Wrong amount shown in Credits column if the credit is used in a payment with more than one line

DescriptionWrong amount shown in Credits column if the credit is used in a payment with more than one line
Steps To ReproduceAs group admin role:
   Create two Sales Invoices for the same business partner
   Generate credit to pay both invoices for that Business Partner
   Due to 27387 bug, you should update the isinvoicepaid column of the fin_payment_scheduledetail associated with the previous partner to 'Y'
   Pay the two invoices with that credit
   Launch the Receivables Aging Schedule with a date higher or equal the 2nd payment date and check a wrong amount is shown in the Credits column
Proposed SolutionCheck the getCreditLeft function of the AgingDao.java file
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0027387 closedreinaldoguerra Generated credits are not shown in the report 

-  Notes
(0069833)
jonalegriaesarte (reporter)
2014-08-28 14:00

 Changing the query to something like below seems to work correctly

select sum(credit.amount)
from FIN_Payment_Credit as credit
left outer join credit.payment as payment
where
credit.creditPaymentUsed.id = id
and trunc(payment.paymentDate) <= date
and exists ( from payment.fINPaymentDetailList as pd
left outer join pd.fINPaymentScheduleDetailList as psd where psd.invoicePaid='Y')
(0070890)
reinaldoguerra (developer)
2014-10-12 03:06

 Test plan used:
1- Login into Openbravo ERP
2- Go to Sales Invoices window and create two of them for the same business partner and payment method.
3- Complete the created invoices.
4- Go to "Payment in" window and create a new record selecting created invoices same payment method and business partner in "Received From" field
5- Enter an amount that exceeds the sum of Line Net Amount of the invoices.
6- Open add details section and uncheck the invoices created previously.
7- Select "Leave the credit to be used later" and complete the process.
8- This action generates a credit with the entered amount for the selected business partner.
9- Create a new "Payment in" for the same business partner and payment method but with amount to zero.
10- Now when adding details select invoices created previously and set the expected amount in payment amount of the "credit to use" grid.
11- This action generates a used credit to pay both invoices for that Business Partner also registered on "Used Credit Source" tab.
12- Now when launching Receivables Aging Schedule report the credit column will show the remanent credit that exists for selected business partner taking into account the currency conversion.
(0070922)
hgbot (developer)
2014-10-14 13:44

 Repository: erp/mods/org.openbravo.agingbalance
Changeset: 595928b476b2b6af5c9c88f6e93303a113f88a0a
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Tue Oct 07 22:43:02 2014 -0500
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/595928b476b2b6af5c9c88f6e93303a113f88a0a [^]

Fixed bug 27388: Wrong amount for credit used in payment with more than one line

getCreditLeft method hql query of the AgingDao class now suppresses direct join between FIN_Payment_Credit and FIN_PaymentDetail to eliminate the duplicated sum of amount field.
Now when a credit is used in payments with more than one line, only sum of used credit source amount related with each payment is taking into account.

---
M src/org/openbravo/agingbalance/ad_reports/AgingDao.java
---
(0070925)
vmromanos (manager)
2014-10-14 13:45

 Code review + testing OK

Published new module version 3.1.35
(0070926)
vmromanos (manager)
2014-10-14 14:01

 Updating the Review Assigned To field that was wrongly filled

- Issue History
Date Modified Username Field Change
2014-08-20 13:06 ngarcia New Issue
2014-08-20 13:06 ngarcia Assigned To => jonalegriaesarte
2014-08-20 13:06 ngarcia Resolution time => 1411336800
2014-08-20 13:07 ngarcia Relationship added depends on 0027387
2014-08-20 13:07 ngarcia Issue Monitored: networkb
2014-08-20 13:13 ngarcia Proposed Solution updated
2014-08-20 13:15 ngarcia Proposed Solution updated
2014-08-28 08:41 eintelau Issue Monitored: eintelau
2014-08-28 09:31 rtaxerxes Issue Monitored: rtaxerxes
2014-08-28 13:59 jonalegriaesarte Assigned To jonalegriaesarte => AtulOpenbravo
2014-08-28 14:00 jonalegriaesarte Note Added: 0069833
2014-10-12 03:06 reinaldoguerra Note Added: 0070890
2014-10-14 13:44 hgbot Checkin
2014-10-14 13:44 hgbot Note Added: 0070922
2014-10-14 13:44 hgbot Status new => resolved
2014-10-14 13:44 hgbot Resolution open => fixed
2014-10-14 13:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/595928b476b2b6af5c9c88f6e93303a113f88a0a [^]
2014-10-14 13:45 vmromanos Review Assigned To => villind
2014-10-14 13:45 vmromanos Note Added: 0070925
2014-10-14 13:45 vmromanos Status resolved => closed
2014-10-14 14:01 vmromanos Review Assigned To villind => vmromanos
2014-10-14 14:01 vmromanos Note Added: 0070926

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker