0027246: Error when setting count function in analytics window

(0069316)
AugustoMauch (administrator)
2014-08-12 15:10

I can't reproduce the issue. The count summary function works properly in the Analytics Sales Detail View window, see attached screenshot.

(0069317)
mtaal (viewer)
2014-08-12 15:14

Hey Augusto,
One thing is that I had set a filter in the cost colum with: > 0
so it shows all the records with cost larger than 0

Can you try that?

gr. Martin

(0069332)
AugustoMauch (administrator)
2014-08-13 08:30

I can reproduce by setting the summary field in the Sales Order Line column.

(0069336)
AugustoMauch (administrator)
2014-08-13 10:10

This happens when the column used in the count summary function points to a table that has at least one non-primitive identifier property that points to another table that has more than one identifier property (primitive or non-primitive).

In this case, the identifier of Sales Order Line uses the identifier of Sales Order, which has three identifier properties.

(0069337)
hgbot (developer)
2014-08-13 10:16

Repository: erp/devel/pi
Changeset: ce5524b59abfc64fd83bfb86b4f919e51ca3c897
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 13 10:15:49 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ce5524b59abfc64fd83bfb86b4f919e51ca3c897 [^]

Fixes issue 27246: Error when setting count function in analytics window

The problem was that a select clause like this was being used in a HQL query:
* select count(e.salesOrder.documentNo + join_1.orderDate + join_1.grandTotalAmount) from ...

Property concatenation is not supported in a count function, it does not even make sense. To fix this, the addSelectFunctionPart method of AdvancedQueryBuilder has been updated so that '*' is always used inside the count function.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---

(0069360)
hudsonbot (viewer)
2014-08-14 04:01

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/39d7672e843c [^]
Maturity status: Test

(0069424)
mtaal (viewer)
2014-08-17 15:32

Works!

Issue History
Date Modified	Username	Field	Change
2014-07-31 09:30	mtaal	New Issue
2014-07-31 09:30	mtaal	Assigned To	=> mtaal
2014-07-31 09:30	mtaal	File Added: Selection_009.png
2014-07-31 09:30	mtaal	OBNetwork customer	=> No
2014-08-12 15:09	AugustoMauch	Assigned To	mtaal => AugustoMauch
2014-08-12 15:10	AugustoMauch	Note Added: 0069316
2014-08-12 15:10	AugustoMauch	Status	new => feedback
2014-08-12 15:11	AugustoMauch	File Added: AnalyticsCount.png
2014-08-12 15:14	mtaal	Note Added: 0069317
2014-08-13 08:30	AugustoMauch	Note Added: 0069332
2014-08-13 08:30	AugustoMauch	Status	feedback => new
2014-08-13 10:07	AugustoMauch	Project	Modules => Openbravo ERP
2014-08-13 10:10	AugustoMauch	Note Added: 0069336
2014-08-13 10:16	AugustoMauch	Issue Monitored: mtaal
2014-08-13 10:16	AugustoMauch	Review Assigned To	=> mtaal
2014-08-13 10:16	AugustoMauch	Modules	=> Core
2014-08-13 10:16	AugustoMauch	Triggers an Emergency Pack	=> No
2014-08-13 10:16	AugustoMauch	Category	Analytics => 00. Application dictionary
2014-08-13 10:16	hgbot	Checkin
2014-08-13 10:16	hgbot	Note Added: 0069337
2014-08-13 10:16	hgbot	Status	new => resolved
2014-08-13 10:16	hgbot	Resolution	open => fixed
2014-08-13 10:16	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/ce5524b59abfc64fd83bfb86b4f919e51ca3c897 [^]
2014-08-14 04:01	hudsonbot	Checkin
2014-08-14 04:01	hudsonbot	Note Added: 0069360
2014-08-17 15:32	mtaal	Note Added: 0069424
2014-08-17 15:32	mtaal	Status	resolved => closed

Notes
(0069316) AugustoMauch (administrator) 2014-08-12 15:10	I can't reproduce the issue. The count summary function works properly in the Analytics Sales Detail View window, see attached screenshot.

(0069317) mtaal (viewer) 2014-08-12 15:14	Hey Augusto, One thing is that I had set a filter in the cost colum with: > 0 so it shows all the records with cost larger than 0 Can you try that? gr. Martin

(0069332) AugustoMauch (administrator) 2014-08-13 08:30	I can reproduce by setting the summary field in the Sales Order Line column.

(0069336) AugustoMauch (administrator) 2014-08-13 10:10	This happens when the column used in the count summary function points to a table that has at least one non-primitive identifier property that points to another table that has more than one identifier property (primitive or non-primitive). In this case, the identifier of Sales Order Line uses the identifier of Sales Order, which has three identifier properties.

(0069337) hgbot (developer) 2014-08-13 10:16	Repository: erp/devel/pi Changeset: ce5524b59abfc64fd83bfb86b4f919e51ca3c897 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Aug 13 10:15:49 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ce5524b59abfc64fd83bfb86b4f919e51ca3c897 [^] Fixes issue 27246: Error when setting count function in analytics window The problem was that a select clause like this was being used in a HQL query: * select count(e.salesOrder.documentNo + join_1.orderDate + join_1.grandTotalAmount) from ... Property concatenation is not supported in a count function, it does not even make sense. To fix this, the addSelectFunctionPart method of AdvancedQueryBuilder has been updated so that '*' is always used inside the count function. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java ---

(0069360) hudsonbot (viewer) 2014-08-14 04:01	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/39d7672e843c [^] Maturity status: Test

(0069424) mtaal (viewer) 2014-08-17 15:32	Works!

Relationships [ Relation Graph ] [ Dependency Graph ]